[Bug 1563184] New: Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Bug ID: 1563184
           Summary: Review Request: rpkg-util - RPM packaging utility
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://clime.cz/rpkg-util.spec
SRPM URL: https://clime.cz/rpkg-util-1.0.git.198.d77c2b9-1.fc27.src.rpm

Description: This is an RPM packaging utility based on python-rpkg library.
It works with both DistGit and standard Git repositories and
it handles packed directory content as well as unpacked content.

Fedora Account System Username: clime

This is rename of the wrapper package. Before it was rpkg-client. Now it is
called rpkg-util. Executable is still `rpkg`.

It should replace this package: https://src.fedoraproject.org/rpms/rpkg-client

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #2 from Neal Gompa  ---
Package build fails on %check section:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.oJ7Crn
+ umask 022
+ cd /builddir/build/BUILD
+ cd rpkg-util-1.0.git.198.d77c2b9
+ FULL=1
+ ./run_tests.sh
============================= test session starts
==============================
platform linux2 -- Python 2.7.14, pytest-3.4.2, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/rpkg-util-1.0.git.198.d77c2b9, inifile:
collected 29 items
BUILDSTDERR: tests/test_cli.py .This function is deprecated and will be removed
in a future release.
BUILDSTDERR: .This function is deprecated and will be removed in a future
release.
BUILDSTDERR: ..Auto-packing is deprecated and will be removed in a future
release.
BUILDSTDERR: .....This function is deprecated and will be removed in a future
release.
BUILDSTDERR: This function is deprecated and will be removed in a future
release.
.
BUILDSTDERR: tests/test_cmd.py ..........error: Package has no %description:
testpkg
.......
tests/test_lookaside.py .
tests/test_utils.py .
========================== 29 passed in 0.83 seconds
===========================
====================== test_bash ======================
Initialized empty Git repository in /tmp/tmp.AnQ2iUXGBa/.git/
> ../preproc.py --path /tmp/tmp.AnQ2iUXGBa --input /tmp/tmp.AnQ2iUXGBa/input --output /tmp/tmp.wkDoLIha3j/output | log_filter &> /tmp/tmp.wkDoLIha3j/log
> diff /tmp/tmp.CNJEmyUSlI /tmp/tmp.wkDoLIha3j/output || die

3c3
< date --date='@2147483647' +%y%m%d: 380119
---
> date --date='@2147483647' +%y%m%d: 380118

fail.
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check)
RPM build errors:
BUILDSTDERR:     Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check)
Child return code was: 1

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #3 from [e-mail] ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhi...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhi...

Can you re-review, please?

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #4 from Neal Gompa  ---
Review notes:
[x] Package is named appropriately
[x] Licensing is correctly noted and license files are correctly installed
[x] Packaging follows Fedora Python Packaging Guidelines
[!] Packaging follows Fedora Packaging Guidelines
    * VCS tag is used, Source0 isn't verifiable
    * Version scheme doesn't follow current snapshot release guidelines

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #5 from [e-mail] ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhi...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhi...

...fixes according to the review notes.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #6 from [e-mail] ---
ping.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #7 from Neal Gompa  ---
Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get the
tarball.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #8 from [e-mail] ---
(In reply to Neal Gompa from comment #7)
> Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get
> the tarball.

I haven't found any mention in guidelines of VCS tag being forbidden. I believe
it's ok to use it as a tag describing upstream source for the package.

Using non-url Source0 should be also alright as described here:

https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

Comments how to obtain the Source0 were added.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #9 from [e-mail] ---
(In reply to clime from comment #8)
> (In reply to Neal Gompa from comment #7)
> > Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get
> > the tarball.
>
> I haven't found any mention in guidelines of VCS tag being forbidden. I
> believe it's ok to use it as a tag describing upstream source for the
> package.
>
> Using non-url Source0 should be also alright as described here:
>
> https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
>
> Comments how to obtain the Source0 were added.

Also...as you can see...

https://releases.pagure.org/rpkg-util

upstream does not provide source tarball *shrugs*.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #10 from [e-mail] ---
Neal, can your objections be satisfied by specific pointers into Fedora
Packaging Guidelines? If not, I don't really see why not continue. So, please,
express your take on this because I would like to move it forward.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #11 from Neal Gompa  ---
Well, there's nothing else left, I suppose...

Please work with upstream to resolve missing tarballs and switch to that.

Otherwise... APPROVED.

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rpkg-util

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2018-09-08 10:47:42