Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-Role-XMLRPC-Client - Provide the needed bits to be a XML-RPC client
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Summary: Review Request: perl-MooseX-Role-XMLRPC-Client - Provide the needed bits to be a XML-RPC client Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/MooseX-Role-XMLRPC-Client OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-XMLRPC-Client.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-XMLRPC-Client-0.03-1....
Description: This is a Moose role that provides the methods and attributes needed to enable a class to serve as an XML-RPC client. It is parameterized through MooseX::Role::Parameterized, so you can customize how it embeds in your class. You can even embed it multiple times with different paramaterization, if it strikes your fancy :-)
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1323070
*rt-0.08
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |484485
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-04-28 00:19:29 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1323070 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a36fcf49cb66435a59978e52050aead4 MooseX-Role-XMLRPC-Client-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.22 cusr 0.10 csys = 1.36 CPU) + Package perl-MooseX-Role-XMLRPC-Client-0.03-1.fc12.noarch => Provides: perl(MooseX::Role::XMLRPC::Client) = 0.03 Requires: perl(HTTP::Cookies) perl(MooseX::Role::Parameterized) perl(MooseX::Types::Moose) perl(MooseX::Types::Path::Class) perl(MooseX::Types::URI) perl(RPC::XML::Client) perl(namespace::clean)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2009-04-28 00:41:29 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-Role-XMLRPC-Client Short Description: Provide the needed bits to be a XML-RPC client Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-04-28 23:19:53 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497869
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2009-05-01 23:55:21 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org