https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Bug ID: 1015749 Summary: Review Request: php-twig-CTwig - Extension to improve performance of Twig Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: https://raw.github.com/remicollet/remirepo/5bb55ad37c631eb60928eb1f4cef0d67b... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-twig-CTwig-1.14.0-1.remi.src.rpm Description: Twig is a PHP template engine.
This package provides the Twig C extension (CTwig) to improve performance of the Twig template language, used by Twig PHP extension (php-twig-Twig).
Fedora Account System Username: remi
Notice: - this is an optional dep of php-twig-Twig - yes I prefer to keep EL-5 compatibility stuff - yes I prefer to keep SCL stuff (as allowed by Guildeines)
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #1 from Remi Collet fedora@famillecollet.com --- As this is (AFAIK) the first "pecl" extension from a non standard channel, which is not covered by the current PHP Guidelines: https://fedorahosted.org/fpc/ticket/354
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Update to 1.14.1, despite there is no change in source, only version bump, as upstream use the same repo for PHP anc C extension...
Spec: https://raw.github.com/remicollet/remirepo/33cac3138d34bb61bea0f5a2f441ef0f9... Srpm: http://rpms.famillecollet.com/SRPMS/php-twig-CTwig-1.14.1-1.remi.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #3 from Remi Collet fedora@famillecollet.com --- https://fedoraproject.org/wiki/Packaging:PHP have been updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |php-twig-CTwig - Extension |php-twig-ctwig - Extension |to improve performance of |to improve performance of |Twig |Twig
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Package renamed (only lowercase)
Spec: https://raw.github.com/remicollet/remirepo/d1343904790729a2ad6092c68c041858a...
Srpm: http://rpms.famillecollet.com/SRPMS/php-twig-ctwig-1.14.1-2.remi.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Cleanup for review: - drop SCL support - drop EL-5 supprot
Spec: https://raw.github.com/remicollet/remirepo/60d9c2f6aff807c61d743d32c1a44f6ef... Srpm: http://rpms.famillecollet.com/SRPMS/php-twig-ctwig-1.14.1-3.remi.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #6 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 814685 --> https://bugzilla.redhat.com/attachment.cgi?id=814685&action=edit fedora-review
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1015749 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api, C/C++ Disabled plugins: Java, Python, SugarActivity, Perl, R, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Shawn Iwinski shawn.iwinski@gmail.com --- No blockers.
===== APPROVED =====
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #8 from Remi Collet fedora@famillecollet.com --- Big thanks for the review !
New Package SCM Request ======================= Package Name: php-twig-ctwig Short Description: Extension to improve performance of Twig Owners: remi Branches: f19 f20 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-twig-ctwig-1.14.1-3.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-twig-ctwig-1.14.1-3.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-twig-ctwig-1.14.1-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |php-twig-ctwig-1.14.1-3.fc1 | |9 Resolution|--- |ERRATA Last Closed| |2013-10-30 23:02:07
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-twig-ctwig-1.14.1-3.fc1 |php-twig-ctwig-1.14.1-3.el6 |9 |
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1015749
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-twig-ctwig-1.14.1-3.el6 |php-twig-ctwig-1.14.1-3.fc2 | |0
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-twig-ctwig-1.14.1-3.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org