Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
Summary: Review Request: raptor Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: green@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/green/FE/FC5/raptor.spec SRPM URL: http://people.redhat.com/green/FE/FC5/raptor-1.4.8-2.src.rpm Description: Raptor is the RDF Parser Toolkit for Redland that provides a set of standalone RDF parsers, generating triples from RDF/XML or N-Triples.
Ardour is dependent on this package. The spec file is based on a very old planet ccrma spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |189315 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |189313 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From bugs.michael@gmx.net 2006-04-19 07:36 EST ------- Created an attachment (id=127980) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=127980&action=vie...) some spec fixes
Attached patch includes some fixes.
| checking GRDDL parser requirements... no - libxml2 and libxslt | are both not available
It's missing "BuildRequires: libxslt-devel".
* BR curl libxml2 are redundant, because of BR curl-devel libxml2-devel
* ASL2? While the old Apache Software License 1.1 maybe was called ASL by some people, better give the new "Apache Licence, Version 2.0" its full name, so "Licence: LGPL or Apache License Version 2.0" ( http://www.opensource.org/licenses/apache2.0.php )
* No reason not to use the %configure macro.
* The following two are a major problem IMO:
$ raptor-config --libs -L/usr/lib -lraptor -L/usr/kerberos/lib -lcurl -ldl -lgssapi_krb5 -lkrb5 -lk5crypto -lkrb5support -lcom_err -lresolv -lidn -lssl -lcrypto -lz -L/usr/lib -lxml2 -lz -lm -L/usr/lib -lxslt -lxml2 -lz -lm
$ pkg-config --libs raptor -L/usr/kerberos/lib -lraptor -lcurl -ldl -lgssapi_krb5 -lkrb5 -lk5crypto -lkrb5support -lcom_err -lresolv -lidn -lssl -lcrypto -lxslt -lxml2 -lz -lm
The results of both commands imply that you need much more than just "Requires: libxml2-devel" inside the raptor-devel package. Else linking against libraptor would fail, and developers/packagers would need to add the missing -devel package dependencies manually. Painful.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From green@redhat.com 2006-04-19 13:37 EST ------- (In reply to comment #1)
Created an attachment (id=127980)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=127980&action=vie...) [edit]
some spec fixes
Thanks Micheal. I'll try to post new bits tomorrow with your changes and more.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From green@redhat.com 2006-04-23 07:34 EST ------- Here are the updated bits, including Michael's spec file patch and additional changes to address his other concerns...
Spec URL: http://people.redhat.com/green/FE/FC5/raptor.spec SRPM URL: http://people.redhat.com/green/FE/FC5/raptor-1.4.8-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From bugs.michael@gmx.net 2006-04-23 16:50 EST ------- Created an attachment (id=128132) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128132&action=vie...) patch against raptor-1.4.8
I believe this patch to be the clean fix when linking dynamically.
Without it, the pkgconfig file creates RPM dependency hell.
With this patch applied, liblrdf really needs only "BuildRequires: pkgconfig raptor-devel ladspa-devel" and not openssl-devel curl2-devel glib2-devel zlib-devel e2fsprogs-devel krb5-devel (and raptor-devel doesn't need them anymore either).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From green@redhat.com 2006-04-24 07:08 EST ------- (In reply to comment #4)
Created an attachment (id=128132)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128132&action=vie...) [edit]
patch against raptor-1.4.8
I believe this patch to be the clean fix when linking dynamically.
Thanks. Updated bits here:
Spec URL: http://people.redhat.com/green/FE/FC5/raptor.spec SRPM URL: http://people.redhat.com/green/FE/FC5/raptor-1.4.8-4.src.rpm
I've updated liblrdf based on this as well.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |bugs.michael@gmx.net CC|bugs.michael@gmx.net | OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
------- Additional Comments From bugs.michael@gmx.net 2006-04-26 18:26 EST ------- Created an attachment (id=128276) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128276&action=vie...) a patch for raptor-config
I've started taking a first look at the other pending packages (jack, ardour,...), but here more rpm dependency hell is left:
/usr/bin/raptor-config also includes lots of linker commands in its --libs option, which create unnecessary dependencies on many -devel packages. It would benefit from a patch just as done with the pkg-config file (see attachment).
Then, package raptor-devel does not depend on all these -devel packages anymore when linking dynamically, and you can do the following to get rid of all the packages you don't depend on directly:
--- raptor.spec.orig 2006-04-24 13:12:03.000000000 +0200 +++ raptor.spec 2006-04-27 00:31:30.000000000 +0200 @@ -19,8 +19,6 @@ Summary: Libraries, includes etc to develop with Raptor RDF parser library Group: Development/Libraries Requires: %{name} = %{version}-%{release} -Requires: libxml2-devel, curl-devel, krb5-devel, libidn-devel, openssl-devel -Requires: zlib-devel, libxslt-devel, e2fsprogs-devel
%description devel Libraries, includes etc to develop with Raptor RDF parser library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From bugs.michael@gmx.net 2006-04-26 18:29 EST ------- And after these changes (which you can apply in CVS) I have no further comments, as the package looks clean then and liblrdf built fine with it, too.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From green@redhat.com 2006-04-27 10:44 EST ------- (In reply to comment #7)
APPROVED
Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/show_bug.cgi?id=189309
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
lkundrak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@redhat.com
------- Additional Comments From lkundrak@redhat.com 2008-04-11 17:14 EST ------- I'd be very thankful if you could request and maintain a EPEL-5 branch for this package. In case you don't want or can't do that, let me know and I'll do that.
Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/show_bug.cgi?id=189309
lkundrak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From lkundrak@redhat.com 2008-04-14 13:10 EST ------- Maintainer is OK with the change as per previous conversation with him.
Package Change Request ====================== Package Name: raptor New Branches: EL-5 Owners for new branch: green,lkundrak cvsextras commits for new branch: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: raptor
https://bugzilla.redhat.com/show_bug.cgi?id=189309
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-04-14 15:34 EST ------- cvs done.
package-review@lists.fedoraproject.org