[Bug 1647354] New: Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

Bug ID: 1647354
           Summary: Review Request: wfdb - Software working with
                    recordings of physiologic signals
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://10.44.130.165/pub/wfdb/wfdb.spec
SRPM URL: http://10.44.130.165/pub/wfdb/wfdb-10.6.0-1.fc27.src.rpm
Description: Software for viewing, analyzing, and creating recordings of
physiologic signals
Fedora Account System Username: pmoravco

[Bug 1647354] Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert-André Mauchin  ---
The server doesn't seem to answer, could you put the files on your Fedorapeople
space?

[Bug 1647354] Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

--- Comment #2 from Pavlina Moravcova Varekova  ---
Thank you.
Spec URL changed to : https://people.redhat.com/pmoravec/wfdb/wfdb.spec
SRPM URL changed to:
https://people.redhat.com/pmoravec/wfdb/wfdb-10.6.0-1.fc27.src.rpm

[Bug 1647354] Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

--- Comment #3 from Robert-André Mauchin  ---
 - Vendor: is forbidden in Fedora

- Not needed anymore:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

Use %ldconfig_scriptlets for F27 or EPEL. See
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

- Not needed, it is the default:

%defattr(-,root,root,-)

- You forgot %{?_isa} in the Requires for the devel subpackage:

Requires: %{name}%{?_isa} = %{version}-%{release}

- This part should be in %build:

cd doc/wpg-src
%__make 
cd ../wag-src
# package pdftk  was removed from distribution (in F21) replace it by qpdf
command
sed -i -e 's/pdftk/qpdf --empty wag.pdf --pages wag1.pdf wag2.pdf wag3.pdf
wag4.pdf --  # /g' Makefile
%__make
cd ../wug-src
%__make

- Use make, not %__make. These kind of macros are not useful.

- You could use pushd/popd instead of cd ../ in that section

- GCC should be a BR rot a RR

BuildRequires:       gcc

- Remove the glob here to own the include dir:

%files devel
%{_includedir}/%{name}/
%{_libdir}/libwfdb.so

- Same here and own %{_datadir}/%{name}

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/database/
%{_datadir}/%{name}/ps/

- Your build must respect Fedora's CCFLAGS and LDFLAGS

- Build fails:

DEBUG util.py:490:  BUILDSTDERR: No matching package to install: 'rman'
DEBUG util.py:490:  BUILDSTDERR: Not all dependencies satisfied
DEBUG util.py:490:  BUILDSTDERR: Error: Some packages could not be found.

I have no idea what rman is in this context.

[Bug 1647354] Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

--- Comment #4 from Robert-André Mauchin  ---
Also, it seems some tests only work with network access, which won't work in
Mock/Koji.

[Bug 1647354] Review Request: wfdb - Software working with recordings of physiologic signals

https://bugzilla.redhat.com/show_bug.cgi?id=1647354

--- Comment #5 from Robert-André Mauchin  ---
Regarding rman:

https://src.fedoraproject.org/rpms/rman/blob/master/f/dead.package

Package was removed due to licensing issues (it was only available under
Artistic 1.0).

Every effort was made to contact upstream for relicensing, but no response was
ever received.

See: https://fedoraproject.org/wiki/Features/Artistic1Removal

No luck there.