[Bug 558743] New: Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Merge Review: perl-Unicode-String - handle Unicode issues

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Summary: Merge Review: perl-Unicode-String - handle Unicode
                    issues
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Fedora Merge Review: perl-Unicode-String -- Perl modules to handle various
Unicode issues.

http://cvs.fedoraproject.org/viewvc/devel/perl-Unicode-String

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Stepan Kasal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Stepan Kasal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

--- Comment #1 from Marcela Mašláňová  2010-01-27 05:49:06 EST ---
? rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
OK The sources used to build the package must match the upstream source.
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

perl-Unicode-String.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Unicode/String/String.bs
perl-Unicode-String.x86_64: W: file-not-utf8
/usr/share/doc/perl-Unicode-String-2.09/README

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Petr Pisar  2010-07-22 08:29:57 EDT ---
The in-cvs version produces followin rpmlint output now:

(none): E: no installed packages by name x86_64/perl-Unicode-String-8
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Paul Howarth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Paul Howarth  2010-07-22 08:36:48 EDT ---
(In reply to comment #2)
> The in-cvs version produces followin rpmlint output now:
>
> (none): E: no installed packages by name x86_64/perl-Unicode-String-8
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

You missed pressing the shift key and got an 8 instead of a *.

$ rpmlint ~/perl-Unicode-String-*
perl-Unicode-String.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/auto/Unicode/String/String.so String.so()(64bit)
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Using perl_default_filter would fix that.

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
               Flag|                            |fedora-review+

--- Comment #4 from Marcela Mašláňová  2010-07-22 08:46:29 EDT ---
SRPM and RPM shows:
rpmlint ~/Downloads/perl-Unicode-String-2.09-15.fc14.*
perl-Unicode-String.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/auto/Unicode/String/String.so String.so()(64bit)
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

That's quite usual for perl modules.

ACCEPT

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

--- Comment #5 from Petr Pisar  2010-07-22 09:18:54 EDT ---
This spec file patch is needed to filter private library out from provides and
to proceed local rpmbuild (rm ask for read-only file removal):

Index: perl-Unicode-String.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Unicode-String/devel/perl-Unicode-String.spec,v
retrieving revision 1.22
diff -u -r1.22 perl-Unicode-String.spec
--- perl-Unicode-String.spec    7 May 2010 07:18:08 -0000       1.22
+++ perl-Unicode-String.spec    22 Jul 2010 13:09:11 -0000
@@ -18,6 +18,8 @@
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
 # not detected by auto provide scripts:
 Requires:       perl(MIME::Base64)
+%filter_from_provides /String.so/d
+%filter_setup

%description
 %{summary}.
@@ -42,7 +44,7 @@
   DESTDIR=$RPM_BUILD_ROOT \
   INSTALLARCHLIB=$RPM_BUILD_ROOT%{perl_archlib}
 find $RPM_BUILD_ROOT -type f ( -name perllocal.pod -o -name .packlist \
-  -o ( -name '*.bs' -empty ) ) -exec rm {} ';'
+  -o ( -name '*.bs' -empty ) ) -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -depth -type d -empty -exec rmdir {} ';'
 chmod -R u+w $RPM_BUILD_ROOT/*

[Bug 558743] Merge Review: perl-Unicode-String - handle Unicode issues

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=558743

--- Comment #6 from Marcela Mašláňová  2010-07-23 06:59:33 EDT ---
Applied in perl-Unicode-String-2.09-16.fc14