Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
Summary: Review Request: xarchon - Arcade board game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-1.src.rpm Description: XArchon is a chess with a twist board game. It is modelled after the golden oldie Archon game created by Freefall Associates.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |wart@kobold.org OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From wart@kobold.org 2006-05-12 14:27 EST ------- MUST ==== * rpmlint output clean * Sources match upstream 491dea5b4e61ed13cd988d1c184a8ef0 xarchon-0.50.tar.gz * GPL license ok, license file included * Package and spec file named appropriately * .desktop file installed correctly * RPM_BUILD_ROOT cleaned appropriately * spec file is legible and in Am. English * No locales * No shared libs * No -devel subpackage needed * No -docs subpackage needed * Not relocatable * Owns all directories that it creates * Builds fine in mock on FC-4-i386
MUSTFIX ======= * Macro use isn't consistent. 'xarchon' is used in some places, while %{name} is used in others.
SHOULD ====== * Don't bother including the NEWS file, it just tells the user to read the ChangeLog file.
* Missing BR: libXpm-devel on FC-5.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-05-13 04:34 EST ------- (In reply to comment #1)
MUSTFIX
- Macro use isn't consistent. 'xarchon' is used in some places, while %{name} is used in others.
Fixed
SHOULD
- Don't bother including the NEWS file, it just tells the user to read
the ChangeLog file.
Done
- Missing BR: libXpm-devel on FC-5.
Added (for -devel too)
New version: Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
------- Additional Comments From ville.skytta@iki.fi 2006-05-13 05:50 EST ------- Nit: hardcoded .gz man page suffix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-05-13 06:57 EST ------- I always use a harcoded .gz for the manpage suffix. I try to use as little wildcards as possible in my %files sections. If a newer upstream versions installs new files I want to know. I've seen people do %{_bindir}/* %{_mandir}/man6/* etc, which IMHO is not a good idea.
I know that the compressing sometimes is done by rpmbuild and the manpage's are installed uncompressed by make install, but AFAIK now a days they always end up being compressed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From wart@kobold.org 2006-05-15 13:53 EST ------- All MUST and SHOULD items addressed. Runs without crashing (though I didn't test it extensively).
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-05-15 15:14 EST ------- Thanks! I would like todo something back but Chris has taken all your reviews sofar :) Imported and Build.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191434
------- Additional Comments From wart@kobold.org 2006-05-15 15:17 EST ------- #187392? :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xarchon - Arcade board game
https://bugzilla.redhat.com/show_bug.cgi?id=191434
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla