[Bug 2163430] New: Review Request: python-pyramid-openapi3 - Validate Pyramid views against an OpenAPI3 document
6:34 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Bug ID: 2163430
Summary: Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mattia.verga(a)proton.me
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://mattia.fedorapeople.org/python-pyramid-openapi3/python-pyramid-op...
SRPM URL:
https://mattia.fedorapeople.org/python-pyramid-openapi3/python-pyramid-op...
Description: Validates your API document (for example, openapi.yaml or
openapi.json) against the OpenAPI 3.0 specification using the
openapi-spec-validator.
Generates and serves the Swagger try-it-out documentation for your API.
Validates incoming requests and outgoing responses against your API document
using openapi-core.
Fedora Account System Username: mattia
fedora-review template:
https://copr.fedorainfracloud.org/coprs/mattia/python-pyramid-openapi3/bu...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
6:41 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5285040
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
8:36 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Benson Muite <benson_muite(a)emailplus.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review?
Assignee|nobody(a)fedoraproject.org |benson_muite(a)emailplus.org
Status|NEW |ASSIGNED
CC| |benson_muite(a)emailplus.org
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
11:49 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
--- Comment #2 from Benson Muite <benson_muite(a)emailplus.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "*No copyright* MIT License", "Unknown
or
generated". 6 files have unknown license. Detailed output of
licensecheck in /home/FedoraPackaging/reviews/python-pyramid-
openAPI3/2163430-python-pyramid-openapi3/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-pyramid-openapi3-0.15.0-1.fc38.noarch.rpm
python-pyramid-openapi3-0.15.0-1.fc38.src.rpm
================================= rpmlint session starts
=================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpknmpkz8c')]
checks: 31, packages: 2
== 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has
taken 6.5 s ==
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.9 s
Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pyramid_openapi3/pyramid...
:
CHECKSUM(SHA256) this package :
cbf0185ddc6f15e2840129d069817fe03149506a19a818d07cf8064102cac922
CHECKSUM(SHA256) upstream package :
cbf0185ddc6f15e2840129d069817fe03149506a19a818d07cf8064102cac922
Requires
--------
python3-pyramid-openapi3 (rpmlib, GLIBC filtered):
python(abi)
python3.11dist(openapi-core)
python3.11dist(pyramid)
Provides
--------
python3-pyramid-openapi3:
python-pyramid-openapi3
python3-pyramid-openapi3
python3.11-pyramid-openapi3
python3.11dist(pyramid-openapi3)
python3dist(pyramid-openapi3)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2163430
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Ocaml, fonts, Ruby, Perl, PHP, Haskell, C/C++, R, Java,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments:
a) Is it possible to run tests:
https://github.com/Pylons/pyramid_openapi3/tree/main/pyramid_openapi3/tests
Only import is checked.
b) Can you add CHANGELOG.md to the packaged documentation?
c) The file index.html seems to require internet access, in particular for
javascript, css and fonts:
https://github.com/Pylons/pyramid_openapi3/blob/main/pyramid_openapi3/sta...
Can these be obtained in Fedora, if not are there replacements or can they be
packaged?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
9:27 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
--- Comment #3 from Mattia Verga <mattia.verga(a)proton.me> ---
(In reply to Benson Muite from comment #2)
Comments:
a) Is it possible to run tests:
https://github.com/Pylons/pyramid_openapi3/tree/main/pyramid_openapi3/tests
Only import is checked.
Done
b) Can you add CHANGELOG.md to the packaged documentation?
Done
c) The file index.html seems to require internet access, in
particular for
javascript, css and fonts:
https://github.com/Pylons/pyramid_openapi3/blob/main/pyramid_openapi3/sta...
index.html
Can these be obtained in Fedora, if not are there replacements or can they
be packaged?
Not possible.
Spec URL:
https://mattia.fedorapeople.org/python-pyramid-openapi3/python-pyramid-op...
SRPM URL:
https://mattia.fedorapeople.org/python-pyramid-openapi3/python-pyramid-op...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
2:31 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
--- Comment #4 from Benson Muite <benson_muite(a)emailplus.org> ---
[fedora-review-service-build]
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
2:35 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
--- Comment #5 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Created attachment 1968971
--> https://bugzilla.redhat.com/attachment.cgi?id=1968971&action=edit
The .spec file difference from Copr build 5285040 to 6003040
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
2:35 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Fedora Review Service <fedora-review-bot(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://pypi.python.org/pyp
| |i/%{srcname}
--- Comment #6 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6003040
(failed)
Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network
unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
are listed in the "Depends On" field
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
noon
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Mattia Verga <mattia.verga(a)proton.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |NotReady
--- Comment #7 from Mattia Verga <mattia.verga(a)proton.me> ---
Needs https://github.com/Pylons/pyramid_openapi3/pull/206 for compatibility
with openapi-core 0.17
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
2:52 a.m.
New subject: [Bug 2163430] Review Request: python-pyramid-openapi3 - Validate
Pyramid views against an OpenAPI3 document
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Mattia Verga <mattia.verga(a)proton.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|ASSIGNED |CLOSED
Last Closed| |2024-02-18 08:52:39
--- Comment #8 from Mattia Verga <mattia.verga(a)proton.me> ---
I'm quitting this. Upstream is a lost cause, will never be able to keep up with
openapi-core.
Thanks for taking time to review it.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163430
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
128
days inactive
519
days old
package-review@lists.fedoraproject.org
9 comments
1 participants
participants (1)
-
bugzilla＠redhat.com