https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Bug ID: 1430127 Summary: Review Request: golang-github-denisenkom-go-mssqldb - Microsoft SQL server driver for Go (golang) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: esm@logic.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fedorapeople.org/cgit/logic/public_git/golang-github-denisenkom-go-m... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/logic/vault/fedora-rawhide-x... Description: Microsoft SQL server driver for Go (golang) Fedora Account System Username: logic
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Please bump to the latest git: c7ee4153c0fc40206bde939f96eefa1f501cbcaa
- Please add a commit date for versioning, as required by https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots :
%global commit c7ee4153c0fc40206bde939f96eefa1f501cbcaa %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20170919
Name: golang-%{provider}-%{project}-%{repo} Version: 0 Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
And:
* Wed Oct 03 2017 Ed Marshall esm@logic.net - 0-0.1.20170919gitc7ee415
Package otherwise accepted.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /golang-github-denisenkom-go-mssqldb/review-golang-github-denisenkom- go-mssqldb/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-denisenkom-go-mssqldb-devel , golang-github-denisenkom-go- mssqldb-unit-test-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-denisenkom-go-mssqldb-devel-0-0.1.20170919gitc7ee415.fc28.noarch.rpm
golang-github-denisenkom-go-mssqldb-unit-test-devel-0-0.1.20170919gitc7ee415.fc28.x86_64.rpm
golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc28.src.rpm 3 packages and 0 specfiles checked; 1 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-denisenkom-go-mssqldb
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a7120558a2
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e2bd3db58d
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a7120558a2
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e2bd3db58d
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-10-15 19:50:45
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-denisenkom-go-mssqldb-0-0.1.20170919gitc7ee415.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |MODIFIED Depends On| |1326890 Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #9 from Ed Marshall esm@logic.net --- EPEL7 build depends on #1326890 and https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-94c4b52a1e getting pushed to stable.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1326890 [Bug 1326890] FTBFS with gcc-go on s390x
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1231618
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1231618 [Bug 1231618] Tracker for golang-googlecode-go-crypto
https://bugzilla.redhat.com/show_bug.cgi?id=1430127
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2017-10-15 19:50:45 |2017-11-20 23:09:51
https://bugzilla.redhat.com/show_bug.cgi?id=1430127 Bug 1430127 depends on bug 1231618, which changed state.
Bug 1231618 Summary: Tracker for golang-googlecode-go-crypto https://bugzilla.redhat.com/show_bug.cgi?id=1231618
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1430127 Bug 1430127 depends on bug 1326890, which changed state.
Bug 1326890 Summary: FTBFS with gcc-go on s390x https://bugzilla.redhat.com/show_bug.cgi?id=1326890
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org