[Bug 226002] New: Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

Summary: Merge Review: libevent
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libevent

http://cvs.fedora.redhat.com/viewcvs/devel/libevent/
Initial Owner: [e-mail]

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-09 10:31 EST -------
Starting review...

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-09 11:28 EST -------
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
6cc776458ecaf9247550863702a44d7c  libevent-1.1a.tar.gz
6cc776458ecaf9247550863702a44d7c  libevent-1.1a.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
See below - Should have dist tag
See below - Should package latest version
1 bug - check for outstanding bugs on package.

Issues:

1. rpmlint says:

W: libevent incoherent-version-in-changelog control 1.1a-3.2.1

I'd recommend fixing the broken changelog entry from Jesse Keating's
bump-n-build script.  (Seconded by Jesse.)

2. Dist tag

Appending "%{?dist}" to the Release field is recommended.  Not a
blocker, but it'd be nice.

3. Not latest version

Upstream web site indicates 1.2a is the latest version (released
2006-12-02).  Please evaluate as to whether upgrading might be for the
best.

4. Bugs open:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204990

If you can address the above, I don't see any reason why libevent can't
be approved for merging.

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

------- Additional Comments From [e-mail]  2007-02-09 18:54 EST -------
I plan on updated to the latest upstream version...

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

------- Additional Comments From [e-mail]  2007-03-09 10:38 EST -------
> I'd recommend fixing the broken changelog entry from Jesse Keating's
> bump-n-build script

Done.
> Dist tag

Done
> Not latest version

Done
> Bugs open

Fixed.

See libevent-1.3b-1.fc7

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

------- Additional Comments From [e-mail]  2007-03-09 11:03 EST -------
Err, where?  I'm still seeing 1.2a-1 in CVS.  (Granted, I've been gone for two
weeks, and am still working on catching up on mail -- are we working out of
someplace new?)

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

------- Additional Comments From [e-mail]  2007-03-09 13:11 EST -------
hmm.. I seem to be getting the correct code...
$ cvs co rpms/libevent/devel
cvs checkout: Updating rpms/libevent/devel
U rpms/libevent/devel/.cvsignore
U rpms/libevent/devel/Makefile
U rpms/libevent/devel/libevent-1.3b-longer-polltime.patch
U rpms/libevent/devel/libevent.spec
U rpms/libevent/devel/sources

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED
               Flag|fedora-review-              |fedora-review+

------- Additional Comments From [e-mail]  2007-03-09 13:23 EST -------
For the benefit of any outside parties reading this, the changes hadn't been
synched to the external CVS server.  Now that they have...

Looks like you addressed all of my qualms with the package, so I think libevent
is APPROVED for merging.  Thanks!

(Okay, technically we probably still need to verify/close BZ#204990, but you
addressed it, which is what I asked.)

[Bug 226002] Merge Review: libevent

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent

https://bugzilla.redhat.com/show_bug.cgi?id=226002

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-06-02 15:57 EST -------
https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libr...