[Bug 2184004] New: Review Request: rust-associative-cache - Generic N-way associative cache
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
Bug ID: 2184004 Summary: Review Request: rust-associative-cache - Generic N-way associative cache Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: maxwell@gtmx.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gotmax23.fedorapeople.org/reviews/rust-associative-cache/rust-associ... SRPM URL: https://gotmax23.fedorapeople.org/reviews/rust-associative-cache/rust-associ...
Description: A generic N-way associative cache with fixed-size capacity and random or least recently used (LRU) replacement.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99477591
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/as | |sociative-cache
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5738673 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests are disabled with link to upstream bug report) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora ? license files are included with %license in %files (upstream unresponsive, standard license files for Apache-2.0 and MIT included manually) - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Non-blocking issues, please address them before importing the package:
1. Exclude some CI files from the package, i.e. by adding this to Cargo.toml's [package] table: exclude = ["/ci/", "/azure-pipelines.yml"]
2. Include a link the upstream bug report about the 32-bit test failures in the spec file: https://github.com/fitzgen/associative-cache/issues/15
3. If you can, provide more details than "Doctests are broken". It looks like many of them are not compilable / runnable, but not annotated with "ignore", i.e. like this:
```ignore this is not valid rust code ```
4. You can de-duplicate the license files. Right now they are installed twice (once in %crate_instdir, and once in %_licensedir). You can pass an absolute path to the %license macro instead so the files are not copied to %_licensedir, i.e.
%license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #3 from Maxwell G maxwell@gtmx.me ---
test suite is run and all unit tests pass (tests are disabled with link to upstream bug report)
Well, the tests are only disabled on 32-bit arches. They're enabled everywhere else.
Non-blocking issues, please address them before importing the package:
How's https://git.sr.ht/~gotmax23/fedora-python-orjson/commit/20d759663a3d42f60181... ?
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Perfect, thanks. You could have used "rust2rpm -p" to generate the "exclude" patch, but this is fine :)
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #5 from Maxwell G maxwell@gtmx.me ---
You could have used "rust2rpm -p" to generate the "exclude" patch
Yeah, but then I'd have to reapply my local modifications, wouldn't I?
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-associative-cache
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d08e6ddfb4 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d08e6ddfb4
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-04-03 19:40:21
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d08e6ddfb4 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-02616d2cc2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2184004
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com