https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Bug ID: 1369067 Summary: Review Request: libgepub - Library for epub documents Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: klember@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://kalev.fedorapeople.org/libgepub.spec SRPM URL: https://kalev.fedorapeople.org/libgepub-0.3-0.1.git395779e.fc24.src.rpm Description: libgepub is a GObject based library for handling and rendering epub documents.
Fedora Account System Username: kalev
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15336909
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |debarshir@redhat.com Assignee|nobody@fedoraproject.org |debarshir@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
--- Comment #1 from Debarshi Ray debarshir@redhat.com --- MUST items ----------
rpmlint output:
$ rpmlint /home/rishi/devel/rpmbuild/SRPMS/libgepub-0.3-0.1.git395779e.fc23.src.rpm libgepub.src: W: spelling-error Summary(en_US) epub -> pub, e pub libgepub.src: W: spelling-error %description -l en_US epub -> pub, e pub libgepub.src: W: invalid-url Source0: libgepub-0.3-395779e.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint /home/rishi/devel/rpmbuild/RPMS/x86_64/libgepub-0.3-0.1.git395779e.fc23.x86_64.rpm libgepub.x86_64: W: spelling-error Summary(en_US) epub -> pub, e pub libgepub.x86_64: W: spelling-error %description -l en_US epub -> pub, e pub libgepub.x86_64: W: no-documentation libgepub.x86_64: E: incorrect-fsf-address /usr/share/licenses/libgepub/COPYING 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
$ rpmlint /home/rishi/devel/rpmbuild/RPMS/x86_64/libgepub-devel-0.3-0.1.git395779e.fc23.x86_64.rpm libgepub-devel.x86_64: W: only-non-binary-in-usr-lib libgepub-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint /home/rishi/devel/rpmbuild/RPMS/x86_64/libgepub-debuginfo-0.3-0.1.git395779e.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
All those are harmless. It prefers 'e-pub' instead of 'epub', but that's really trivial. We should probably tell upstream to update their COPYING file.
YES - package follows Naming Guidelines YES - spec file name matches base package %{name}
NO - package follows Packaging Guidelines
It is not obvious whether libgepub has had a release or not. I don't see anything in https://download.gnome.org/sources/, but https://github.com/GNOME/libgepub/releases suggests that there was a 0.3 release from the 0.3 git tag. Therefore, I think it will be better to use a post-release versioning scheme, instead of a pre-release scheme. The current scheme (0.3-0.1.git<shortcommit>, 0.3-0.2.git<shortcommit>, etc..) expects that there will be a 0.3 release at some point in the future. Instead, I think we should do something like: 0.3-2.git<shortcommit>, 0.3-3.git<shortcommit>, etc.. I skipped 0.3-1 because we have moved ahead of the 0.3 tag.
YES - package is under a Fedora approved license YES - license field matches actual license YES - source package includes license text, which is included in %license YES - spec file written in American English YES - spec file is legible
YES - sources match upstream source Since this is a Git snapshot, the checksum of the tarball depends on the exact versions of Autotools. Quite surprisingly, libgepub-0.3/aclocal.m4 was the only difference between Kalev's tarball and mine.
YES - package compiles on all primary architectures YES - there is no need for ExcludeArch YES - all build dependencies in BuildRequires YES - doesn't have any locale files YES - calls ldconfig in %post and %postun YES - doesn't bundle system libraries YES - package is not relocatable YES - package owns all directories that it creates YES - files are listed only once in %files YES - file permissions are set properly YES - consistent use of macros YES - package contains code or permissible content YES - no need for doc subpackage YES - no chance of items marked as %doc affecting runtime YES - no static libraries YES - development files in devel subpackage YES - devel subpackage requires base package YES - package removes all libtool archives YES - package doesn't need a .desktop file
YES - doesn't own files or directories owned by other packages
It owns %{_libdir}/girepository-1.0 and %{_datadir}/gir-1.0, which are owned by gobject-introspection and gobject-introspection-devel respectively. However, these are not in libgepub's "natural dependency chain" - a C program can use libgepub without gobject-introspection. Therefore, I think this is fine.
YES - all filenames are valid UTF-8
SHOULD items ------------
YES - package includes license text from upstream NO - description and summary doesn't have translations YES - package builds in Koji YES - builds on all primary architectures YES - package functions as described YES - package doesn't use scriptlets YES - no subpackages other than devel YES - pkgconfig files are part of devel subpackage YES - no dependencies outside of /etc/, /bin/, /sbin, etc. YES - no need for man pages
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |klember@redhat.com Flags| |needinfo?(klember@redhat.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(klember@redhat.co | |m) |
--- Comment #2 from Kalev Lember klember@redhat.com --- Thanks. upstream has now a 0.4 release out together with a tarball.
Spec URL: https://kalev.fedorapeople.org/libgepub.spec SRPM URL: https://kalev.fedorapeople.org/libgepub-0.4-1.fc24.src.rpm
* Thu Sep 01 2016 Kalev Lember klember@redhat.com - 0.4-1 - Update to 0.4
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Debarshi Ray debarshir@redhat.com --- (In reply to Kalev Lember from comment #2)
Thanks. upstream has now a 0.4 release out together with a tarball.
Spec URL: https://kalev.fedorapeople.org/libgepub.spec SRPM URL: https://kalev.fedorapeople.org/libgepub-0.4-1.fc24.src.rpm
Thanks, Kalev.
ACCEPTED
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libgepub
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
--- Comment #5 from Igor Gnatenko ignatenko@redhat.com --- * Missing BuildRequires: gcc * Add --disable-silent-rules to %configure
https://bugzilla.redhat.com/show_bug.cgi?id=1369067
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Fixed In Version| |libgepub-0.4-1.fc25 Resolution|--- |RAWHIDE Last Closed| |2016-09-02 03:43:43
--- Comment #6 from Kalev Lember klember@redhat.com --- Package imported and built.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla