[Bug 2074651] New: Review Request: python-sphinx-autobuild - Autobuild a Sphinx directory when a change is detected
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Bug ID: 2074651 Summary: Review Request: python-sphinx-autobuild - Autobuild a Sphinx directory when a change is detected Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/python-sphinx-autobuild/python-sphinx-autobu... SRPM URL: https://jjames.fedorapeople.org/python-sphinx-autobuild/python-sphinx-autobu... Fedora Account System Username: jjames Description: Rebuild Sphinx documentation on changes, with live-reload in the browser.
This package was previously in Fedora, so this is an unretirement review.
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2074652
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074652 [Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |dominik@greysector.net Doc Type|--- |If docs needed, set a value
--- Comment #1 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Taking review.
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Licensing is fine (MIT). Source matches upstream: $ sha512sum sphinx-autobuild-2021.3.14.tar.gz sphinx-autobuild-2021.3.14.tar.gz.orig 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz.orig
Builds fine in mock. Internal testsuite passes. Spec is clean and legible. rpmlint clean. Requires and provides are sane:
$ rpm -qpR python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm /usr/bin/python3 python(abi) = 3.10 python3.10dist(colorama) python3.10dist(livereload) python3.10dist(sphinx)
$ rpm -qp --provides python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm python-sphinx-autobuild = 2021.3.14-1.fc37 python3-sphinx-autobuild = 2021.3.14-1.fc37 python3.10-sphinx-autobuild = 2021.3.14-1.fc37 python3.10dist(sphinx-autobuild) = 2021.3.14 python3dist(sphinx-autobuild) = 2021.3.14
jquery 3.5.1 and underscore 1.13.1 are bundled in the doc subpackage, you might want to declare that in Provides: bundled().
This is of course coming from sphinx and was discussed as recently as February: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/... .
You can fix this while importing as the package is good otherwise. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
--- Comment #3 from Jerry James loganjerry@gmail.com --- (In reply to Dominik 'Rathann' Mierzejewski from comment #2)
jquery 3.5.1 and underscore 1.13.1 are bundled in the doc subpackage, you might want to declare that in Provides: bundled().
I will fix that before importing. Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9161e75532` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-05-07 04:12:48
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com