[Bug 1921853] New: Review Request: rust-derive-new - We'd like to create this package to meet one of the dependencies for the `rust-mbrman` package which is required for building new rust-coreos-installer release

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Bug ID: 1921853
           Summary: Review Request: rust-derive-new - We'd like to create
                    this package to meet one of the dependencies for the
                    `rust-mbrman` package which is required for building
                    new rust-coreos-installer release
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://sohank2602.fedorapeople.org/rust-derive-new/rust-derive-new.spec
SRPM URL:
https://sohank2602.fedorapeople.org/rust-derive-new-0.5.8-1.fc33.src.rpm
Description: `#[derive(new)]` implements simple constructor functions for
structs and enums
Fedora Account System Username: sohank2602

[Bug 1921853] Review Request: rust-derive-new - Creating this package to meet one of the dependencies for the `rust-mbrman` package which is required for building new rust-coreos-installer release

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Sohan Kunkerkar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-derive-new - We'd like |rust-derive-new - Creating
                   |to create this package to   |this package to meet one of
                   |meet one of the             |the dependencies for the
                   |dependencies for the        |`rust-mbrman` package which
                   |`rust-mbrman` package which |is required for building
                   |is required for building    |new rust-coreos-installer
                   |new rust-coreos-installer   |release
                   |release                     |

[Bug 1921853] Review Request: rust-derive-new - Creating this package to meet one of the dependencies for the `rust-mbrman` package which is required for building new rust-coreos-installer release

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Fabio Valentini  ---
First comment:

The Summary tag (taken from upstream metadata) is really long, you should
probably change it to
"Derive simple constructor functions for structs and enums"
or similar.

And please also use this Summary as the Summary of the Review Request template
(in the bug title).

I'll make a full review this afternoon.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Sohan Kunkerkar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated
             Status|ASSIGNED                    |NEW
           Assignee|[e-mail]        |[e-mail]
            Summary|Review Request:             |Review Request:
                   |rust-derive-new - Creating  |rust-derive-new - Derive
                   |this package to meet one of |simple constructor
                   |the dependencies for the    |functions for structs and
                   |`rust-mbrman` package which |enums
                   |is required for building    |
                   |new rust-coreos-installer   |
                   |release                     |

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Robert-André Mauchin 🐧  ---
Please ask upstream to include the license file in their crate.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

--- Comment #3 from Sohan Kunkerkar  ---
(In reply to Robert-André Mauchin 🐧 from comment #2)
> Please ask upstream to include the license file in their crate.

It seems like the upstream project is not maintained for a while. The last
commit was added in 2018. I tried to reach the maintainer of the project, but
haven't received any reply yet.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Sohan Kunkerkar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Sohan Kunkerkar  ---
(In reply to Robert-André Mauchin 🐧 from comment #2)
> Please ask upstream to include the license file in their crate.

Alright, the license file is updated in the new crate.

Also, some changes in the original content:
Spec URL:
https://sohank2602.fedorapeople.org/rust-derive-new/rust-derive-new.spec
SRPM URL:
https://sohank2602.fedorapeople.org/rust-derive-new-0.5.9-1.fc33.src.rpm

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

--- Comment #5 from Fabio Valentini  ---
A LICENSE file is now in the upstream crate, but it's still not added in the
package.

Add "%license LICENSE" to the %files list for the -devel subpackage.

Also please remove the markdown markup (the two `) from the Summary tag.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

--- Comment #6 from Sohan Kunkerkar  ---
(In reply to Fabio Valentini from comment #5)
> A LICENSE file is now in the upstream crate, but it's still not added in the
> package.
>
> Add "%license LICENSE" to the %files list for the -devel subpackage.
>
> Also please remove the markdown markup (the two `) from the Summary tag.

Thanks for the review!

Fixed. Could you take another look?

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #7 from Fabio Valentini  ---
Uhm ... What did you do to Summary and description?
I said remove the two `s, not to remove everything between them :)
The text itself was fine, just the markup makes no sense in RPM tags ...

If you *want* to change the Summary text, do something like this to make it
make sense:
Summary:        Derive simple constructor functions for structs and enums

The %description can stay unmodified from the rust2rpm generated .spec.

Other than that: package generated with rust2rpm, simplifying the review:

- latest version from crates.io is packaged
- License matches upstream specification and shipped as %license
- follows Packaging and Rust Packaging Guidelines
- builds and installs successfully on rawhide

Please fix the Summary and %description tags before importing and building the
package.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

--- Comment #8 from Sohan Kunkerkar  ---
> Please fix the Summary and %description tags before importing and building the package.

My bad, it's fixed in the subsequent push.

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

--- Comment #9 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-derive-new

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Sohan Kunkerkar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2021-02-22 11:56:31

--- Comment #10 from Sohan Kunkerkar  ---
This package is successfully built for F-34
https://koji.fedoraproject.org/koji/buildinfo?buildID=1711325

Thanks Fabio Valentini for the help!

[Bug 1921853] Review Request: rust-derive-new - Derive simple constructor functions for structs and enums

https://bugzilla.redhat.com/show_bug.cgi?id=1921853

Mattia Verga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Mattia Verga  ---
*** Bug 1873737 has been marked as a duplicate of this bug. ***