[Bug 1285057] New: Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors - package-review

List overview All Threads
Download

newer

[Bug 1285057] New: Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

older

[Bug 1284400] New: Review Request:...

[Bug 1285056] New: Review Request:...

Red Hat Bugzilla

24 Nov 2015 24 Nov '15

12:52 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Bug ID: 1285057 Summary: Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zsvetlik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node... SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node... Description: A drop-in replacement for JSON.parse that uses `jju` to give helpful errors Fedora Account System Username: zvetlik

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

24 Nov 24 Nov

12:54 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Zuzana Svetlikova zsvetlik@redhat.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1285051 [Bug 1285051] Review Request: nodejs-cjson - Commented JavaScript Object Notation https://bugzilla.redhat.com/show_bug.cgi?id=1285056 [Bug 1285056] Review Request: nodejs-jju - A set of utilities to work with JSON / JSON5 documents

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Jan 1 Jan

12:23 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Tom Hughes tom@compton.nu changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1024214 [Bug 1024214] nodejs-read-package-json-2.0.2 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:43 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Tom Hughes tom@compton.nu changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:53 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck in /home/tom/1285057 -nodejs-json-parse-helpfulerror/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-json-parse-helpfulerror-1.0.3-1.fc24.noarch.rpm nodejs-json-parse-helpfulerror-1.0.3-1.fc24.src.rpm nodejs-json-parse-helpfulerror.noarch: W: only-non-binary-in-usr-lib nodejs-json-parse-helpfulerror.noarch: W: dangling-symlink /usr/lib/node_modules/json-parse-helpfulerror/node_modules/jju /usr/lib/node_modules/jju nodejs-json-parse-helpfulerror.src: W: spelling-error Summary(en_US) jju -> jut nodejs-json-parse-helpfulerror.src: W: spelling-error %description -l en_US jju -> jut nodejs-json-parse-helpfulerror.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 8) 2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:

Requires -------- nodejs-json-parse-helpfulerror (rpmlib, GLIBC filtered): nodejs(engine) npm(jju)

Provides -------- nodejs-json-parse-helpfulerror: nodejs-json-parse-helpfulerror npm(json-parse-helpfulerror)

Source checksums ---------------- https://registry.npmjs.org/json-parse-helpfulerror/-/json-parse-helpfulerror... : CHECKSUM(SHA256) this package : a17cf8789ecddb0e3ace7f0f031ca045f5027f56cf4a2e6b2ec8b732322bbad7 CHECKSUM(SHA256) upstream package : a17cf8789ecddb0e3ace7f0f031ca045f5027f56cf4a2e6b2ec8b732322bbad7

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1285057 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:54 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #2 from Tom Hughes tom@compton.nu --- The BR on nodejs-devel is incorrect for a noarch extension.

Fedora 19 is EOL so there's no need for an ifdef to support it.

The test BRs have bogus npm format version numbers, and the jslint one isn't really required at all.

The explicit require on npm(jju) is unnecessary - let the dependency generator do it.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Jan 4 Jan

6:18 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #3 from Zuzana Svetlikova zsvetlik@redhat.com --- New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node... SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node...

I left the ExclusiveArch as it is for epel.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:15 p.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #4 from Tom Hughes tom@compton.nu --- You've fixed all the things I've mentioned, but you've also added a separate test archive which isn't needed as the tests are already present in the npm registry package.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Jan 5 Jan

5:17 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #5 from Zuzana Svetlikova zsvetlik@redhat.com --- New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node... SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-json-parse-helpfulerror/node...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:56 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Tom Hughes tom@compton.nu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #6 from Tom Hughes tom@compton.nu --- That looks good now. Package approved.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:13 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-json-parse-helpfulerror

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Jan 6 Jan

4:47 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057 Bug 1285057 depends on bug 1285056, which changed state.

Bug 1285056 Summary: Review Request: nodejs-jju - A set of utilities to work with JSON / JSON5 documents https://bugzilla.redhat.com/show_bug.cgi?id=1285056

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:48 a.m.

New subject: [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors

https://bugzilla.redhat.com/show_bug.cgi?id=1285057

Zuzana Svetlikova zsvetlik@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3485

Age (days ago)

3528

Last active (days ago)

package-review@lists.fedoraproject.org

12 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla