[Bug 226669] New: Merge Review: zip

List overview All Threads
Download

newer

older

[Bug 226213] New: Merge Review:...

[Bug 226665] New: Merge Review:...

Red Hat Bugzilla

31 Jan 2007 31 Jan '07

10:37 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

Summary: Merge Review: zip Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: varekova@redhat.com

Fedora Merge Review: zip

http://cvs.fedora.redhat.com/viewcvs/devel/zip/ Initial Owner: varekova@redhat.com

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by date

Red Hat Bugzilla

4 Feb 4 Feb

12:33 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

ruben@rubenkerkhof.com changed:

Red Hat Bugzilla

12:38 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

ruben@rubenkerkhof.com changed:

------- Additional Comments From ruben@rubenkerkhof.com 2007-02-04 06:38 EST ------- Review for release 1.2.2: * RPM name is OK * Source zip231.tar.gz is the same as upstream * Source zcrypt29.tar.gz is the same as upstream * Builds fine in mock * File list looks OK

Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Encoding should be UTF-8 * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7)

Minor: * The latest version is 2.32

Notes: * Please use {?dist} in the Release tag. See http://fedoraproject.org/wiki/DistTag for more info

Rpmlint is not silent:

Source RPM: W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP. E: zip tag-not-utf8 %changelog W: zip invalid-license distributable E: zip non-utf8-spec-file zip.spec W: zip mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 47)

rpmlint of zip: W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP. E: zip tag-not-utf8 %changelog W: zip invalid-license distributable

Red Hat Bugzilla

6 Feb 6 Feb

3:24 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

varekova@redhat.com changed:

------- Additional Comments From varekova@redhat.com 2007-02-06 09:24 EST ------- I have not updated to 2.32 - but everything else should be fixed in zip-2.31-2.fc7.

Red Hat Bugzilla

10:04 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

ruben@rubenkerkhof.com changed:

------- Additional Comments From ruben@rubenkerkhof.com 2007-02-06 16:04 EST ------- Hi Ivana,

One last thing, please preserve timestamps when installing files (install -p or cp -p)

Red Hat Bugzilla

7 Feb 7 Feb

10:03 a.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

varekova@redhat.com changed:

------- Additional Comments From varekova@redhat.com 2007-02-07 04:03 EST ------- Fixed in zip-2.31-3.fc7

Red Hat Bugzilla

10:05 a.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

varekova@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

Red Hat Bugzilla

12:52 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

varekova@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

Red Hat Bugzilla

10 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

ruben@rubenkerkhof.com changed:

------- Additional Comments From ruben@rubenkerkhof.com 2007-02-07 16:00 EST ------- I don't think the file BUGS is very relevant and MANUAL is a duplicate of the manpage your already installing.

Please consider removing those.

I don't see any further blockers, so this package is approved.

Red Hat Bugzilla

8 Feb 8 Feb

10:06 a.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

varekova@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

Red Hat Bugzilla

12 Feb 12 Feb

10:23 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

wtogami@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |

Red Hat Bugzilla

16 Feb 16 Feb

9:31 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

------- Additional Comments From pertusus@free.fr 2007-02-16 15:31 EST ------- Some suggestions:

* The crypt29 source seems to be unavailable. I have found: ftp://ftp.uu.net/pub/archiving/zip/src/zcrypt29.zip

* rename exec-shield.patch zip-exec-shield.patch

* add README.CR to %doc

* replace %defattr(-,root,root) with %defattr(-,root,root,-)

Red Hat Bugzilla

5 Apr 5 Apr

1:44 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226669

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium

mgarski@post.pl changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mgarski@post.pl

------- Additional Comments From mgarski@post.pl 2007-04-05 07:44 EST ------- * What's the reasons not updating to 2.32?

* I'm not sure but probably zcrypt29.zip can br droped.

As it states in crypt.c (from 2.31 and 2.32):

The main encryption/decryption source code for Info-Zip software was originally written in Europe. To the best of our knowledge, it can be freely distributed in both source and object forms from any country, including the USA under License Exception TSU of the U.S. Export Administration Regulations (section 740.13(e)) of 6 June 2002.

Prior to January 2000, re-export from the US was a violation of US law.

Enc/dec in 2.3{2,1} are newer then in zrypt29.zip

* Drop BUGS, as in 2.32 we can read: "This file is likely out of date 17 May 2006"

Red Hat Bugzilla

5 Feb 5 Feb

5:55 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: zip

https://bugzilla.redhat.com/show_bug.cgi?id=226669

bugzilla@redhat.com changed:

pertusus@free.fr changed:

------- Additional Comments From pertusus@free.fr 2008-02-05 11:55 EST ------- The bug should certainly be assigned to Ruben.

But the comments should also be addressed, in my opinion the package is not really ready for inclusion without those comments addressed.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

3 Dec 3 Dec

8:29 a.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226669

Karel Klíč kklic@redhat.com changed:

--- Comment #9 from Karel Klíč kklic@redhat.com 2009-12-03 02:29:57 EDT --- All comments are probably addressed now:

- zip is updated to 3.0 in rawhide - zcrypt29.zip has been dropped - exec-shield.patch has been renamed

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

10 Dec 10 Dec

4:20 p.m.

New subject: [Bug 226669] Merge Review: zip

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226669

Karel Klíč kklic@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

5703

Age (days ago)

6747

Last active (days ago)

package-review@lists.fedoraproject.org

15 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla