[Bug 1018542] New: Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Bug ID: 1018542
           Summary: Review Request: golang-github-jteeuwen-go-bindata - A
                    small utility which generates Go code from any file
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-jteeuwen-go-bindat...
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-jteeuwen-go-bindat...

Description:
A small utility which generates Go code from any file

This tool converts any file into managable Go source code. Useful for
embedding binary data into a go program. The file data is optionally gzip
compressed before being converted to a raw byte slice.

Fedora Account System Username: lsm5

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6054104

$ rpmlint SPECS/golang-github-jteeuwen-go-bindata.spec
SRPMS/golang-github-jteeuwen-go-bindata-0-0.1.git79847ab.fc21.src.rpm
RPMS/noarch/golang-github-jteeuwen-go-bindata-devel-0-0.1.git79847ab.fc21.noarch.rpm
SPECS/golang-github-jteeuwen-go-bindata.spec:35: W: setup-not-quiet
golang-github-jteeuwen-go-bindata.src:35: W: setup-not-quiet
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail],
                   |                            |[e-mail],
                   |                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1018543

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1018543
[Bug 1018543] etcd bundles golang library github.com/jteeuwen/go-bindata
which should be unbundled

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #1 from Matthew Miller  ---
It looks like this one should be built as a binary, non-devel package providing
the go-bindata tool, not the code.

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail])

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #2 from Matthew Miller  ---
The above also implies that the package should be "go-bindata", not the longer
import-path-based name.

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #3 from Matthew Miller  ---
So, no -devel subpackage. Also, BuildRequires golang but no Requires -- the
result is stand-alone.

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #4 from Matthew Miller  ---
I think this should do it for the %build section:

%build

mkdir -p src/github.com/jteeuwen/
ln -s $(pwd) src/github.com/jteeuwen/go-bindata
export GOPATH=$(pwd)
go build -v -a

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail])  |

--- Comment #5 from Lokesh Mandvekar  ---
%changelog
* Mon Oct 14 2013 Lokesh Mandvekar   0-0.2.git79847ab
- defattr removed
- only go-bindata installed, no devel package

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-jteeuwen-go-bindat...
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-jteeuwen-go-bindat...

[Bug 1018542] Review Request: golang-github-jteeuwen-go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail])

--- Comment #6 from Matthew Miller  ---
Except the package should actually be renamed to "go-bindata". :)

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request: go-bindata
                   |golang-github-jteeuwen-go-b |- A small utility which
                   |indata - A small utility    |generates Go code from any
                   |which generates Go code     |file
                   |from any file               |
              Flags|needinfo?([e-mail])  |

--- Comment #7 from Lokesh Mandvekar  ---
(In reply to Matthew Miller from comment #6)
> Except the package should actually be renamed to "go-bindata". :)

yup :)

%changelog
* Mon Oct 14 2013 Lokesh Mandvekar   0-0.3.git79847ab
- package name change to go-bindata

Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/go-bindata.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/go-bindata-0-0.3.git79847ab.fc21...

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #8 from Matthew Miller  ---
Looks good. As with all of the Go packages this may need to be updated as the
draft packaging guidelines are developed.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #9 from Lokesh Mandvekar  ---
New Package SCM Request
=======================
Package Name: go-bindata
Short Description: A small utility which generates Go code from any file
Owners: lsm5
Branches: f19 f20 el6
InitialCC:

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #10 from Jens Petersen  ---
Git done (by process-git-requests).

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #11 from Vincent Batts  ---
(In reply to Matthew Miller from comment #4)
> I think this should do it for the %build section:
>
> %build
>
> mkdir -p src/github.com/jteeuwen/
> ln -s $(pwd) src/github.com/jteeuwen/go-bindata
> export GOPATH=$(pwd)
> go build -v -a

does this still build fine if the rpm is installed on the host that is trying
to do a new build of the RPM?
Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata' to
go build?

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #12 from Matthew Miller  ---
(In reply to Vincent Batts from comment #11)
> does this still build fine if the rpm is installed on the host that is
> trying to do a new build of the RPM?
> Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata'
> to go build?

I'm pretty sure go-bindata just needs to be in the path. However, I see that
etcd's mod/dashboard build script wants to build the binary into $PWD (not even
$GOBIN!) and calls it as ./go-bindata.

We should either patch or ignore that build script (which we'll have to do
anyway because it's got other oddities).

Let me know if I'm missing something here.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #13 from Lokesh Mandvekar  ---
(In reply to Vincent Batts from comment #11)
> does this still build fine if the rpm is installed on the host that is
> trying to do a new build of the RPM?
> Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata'
> to go build?

It does build fine when already installed.

I'm guessing everything else is good to go for this package (?)

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #14 from Lokesh Mandvekar  ---
%changelog
* Fri Oct 18 2013 Lokesh Mandvekar   0-0.4.git79847ab
- buildrequires golang

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #15 from Matthew Miller  ---
Yeah I think it's just waiting builds :)

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #16 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.fc20

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #17 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.fc19

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #18 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.el6

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2013-10-18 14:24:54

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ON_QA
         Resolution|RAWHIDE                     |---
           Keywords|                            |Reopened

--- Comment #19 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.fc20 has been pushed to the Fedora 20 testing
repository.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs+                 |fedora-cvs?

--- Comment #20 from Peter Lemenkov  ---
Package Change Request
======================
Package Name: go-bindata
InitialCC: golang-sig

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

--- Comment #21 from Jon Ciesla  ---
Done.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |go-bindata-0-0.4.git79847ab
                   |                            |.fc19
         Resolution|---                         |ERRATA
        Last Closed|2013-10-18 14:24:54         |2013-10-28 23:41:22

--- Comment #22 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.fc19 has been pushed to the Fedora 19 stable
repository.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|go-bindata-0-0.4.git79847ab |go-bindata-0-0.4.git79847ab
                   |.fc19                       |.el6

--- Comment #23 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.el6 has been pushed to the Fedora EPEL 6 stable
repository.

[Bug 1018542] Review Request: go-bindata - A small utility which generates Go code from any file

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1018542

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|go-bindata-0-0.4.git79847ab |go-bindata-0-0.4.git79847ab
                   |.el6                        |.fc20

--- Comment #24 from Fedora Update System  ---
go-bindata-0-0.4.git79847ab.fc20 has been pushed to the Fedora 20 stable
repository.