[Bug 488618] New: Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Likewise Open - Likewise Active Directory Authentication Services

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Summary: Review Request: Likewise Open - Likewise Active
                    Directory Authentication Services
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:http://archives.likewise.com/~gcarter/Fedora/10/

SRPM URL:http://archives.likewise.com/~gcarter/Fedora/10/

Description: Likewise Open provides out-of-the-box authentication services for
Linux systems to Windows Active Directory. Likewise Open accelerates the
adoption of Linux systems in Windows-centric Active Directory corporate
intranets.

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Karsten Wade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Itamar Reis Peixoto   2009-03-04 18:59:20 EDT ---
is this your first package ?

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

--- Comment #2 from Krishna Ganugapati   2009-03-04 19:55:42 EDT ---
yes - am I missing something?

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #3 from Itamar Reis Peixoto   2009-03-04 22:50:06 EDT ---
(In reply to comment #2)
> yes - am I missing something?

yes, please get a fedora account(FAS) first

l@@k

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_a...

after you register please join the package group( in FAS ) and post your
username here.

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Xavier Bachelot   2009-03-13 21:37:18 EDT ---
You need to provide a direct link to both the srpm and the spec file.
Currently, one have to go to the url then look for the srpm. The spec file is
not available at all and one need to download the 47 MB srpm to look at the
spec.

Preliminary comments :
- License tag is not valid.
- Release is not using the disttag.
- BuildRoot is not valid. 
- Source0 and Source999 need to be a full URL.
- Spec file uses both spaces and tabs for indenting.
- The first half of the following line in %%build section is not needed :
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
- Same as above for %%clean section.
- File attributes are not set. Add the following line at the top of all the
packages sections :
%defattr (-,root,root-)
- %{_libdir}/likewise is not owned by any of the packages.
- Config files are not marked as such use %config and %config(noreplace) where
appropriate.
- %{_sysconfdir}/likewise is not owned.
- {_bindir}/demo is not owned.
- {_prefix}/share should be {_datadir}.
- /var should be {_localstatedir}
- %{_prefix}/bin should be %{_bindir}.
- %{_prefix}/data is not a standard dir and should not be created at all.
- No version-release for the changelog entries.
- No documentation included.
- No license file included.
- Services are provided but initscripts is not in the Requires: list nor are
the proper %%pre, %preun, etc... scriptlet used.
- You can use sed -i rather than sed then move, this will make the spec easier
to read.
- The build should probably not temper with the RPM_OPT_FLAGS and CFLAGS.
- The whole %%build and %%install sctions look fishy.
- Doesn't build in mock, needs at least to BuildRequires: openldap-devel,
krb5-devel but even with that, build still fails.

The list above is nowhere near complete, this package needs a lot of work.
Please carefully read the packaging guidelines to fix all of the above. You
should also run rpmlint on all the rpms and srpm.

Also, not directly related to the review, one need to register to receive a
link to the download page
(http://www.likewise.com/community/index.php/download/). It seems there's no
tarball to download but rather a lot of different tarballs. This is
confusing...

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(krishnag@likewise
                   |                            |.com)

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Krishna Ganugapati  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(krishnag@likewise |
                   |.com)                       |

--- Comment #5 from Krishna Ganugapati   2009-04-13 16:40:12 EDT ---
(In reply to comment #4)
> You need to provide a direct link to both the srpm and the spec file.
> Currently, one have to go to the url then look for the srpm. The spec file is
> not available at all and one need to download the 47 MB srpm to look at the
> spec.
> Preliminary comments :
> License tag is not valid.
> Release is not using the disttag.
> BuildRoot is not valid.
> Source0 and Source999 need to be a full URL.
> Spec file uses both spaces and tabs for indenting.
> The first half of the following line in %%build section is not needed :
>
> [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
> Same as above for %%clean section.
> File attributes are not set. Add the following line at the top of all the
>
> packages sections :
> %defattr (-,root,root-)
> %{_libdir}/likewise is not owned by any of the packages.
> Config files are not marked as such use %config and %config(noreplace) where
>
> appropriate.
> %{_sysconfdir}/likewise is not owned.
> {_bindir}/demo is not owned.
> {_prefix}/share should be {_datadir}.
> /var should be {_localstatedir}
> %{_prefix}/bin should be %{_bindir}.
> %{_prefix}/data is not a standard dir and should not be created at all.
> No version-release for the changelog entries.
> No documentation included.
> No license file included.
> Services are provided but initscripts is not in the Requires: list nor are
>
> the proper %%pre, %preun, etc... scriptlet used.
> You can use sed -i rather than sed then move, this will make the spec easier
>
> to read.
> The build should probably not temper with the RPM_OPT_FLAGS and CFLAGS.
> The whole %%build and %%install sctions look fishy.
> Doesn't build in mock, needs at least to BuildRequires: openldap-devel,
>
> krb5-devel but even with that, build still fails.
> The list above is nowhere near complete, this package needs a lot of work.
> Please carefully read the packaging guidelines to fix all of the above. You
> should also run rpmlint on all the rpms and srpm.
> Also, not directly related to the review, one need to register to receive a
> link to the download page
> (http://www.likewise.com/community/index.php/download/). It seems there's no
> tarball to download but rather a lot of different tarballs. This is
> confusing...

Thank you! We're working on this.

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

--- Comment #6 from Itamar Reis Peixoto   2009-04-13 16:55:46 EDT ---
(In reply to comment #5)

ok, please look Comment #3

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(krishnag@likewise
                   |                            |.com)

--- Comment #7 from Mamoru Tasaka   2009-05-29 12:46:48 EDT ---
What is the status of this bug?

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

--- Comment #8 from Mamoru Tasaka   2009-07-13 13:50:03 EDT ---
ping ?

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
             Blocks|177841(FE-NEEDSPONSOR)      |201449(FE-DEADREVIEW)
         Resolution|                            |NOTABUG
               Flag|needinfo?(krishnag@likewise |
                   |.com)                       |

--- Comment #9 from Jason Tibbitts   2009-08-01 14:08:58 EDT ---
No response; closing.

[Bug 488618] Review Request: Likewise Open - Likewise Active Directory Authentication Services

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488618

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |DUPLICATE

--- Comment #10 from Jason Tibbitts  2010-04-01 13:14:11 EDT ---

*** This bug has been marked as a duplicate of bug 578886 ***