[Bug 1234905] New: Review Request: jpype - Full access for Python programs to Java class libraries - package-review

List overview All Threads
Download

newer

[Bug 1234905] New: Review Request: jpype - Full access for Python programs to Java class libraries

older

[Bug 759818] Review Request:...

Red Hat Bugzilla

23 Jun 2015 23 Jun '15

6:19 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Bug ID: 1234905 Summary: Review Request: jpype - Full access for Python programs to Java class libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: projects.rg@smart.ms QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.0-1.src.rpm Description: Full access for Python programs to Java class libraries Fedora Account System Username: raphgro

rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10191266

Notes: - This is the main project at GitHub. I've already packaged the jpype-py3 fork but upstream does now officially support python3. - Python tests are not working currently, some not yet understood issue with CPython. But that should not prevent an initial review.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

23 Jun 23 Jun

6:20 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:30 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |bjoern.esser@gmail.com

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Jul 18 Jul

4:15 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Björn "besser82" Esser bjoern.esser@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Jul 21 Jul

12:27 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #1 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.0-2.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10428806

* Tue Jul 21 2015 Raphael Groner <> - 0.6.0-2 - include patch of proxy argument issue

Enabled python tests give me: ImportError: dynamic module does not define init function (PyInit__jpype)

This error may be related to https://bugs.python.org/issue19615

...

python3 --version

Python 3.4.2

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Jul 27 Jul

7:04 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

--- Comment #2 from Raphael Groner projects.rg@smart.ms --- Björn, how far are you with the review? Is there anything I need to fix? Please let me know about your questions.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Jul 30 Jul

6:30 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|bjoern.esser@gmail.com |puntogil@libero.it

--- Comment #3 from gil cattaneo puntogil@libero.it --- Björn, i will take this review, if you no have time

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:51 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl

--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- You cannot remove _static, it is necessary to display the html pages properly. You should unbundle jquery probably (by replacing jquery.js with a symlink to /usr/share/javascript/jquery/2.1.3/jquery.min.js).

Why install the tests is doc... It would imho be much better to stick them in the python dir, so that they are importable as jpypy.tests or so.

"sanify"

Why put both python2 and python3 in the same package? This will (among other things) pull in the full python2 stack for python3 users of this package and vice-versa.

Why are tests only run with python3?

Missing python2-* provides.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:41 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

--- Comment #5 from Raphael Groner projects.rg@smart.ms --- - I fully agree about _static inclusion and unbundling of jquery.

- Maybe it's best to remove the python2 stack completely. Before latest release, upstream's support was python2 only, now they promise full python3 support without the former github fork named jpype-py3 that's packaged already and my intention is to get it obsoleted when this review is done. Probably, I forgot to remove the python2 lines.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:48 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Support for both python versions *should* be provided if possible. Many people are still using py2...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:02 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #7 from gil cattaneo puntogil@libero.it --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/gil/1234905-jpype/licensecheck.txt

Please, ask to upstream to add license header for these files jpype-0.6.0/doc/conf.py jpype-0.6.0/native/python/include/capsulethunk.h jpype-0.6.0/native/python/include/jp_cocoatools.h jpype-0.6.0/native/python/include/jp_runloopstopper.h jpype-0.6.0/test/harness/jpype/array/Test2.java jpype-0.6.0/test/harness/jpype/attr/ClassWithBuffer.java jpype-0.6.0/test/harness/jpype/attr/TestOverloadA.java jpype-0.6.0/test/harness/jpype/attr/TestOverloadB.java jpype-0.6.0/test/harness/jpype/attr/TestOverloadC.java jpype-0.6.0/test/harness/jpype/exc/ChildTestException.java jpype-0.6.0/test/harness/jpype/exc/ParentTestException.java jpype-0.6.0/test/harness/jpype/properties/TestBean.java jpype-0.6.0/test/harness/jpype/proxy/TestInterface1.java jpype-0.6.0/test/harness/jpype/proxy/TestThreadCallback.java jpype-0.6.0/test/transform_xunit_to_appveyor.xsl

[x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.4/site- packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4 /site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site- packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site- packages/jpypex(jpype-py3), /usr/lib/python3.4/site- packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpype(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt/__pycache__(jpype-py3) [?]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Java: [x]: Bundled jar/class files should be removed before build

Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jpype- doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

Java: [-]: Packages are noarch unless they use JNI Note: jpype subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: jpype-0.6.0-2.i686.rpm jpype-doc-0.6.0-2.noarch.rpm jpype-0.6.0-2.src.rpm jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env 3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (debuginfo) ------------------- Checking: jpype-debuginfo-0.6.0-2.i686.rpm jpype-debuginfo.i686: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- jpype-debuginfo.i686: E: debuginfo-without-sources jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env 3 packages and 0 specfiles checked; 1 errors, 1 warnings.

Requires -------- jpype (rpmlib, GLIBC filtered): libc.so.6 libdl.so.2 libpthread.so.0 libpython2.7.so.1.0 libpython3.4m.so.1.0 python(abi) rtld(GNU_HASH)

jpype-doc (rpmlib, GLIBC filtered): /usr/bin/env

Provides -------- jpype: jpype jpype(x86-32)

jpype-doc: jpype-doc

Unversioned so-files -------------------- jpype: /usr/lib/python2.7/site-packages/_jpype.so jpype: /usr/lib/python3.4/site-packages/_jpype.so

Source checksums ---------------- https://github.com/originell/jpype/archive/v0.6.0.tar.gz#/jpype-0.6.0.tar.gz : CHECKSUM(SHA256) this package : 496c7788fe885c2f798d8ff8d3f584caed5dd7257aeeceb554298cb5cc99787a CHECKSUM(SHA256) upstream package : 496c7788fe885c2f798d8ff8d3f584caed5dd7257aeeceb554298cb5cc99787a

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1234905 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Shell-api, Generic, Java, C/C++ Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:05 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #8 from gil cattaneo puntogil@libero.it --- NON blocking issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/gil/1234905-jpype/licensecheck.txt see above jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env Please, fix this file

Blocking issues: jpype-debuginfo.i686: E: debuginfo-without-sources

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Aug 14 Aug

7:28 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #9 from Raphael Groner projects.rg@smart.ms --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)

...

Support for both python versions *should* be provided if possible. Many people are still using py2...

Support for python2 (cause of legacy and theoretical reasons) will complicate things a lot and increases complexity in packaging. There is currently no package that requires a jpype with python2.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:49 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #10 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Raphael Groner from comment #9)

...

(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)

...
Support for both python versions *should* be provided if possible. Many people are still using py2...

Support for python2 (cause of legacy and theoretical reasons) will complicate things a lot and increases complexity in packaging.

Please have a look at the new python guidelines [https://fedoraproject.org/wiki/Packaging:Python]. They have been recently updated to make parallel python2 and python3 packaging much easier.

...

There is currently no package that requires a jpype with python2.

Packaging both versions is encouraged, even if there are no immediate users, because it much easier to move dependent projects between both versions. Another reason is that people develop their own things on Fedora, so we provide things even if they are not used by the rest of distribution.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:12 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

--- Comment #11 from Raphael Groner projects.rg@smart.ms --- Do you have the ability to maintain this package in the requested complexity? If yes, you can take this review request. Sorry but I do not have the time to handle this complexity.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:58 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #12 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I don't have any particular interest in this package. Having python2 and python3 subpackages is not (one can at least assume that without further information) harder than in any other python package... If you have a reason to think that for this package it *is* so, for example because of the interaction between java and versions, than you can provide just the python3 version. I was pretty careful to use "should" everywhere. It's your choice, even if the project encourages support for both versions.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:08 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |DEFERRED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 Aug 23 Aug

1:20 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

--- Comment #13 from Raphael Groner projects.rg@smart.ms --- I decided to relaunch this review request and think to (hopefully) understand now how to apply properly the new python guidelines.

jpype.spec - subpackages python2-jpype and python3-jpype - individual %python_provides python-jpype - virtual Provides: jpype - Obsoletes: jpype-py3 - epel7 has only python2-jpype - python3 support for f22+

gil, it's a multi licensed project, some headers are taken from JDK and Python, it's already mentioned in a comment, we found that situation early in the review of jpype-py3. Test files could be removed from doc package when license and any other issue for those are still unclear.

...

Blocking issues: jpype-debuginfo.i686: E: debuginfo-without-sources

This is cause of wrong BuildArch, I'll change to noarch.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:28 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:29 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Sep 10 Sep

4:31 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #14 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.1-1.src.rpm

Task info (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032558 Task info (epel7): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032469

* Thu Sep 10 2015 Raphael Groner <> - 0.6.1-1 - new upstream release v0.6.1 - make tests work with python3 - deprecation of jpype-py3 - split subpackages for python2 and 3 - use python build and install macros - ease html generation - ship _static documentation files - unbundle jquery - ship tests folder as an import option w/o execution bits - restrict documentation to only some .rst files

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:59 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #15 from gil cattaneo puntogil@libero.it --- Start now the review... if have time (no problems if you cant) can review this for me https://bugzilla.redhat.com/show_bug.cgi?id=1260975 ? thanks in advance

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:12 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #16 from gil cattaneo puntogil@libero.it --- Build fails: BUILD SUCCESSFUL Total time: 1 second + popd + sphinx-build -d doctrees doc html ~/build/BUILD/jpype-0.6.1 Compilation errors RPM: /var/tmp/rpm-tmp.fuNA0A: line 42: sphinx-build: command not found

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:16 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #17 from Raphael Groner projects.rg@smart.ms --- Fixed. Not worth to bump the Release number.

Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.1-1.src.rpm

Task info (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=11033944 Task info (epel7): http://koji.fedoraproject.org/koji/taskinfo?taskID=11033982

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:44 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #18 from gil cattaneo puntogil@libero.it --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils IGNORE - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation IGNORE - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation IGNORE

===== MUST items =====

C/C++: [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 40 files have unknown license. Detailed output of licensecheck in /home/gil/1234905-jpype/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.4/site- packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4 /site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site- packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site- packages/jpypex(jpype-py3), /usr/lib/python3.4/site- packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site- packages/jpype(jpype-py3), /usr/lib/python3.4/site- packages/jpype/awt/__pycache__(jpype-py3) [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [-]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Java: [x]: Bundled jar/class files should be removed before build

Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used

===== SHOULD items =====

Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-jpype , python3-jpype , jpype-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

Java: [x]: Packages are noarch unless they use JNI Note: python2-jpype subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python2-jpype-0.6.1-1.i686.rpm python3-jpype-0.6.1-1.i686.rpm jpype-doc-0.6.1-1.noarch.rpm jpype-0.6.1-1.src.rpm python3-jpype.i686: W: self-obsoletion jpype-py3 obsoletes jpype-py3 python3-jpype.i686: E: python-bytecode-inconsistent-mtime /usr/lib/python3.4/site-packages/jpypetest/__pycache__/jvmfinder.cpython-34.pyo 2015-09-10T16:23:39 /usr/lib/python3.4/site-packages/jpypetest/jvmfinder.py 2015-09-10T16:24:01 jpype-doc.noarch: W: dangling-relative-symlink /usr/share/doc/jpype-doc/html/_static/jquery.js %{_jsdir}/jquery/2/jquery.min.js jpype.src:48: W: unversioned-explicit-provides %{name} jpype.src:67: W: unversioned-explicit-obsoletes %{name}-py3 jpype.src:68: W: unversioned-explicit-provides %{name}-py3 4 packages and 0 specfiles checked; 1 errors, 5 warnings.

Rpmlint (debuginfo) ------------------- Checking: jpype-debuginfo-0.6.1-1.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- python3-jpype.i686: W: self-obsoletion jpype-py3 obsoletes jpype-py3 python3-jpype.i686: E: python-bytecode-inconsistent-mtime /usr/lib/python3.4/site-packages/jpypetest/__pycache__/jvmfinder.cpython-34.pyo 2015-09-10T16:23:39 /usr/lib/python3.4/site-packages/jpypetest/jvmfinder.py 2015-09-10T16:24:01 jpype-doc.noarch: W: dangling-relative-symlink /usr/share/doc/jpype-doc/html/_static/jquery.js %{_jsdir}/jquery/2/jquery.min.js 4 packages and 0 specfiles checked; 1 errors, 2 warnings.

Requires -------- python3-jpype (rpmlib, GLIBC filtered): libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libpthread.so.0 libpython3.4m.so.1.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) python(abi) rtld(GNU_HASH)

python2-jpype (rpmlib, GLIBC filtered): libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libpthread.so.0 libpython2.7.so.1.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) python(abi) rtld(GNU_HASH)

jpype-doc (rpmlib, GLIBC filtered): js-jquery

Provides -------- python3-jpype: jpype-py3 python3-jpype python3-jpype(x86-32)

python2-jpype: jpype python-jpype python2-jpype python2-jpype(x86-32)

jpype-doc: jpype-doc

Unversioned so-files -------------------- python2-jpype: /usr/lib/python2.7/site-packages/_jpype.so python3-jpype: /usr/lib/python3.4/site-packages/_jpype.cpython-34m.so

Source checksums ---------------- https://github.com/originell/jpype/archive/v0.6.1.tar.gz#/jpype-0.6.1.tar.gz : CHECKSUM(SHA256) this package : f7e81ef2e722a26929d329d2a15e2638f5b28f15a30d1dff1c88e6c3d38a85d8 CHECKSUM(SHA256) upstream package : f7e81ef2e722a26929d329d2a15e2638f5b28f15a30d1dff1c88e6c3d38a85d8

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:45 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #19 from gil cattaneo puntogil@libero.it --- Seem all fine. Approved

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:59 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST

--- Comment #20 from Raphael Groner projects.rg@smart.ms --- New Package SCM Request ======================= Package Name: jpype Short Description: Full access for Python programs to Java class libraries Upstream URL: https://github.com/originell/jpype Owners: raphgro Branches: f23 f22 epel7 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:12 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:52 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:52 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #21 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Sep 12 Sep

12:52 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #22 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:52 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:17 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #23 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:05 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #24 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:19 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #25 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Sep 13 Sep

11:20 a.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #26 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:49 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #27 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Oct 4 Oct

12:16 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #28 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:16 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:51 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #29 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:01 p.m.

New subject: [Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1234905

--- Comment #30 from Fedora Update System updates@fedoraproject.org --- jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3577

Age (days ago)

3681

Last active (days ago)

package-review@lists.fedoraproject.org

40 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla