https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Bug ID: 1354373 Summary: Review Request: qt5 - Qt5 meta package Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: helio@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://heliocastro.fedorapeople.org/qt5/qt5.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5/qt5-5.7.0-5.fc24.src.rpm Description: Qt5 meta package Fedora Account System Username: heliocastro
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Daniel Vrátil me@dvratil.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@dvratil.cz
--- Comment #1 from Daniel Vrátil me@dvratil.cz --- Moving macros.qt5 from qt5-qtbase here means that packagers will have to have this package (and thus the *entire* Qt5) installed in order to do packaging work on anything that depends on Qt5. I don't like that. I would much more prefer keeping the macro files in qt5-qtbase.
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #2 from Daniel Vrátil me@dvratil.cz --- Oh, I haven't noticed the rpm-macros subpackage. Please ignore my previous comment.
(I blame the unbearable temperatures in my office :-))
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms
--- Comment #3 from Raphael Groner projects.rg@smart.ms ---
%files rpm-macros %{_rpmconfigdir}/macros.d/macros.qt5
Wondering too here, why not (any more) in qt5-qtbase-devel ?
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #4 from Helio Chissini de Castro helio@kde.org --- Devel on qt5-qtbase-devel requires the macro package
Since everyone uses qt5-qtbase-devel it comes by default.
I just wanted to follow same schema as kf5.macros.
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Christian Dersch lupinix@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lupinix@mailbox.org Assignee|nobody@fedoraproject.org |lupinix@mailbox.org Flags| |fedora-review?
--- Comment #5 from Christian Dersch lupinix@mailbox.org --- Will review now
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #6 from Christian Dersch lupinix@mailbox.org --- Approved! Stuff like macros looks fine, package is named correctly, Conflicts/Provides etc. is fine.
Just one question: Maybe you want to introduce versioned dependencies? So if one installs qt5-5.7.0 all deps are forced to be Qt 5.7.0.
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Christian Dersch lupinix@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #7 from Christian Dersch lupinix@mailbox.org --- And of course: fedora-review does not show any obvious issues :)
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
--- Comment #8 from Rex Dieter rdieter@math.unl.edu --- sed -i \ -e "s|@@QT5_CFLAGS@@|%{?qt5_cflags}|g" \ -e "s|@@QT5_CXXFLAGS@@|%{?qt5_cxxflags}|g" \ -e "s|@@QT5_RPM_LD_FLAGS@@|%{?qt5_rpm_ld_flags}|g" \ -e "s|@@QT5_RPM_OPT_FLAGS@@|%{?qt5_rpm_opt_flags} %{?qt5_null_flag}|g" \ %{buildroot}%{_rpmconfigdir}/macros.d/macros.qt5
This won't work as-is, since the macros qt5_cflags qt5_cxxflags qt5_rpm_ld_flags qt5_rpm_opt_flags are not yet defined when this package is built.
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #9 from Helio Chissini de Castro helio@kde.org --- Fixed on
Spec URL: https://heliocastro.fedorapeople.org/qt5/qt5.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5/qt5-5.7.0-6.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1354373
Helio Chissini de Castro helio@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-10-07 07:42:41
package-review@lists.fedoraproject.org