https://bugzilla.redhat.com/show_bug.cgi?id=2181676
Bug ID: 2181676 Summary: Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: linux@cmadams.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmada... SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmada... Description: These are some useful Nagios monitoring plugins:
- check_cert: This plugin makes an SSL/TLS connection to the specified server/port, validates the cert, and warns/errors on the number of days until the cert expires. It can be set to check an RSA or ECDSA cert, and can check some types of connections using STARTTLS.
- check_chrony: This plugin checks the selected chrony NTP server using the "chronyc" command line client.
- check_smtp_msg: This plugin makes a connection to an SMTP server, sends a message, and checks the result.
Fedora Account System Username: cmadams
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
Chris Adams linux@cmadams.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Chris Adams linux@cmadams.net --- An alternate setup: since the plugins are independent, put them into separate RPMs
Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins... SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins...
I initially started with just bundling them together, but being able to install them separately probably makes more sense.
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1955617 --> https://bugzilla.redhat.com/attachment.cgi?id=1955617&action=edit The .spec file difference from Copr build 5706893 to 5740123
Product: Fedora Version: rawhide Component: Package Review
Chris Adams linux@cmadams.net has canceled Package Review package-review@lists.fedoraproject.org's request for Chris Adams linux@cmadams.net's needinfo: Bug 2181676: Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #4 from Chris Adams linux@cmadams.net --- It'd still be nice to get this reviewed; I feel the plugins would be useful to more than just myself.
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
Chris Adams linux@cmadams.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(linux@cmadams.net | |) |
--- Comment #4 from Chris Adams linux@cmadams.net --- It'd still be nice to get this reviewed; I feel the plugins would be useful to more than just myself.
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
Chris Adams linux@cmadams.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(linux@cmadams.net | |) |
--- Comment #6 from Chris Adams linux@cmadams.net --- I think this would still be a useful monitoring package.
Product: Fedora Version: rawhide Component: Package Review
Chris Adams linux@cmadams.net has canceled Package Review package-review@lists.fedoraproject.org's request for Chris Adams linux@cmadams.net's needinfo: Bug 2181676: Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #6 from Chris Adams linux@cmadams.net --- I think this would still be a useful monitoring package.
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer.
If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it.
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9819256 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #9 from Chris Adams linux@cmadams.net --- Updated:
Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmada... SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmada...
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2115929 --> https://bugzilla.redhat.com/attachment.cgi?id=2115929&action=edit The .spec file difference from Copr build 9819256 to 9830853
https://bugzilla.redhat.com/show_bug.cgi?id=2181676
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/cmadamsg | |it/%{name}
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9830853 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org