https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug ID: 1541346 Summary: Review Request: phpunit7 - The PHP Unit Testing framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://git.remirepo.net/cgit/rpms/phpunit/phpunit7.git/plain/phpunit7.spec?... SRPM URL: http://rpms.remirepo.net/SRPMS/phpunit7-7.0.0-1.remi.src.rpm Description: PHPUnit is a programmer-oriented testing framework for PHP. It is an instance of the xUnit architecture for unit testing frameworks.
Fedora Account System Username: remi
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1541343, 1541334, 1541340, | |1541337, 1539554
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1539554 [Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout https://bugzilla.redhat.com/show_bug.cgi?id=1541334 [Bug 1541334] Review Request: php-phpunit-php-timer2 - PHP Utility class for timing https://bugzilla.redhat.com/show_bug.cgi?id=1541337 [Bug 1541337] Review Request: php-sebastian-diff3 - Diff implementation https://bugzilla.redhat.com/show_bug.cgi?id=1541340 [Bug 1541340] Review Request: php-phpunit-mock-objects6 - Mock Object library for PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=1541343 [Bug 1541343] Review Request: php-phpunit-php-code-coverage6 - PHP code coverage information
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Group: and %{!?_licensedir:%global license %%doc} are not needed
- RPMLint error:
phpunit7.noarch: E: wrong-script-interpreter /usr/bin/phpunit7 /usr/bin/env php
Policy is not to use env in Fedora. What is the motivation for removing brp_mangle_shebangs ?
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD (3 clause)". 600 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/phpunit7/review- phpunit7/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: phpunit7-7.0.0-1.fc28.noarch.rpm phpunit7-7.0.0-1.fc28.src.rpm phpunit7.noarch: W: spelling-error %description -l en_US xUnit -> x Unit, unit phpunit7.noarch: E: wrong-script-interpreter /usr/bin/phpunit7 /usr/bin/env php phpunit7.noarch: W: no-manual-page-for-binary phpunit7 phpunit7.src: W: spelling-error %description -l en_US xUnit -> x Unit, unit 2 packages and 0 specfiles checked; 1 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
--- Comment #2 from Remi Collet fedora@famillecollet.com --- (In reply to Robert-André Mauchin from comment #1)
- RPMLint error:
phpunit7.noarch: E: wrong-script-interpreter /usr/bin/phpunit7 /usr/bin/env php
Policy is not to use env in Fedora. What is the motivation for removing brp_mangle_shebangs ?
Because I don't agree with this Guidelines.
Such packages works perfectly with different PHP versions (for most PHP projects, compatibility with newer PHP version is considered as a standard feature, and when needed, fixed as a bug)
This is commonly used in travis, daily, by tons of project to ensure compatibility with various PHP versions.
Having this package locked with default version will make no sense, making it unusable, and this will encourage php users to use the upstream distribution (.phar file) instead of this package.
This is described in https://blog.remirepo.net/post/2016/04/16/My-PHP-Workstation (§ Working on PHP code)
This specific version doesn't support old PHP version, but handles this properly
$ module load php56 $ phpunit7 This version of PHPUnit is supported on PHP 7.1 and PHP 7.2. You are using PHP 5.6.33 (/opt/remi/php56/root/usr/bin/php).
When I submit this review this was still under discussion by FPC as https://pagure.io/packaging-committee/issue/725 is now rejected, I'm sad
So I you prefer, I can remove the macro for the review (well... to be honest... I will probably re-add it later)
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Make rpmlint happy and me sad: https://git.remirepo.net/cgit/rpms/phpunit/phpunit7.git/commit/?id=d42d474d0...
Spec URL: https://git.remirepo.net/cgit/rpms/phpunit/phpunit7.git/plain/phpunit7.spec?... SRPM URL: http://rpms.remirepo.net/SRPMS/phpunit7-7.0.0-2.remi.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1542485
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1542485 [Bug 1542485] Review Request: phpcpd - Copy/Paste Detector (CPD) for PHP code
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
But as said in the ticket, you need to discuss this in the ML, and try to convert people to your pov. I remember Igor was quite opposed to this.
https://bugzilla.redhat.com/show_bug.cgi?id=1541346 Bug 1541346 depends on bug 1539554, which changed state.
Bug 1539554 Summary: Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout https://bugzilla.redhat.com/show_bug.cgi?id=1539554
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1541346 Bug 1541346 depends on bug 1541337, which changed state.
Bug 1541337 Summary: Review Request: php-sebastian-diff3 - Diff implementation https://bugzilla.redhat.com/show_bug.cgi?id=1541337
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1541346 Bug 1541346 depends on bug 1541334, which changed state.
Bug 1541334 Summary: Review Request: php-phpunit-php-timer2 - PHP Utility class for timing https://bugzilla.redhat.com/show_bug.cgi?id=1541334
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1541346 Bug 1541346 depends on bug 1541343, which changed state.
Bug 1541343 Summary: Review Request: php-phpunit-php-code-coverage6 - PHP code coverage information https://bugzilla.redhat.com/show_bug.cgi?id=1541343
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1541346 Bug 1541346 depends on bug 1541340, which changed state.
Bug 1541340 Summary: Review Request: php-phpunit-mock-objects6 - Mock Object library for PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=1541340
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Thanks for the review
SCM request https://pagure.io/releng/fedora-scm-requests/issue/4441
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/phpunit7
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-02-07 10:01:14
https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1543060
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1543060 [Bug 1543060] Review Request: php-phpunit-dbunit4 - Extension for database interaction testing for PHPUnit 7
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com