[Bug 191130] New: Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

Summary: Review Request: kmobiletools
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://ausil.us/packages/kmobiletools.spec
SRPM URL: http://ausil.us/packages/kmobiletools-0.4.3.3-1.fc5.src.rpm
Description: 
KMobileTools is a KDE application that allows you to control your mobile phone
from your GNU/Linux workstation

To use KMobileTools you need a mobile phone, that can be attached to your PC
using any type of connection (serial, USB, bluetooth and irda were tested
successfully), and using an AT interface (modem-like)

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

------- Additional Comments From [e-mail]  2006-05-09 09:47 EST -------
DEFINE QT Dirs to ensure  build is ok
Spec URL: http://ausil.us/packages/kmobiletools.spec
SRPM URL: http://www.ausil.us/packages/kmobiletools-0.4.3.3-2.src.rpm

also not 100% sure is I should include a udev ruleset.  the couple of mobile 
phones i have tried use /dev/ttyACM0  which gets 
[dennis@rpclnx001 SPECS]$ ls -la /dev/ttyACM0
crw-rw---- 1 root uucp 166, 0 May  9 08:32 /dev/ttyACM0

so the user cant access the phone. the two  things  that can make it easier is  
1 making the owner  the logged in user  or 
2 make the users  needing access members of the uucp group

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

------- Additional Comments From [e-mail]  2006-05-17 18:42 EST -------
As a mobile phone user, I think this would be a great tool to add.  I am trying
moto4lin which works with my Motorla phone but it would be better to have a full
tools available.

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

------- Additional Comments From [e-mail]  2006-05-17 23:18 EST -------
kmobiletools doesnt do everything.  it does not provide a way to put pictures 
and files on you phone or to take them off.  It allows you to manage sms and 
phone book

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-21 04:48 EST -------
Hello.. I will review this package for you..

----------------------------------------

Review for release 2:

* RPM name is OK
* Source kmobiletools-0.4.3.3.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK

Needs work:
* Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets)
* Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets)

Package looks pretty good. If you fix up the %post/%postun scriplets, I can
approve this submission.

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

------- Additional Comments From [e-mail]  2006-07-21 07:14 EST -------
I wont fix  the %post/%postun  there is no need to add gnome cruft to a kde 
package.  and as has been stated in quite a few package reviews  and there is 
a bug filed  gtk-update-icon-cache   should be run as a cron job  not in 
packages.

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

------- Additional Comments From [e-mail]  2006-07-21 07:23 EST -------
Re: comment #5.  I support Dennis' comment.  The fdo icon spec only requires
"touch"ing the affected icon dirs.

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-21 16:31 EST -------
OK then. I am just following the guidelines :-)

However, I will APPROVE the submission as is. Please do not forget to close this
review once its been imported into CVS.

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-07-21 17:47 EST -------
thanks for the review,  branched and built will go out with next push

[Bug 191130] Review Request: kmobiletools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools

https://bugzilla.redhat.com/show_bug.cgi?id=191130

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide