[Bug 204694] New: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: packages@amiga-hardware.com QAContact: fedora-package-review@redhat.com
Spec URL: http://dribble.org.uk/reviews/zvbi.spec SRPM URL: http://dribble.org.uk/reviews/zvbi-0.2.22-1.src.rpm Description:
ZVBI provides functions to capture and decode VBI data. The vertical blanking interval (VBI) is an interval in a television signal that temporarily suspends transmission of the signal for the electron gun to move back up to the first line of the television screen to trace the next screen field. The vertical blanking interval can be used to carry data, since anything sent during the VBI would naturally not be displayed; various test signals, closed captioning, and other digital data can be sent during this time period.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |204421 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
------- Additional Comments From panemade@gmail.com 2006-09-01 02:13 EST ------- rpmlint on binary rpm reported zvbi-0.2.22-1.fc6.i386.rpm I: zvbi checking W: zvbi no-reload-entry /etc/rc.d/init.d/zvbid In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality.
W: zvbi incoherent-init-script-name zvbid The init script name should be the same as the package name in lower case.
all above warnings have their descriptions given about how to solve them so follow that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
------- Additional Comments From rdieter@math.unl.edu 2006-09-01 08:14 EST -------
you don't have a 'reload' entry, which is necessary for good functionality.
And if the daemon doesn't support reload? (alias it to restart?)
The init script name should be the same as the package name in lower case
Not required, hence rpmlint marking this as a warning only, not an error. IMO, the script name should be the same as the daemon in question.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
------- Additional Comments From rdieter@math.unl.edu 2006-09-01 08:28 EST ------- I can review this. At first glance, package looks clean, just a few items off the top of my head so far:
1. in -devel: Change Requires: zvbi = %{version}-%{release} to the less error-prone: Requires: %{name} = %{version}-%{release}
2. in %post/%postun fonts, change /usr/bin/fc-cache %{_datadir}/fonts to /usr/bin/fc-cache %{_datadir}/fonts/%{name} no need to tell fc-cache to reparse *all* of %_datadir/fonts, when we're only interested in %_datadir/fonts/%name
3. -fonts: I'm pretty sure there's no real need for Requires: fontconfig Requires(post): /usr/bin/fc-cache Requires(postun): /usr/bin/fc-cache The pkg doesn't *really* need/use fontconfig, and the calls to fc-cache in scriptlets are wrapped with: if [ -x /usr/bin/fc-cache ]; then ... fi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
------- Additional Comments From rdieter@math.unl.edu 2006-09-01 08:39 EST ------- Ammend item 2: Only should change %post, I'd recommend: /usr/bin/fc-cache -f %{_datadir}/fonts/%{name} shouldn't change %postun, since %{_datadir}/fonts/%{name} no longer exists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
------- Additional Comments From packages@amiga-hardware.com 2006-09-01 12:37 EST -------
W: zvbi no-reload-entry /etc/rc.d/init.d/zvbid In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality.
W: zvbi incoherent-init-script-name zvbid The init script name should be the same as the package name in lower case.
all above warnings have their descriptions given about how to solve them so follow that.
I'm in agreement with Rex on this one, I think calling the init script zvbi in this case doesn't make much sense, particularly when the daemon is really a small subset of the whole zvbi package, as opposed to being the primary function. It would require more than a simple namechange as the init script would need to be patched so that the 'subsystems' had matching names. Overkill I think for simply dropping the trailing 'd'.
With wrt the reload option as it's considered optional I would rather not add it. IIRC primary reason for a reload option is to tell the daemon to reload its config files without quitting and starting again which is very useful for daemons that don't instantly stop or start such as squid, but in this case zvbid doesn't load configs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
------- Additional Comments From packages@amiga-hardware.com 2006-09-01 15:40 EST ------- Here's the latest version incorporating the three fixes from above.
Spec URL: http://dribble.org.uk/reviews/zvbi.spec SRPM URL: http://dribble.org.uk/reviews/zvbi-0.2.22-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From rdieter@math.unl.edu 2006-09-07 15:20 EST ------- Excellent, looks good, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From packages@amiga-hardware.com 2006-09-07 20:47 EST ------- Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=204694
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=204694
Dmitry Butskoy dmitry@butskoy.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@butskoy.name Flag| |fedora-cvs?
--- Comment #9 from Dmitry Butskoy dmitry@butskoy.name 2011-02-04 10:12:28 EST --- Package Change Request ====================== Package Name: zvbi New Branches: el5 el6 Owners: buc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=204694
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2011-02-06 17:39:30 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla