[Bug 1957929] New: Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

Bug ID: 1957929
           Summary: Review Request: lorax-templates-rhel - RHEL build
                    templates for lorax and livemedia-creator
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/sgallagh/lorax-templates-...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/sgallagh/lorax-templates-...
Fedora Account System Username: sgallagh
Description:
RHEL-specific Lorax templates for creating the boot.iso and live isos are
placed in %{templatedir}

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #1 from Stephen Gallagher  ---
Review template:
https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhe...

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

--- Comment #3 from Neal Gompa  ---
So there are a couple of issues:
> URL:            https://github.com/weldr/lorax
> [..]
> Source0:        lorax-templates-rhel-9.0-14.tar.gz

The URL doesn't point to the actual project, and the Source0 does not point to
a proper upstream SourceURL.

We generally want to avoid packages in Fedora like this, since the upstream
relationship is nonexistent.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
> rm -rf $RPM_BUILD_ROOT

This can be removed, as RPM does this automatically.

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Stephen Gallagher  ---
(In reply to Neal Gompa from comment #3)
> So there are a couple of issues:
> > URL:            https://github.com/weldr/lorax
> > [..]
> > Source0:        lorax-templates-rhel-9.0-14.tar.gz
>
> The URL doesn't point to the actual project, and the Source0 does not point
> to a proper upstream SourceURL.

This package provides only data files to support the lorax project. The URL is
correct.

This dist-git repository will be its own upstream. The tarball is generated by
a Makefile included with the sources. I have added a comment to this effect
into the specfile to avoid confusion in the future.
> > rm -rf $RPM_BUILD_ROOT
>
> This can be removed, as RPM does this automatically.

Done.

I also updated the version to 10.0 since ELN is currently tracking towards that
release.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhe...

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhe...

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Neal Gompa  ---
I strongly suggest that you make it so that the tarball isn't needed in the
future. But for now, it looks good to me.

PACKAGE APPROVED.

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

--- Comment #6 from Stephen Gallagher  ---
(In reply to Neal Gompa from comment #5)
> I strongly suggest that you make it so that the tarball isn't needed in the
> future. But for now, it looks good to me.
>
> PACKAGE APPROVED.

We discussed this on IRC. The tarball is actually generated from files in the
dist-git repository. It's done with a tarball for simplicity, since having 90
files listed in Sources would be unwieldy.

[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

https://bugzilla.redhat.com/show_bug.cgi?id=1957929

--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/lorax-templates-rhel