https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Bug ID: 1161834 Summary: Review Request: girl - GNOME Internet Radio Locator Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: oka@oka.no QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.ping.uio.no/~oka/src/girl/girl.spec SRPM URL: http://www.ping.uio.no/~oka/src/girl/girl-0.2.2-1.src.rpm
Description: I am the developer of the GNOME Internet Radio Locator and would like to see it included in Fedora. It is my first Fedora package, and I need a sponsor. The program supports 3 radio stations so far: KZSU (Stanford University), WMBR (Massachusetts Institute of Technology), and KEXP (University of Washington).
Fedora Account System Username: oka
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #1 from Ole Aamot oka@oka.no --- Successful build on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8069651
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Packages must follow the Fedora Packaging guidelines [1]. Please update your package and post the new stuff.
[1] https://fedoraproject.org/wiki/Packaging:Guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #3 from Ole Aamot oka@oka.no ---
girl 0.4.1 is now available.
The following 4 radio stations are new in this girl 0.4 minor release:
Cam FM (Cambridge University, Cambridge, England), Oxide Radio (Oxford University, Oxford, England), Pulse Radio (London School of Economics, London, England) and also Radio UNAM (Universidad Nacional Autónoma de México, México).
Minor Changes
* AUTHORS: Add Marek Černocký (Czech translation). * AUTHORS: Add Rafael Ferreira (Brazilian Portuguese translation). * NEWS: girl 0.4.1 released. * configure.ac: Version 0.4.1. * po/cs.po: Czech translation by Marek Černocký. * po/pt_BR.po: Brazilian Portuguese translation by Rafael Ferreira. * src/girl-0.5.dtd: Add station type property. * src/stations.xml: Add Cam FM (www.camfm.co.uk). * src/stations.xml: Add Oxford Student Radio (oxideradio.co.uk). * src/stations.xml: Add Pulse LSE (pulselse.co.uk). * src/stations.xml: Add Radio UNAM (www.radiounam.unam.mx).
Stations XML data http://girl.src.oka.no/stations.xml
Mailing list http://mail.gnome.org/mailman/listinfo/girl-list/
Git repository https://git.gnome.org/girl
Source releases http://download.gnome.org/sources/girl
Spec URL: http://www.ping.uio.no/~oka/src/girl/girl.spec SRPM URL: http://www.ping.uio.no/~oka/src/girl/girl-0.4.1-1.src.rpm
Successful build on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8246486
8246486 build (f21, girl-0.4.1-1.src.rpm) completed successfully
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #4 from Ole Aamot oka@oka.no --- RPM packages of girl 0.5.1 for Fedora 21 is now available.
Spec URL: http://www.ping.uio.no/~oka/src/girl/girl.spec SRPM URL: http://www.ping.uio.no/~oka/src/girl/girl-0.5.1-1.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8258290
Screenshot: http://www.ping.uio.no/~oka/src/girl/screenshot.png
Please consider reviewing the package.
girl 0.5.1 is shipped with support for 20 independent Internet radio stations broadcasting in Europe (Belgium, France, UK, Norway and Portugal) and North America (USA and Mexico) and support for 3 languages: Brazilian Portugese, Czech language and Serbian.
I am the upstream developer of girl, see https://git.gnome.org/browse/girl/log/ for the upstream development in git.
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yaneti@declera.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com
--- Comment #5 from Antonio Trande anto.trande@gmail.com --- - Various basic macros are already defined on RPM, these lines are redundant
%define name girl %define ver 0.5.1 %define rel 1 %define prefix %{_usr} %define docdir %{_defaultdocdir}
BuildRoot: %{_tmppath}/%{name}-root
mkdir -p %{buildroot}%{_bindir}
%defattr (-,root,root)
%clean rm -rf %{buildroot}
- The %makeinstall macro should not be used. See http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_ma...
For infos see these guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines and http://fedoraproject.org/wiki/How_to_create_an_RPM_package
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #6 from Antonio Trande anto.trande@gmail.com --- Just discovered, your software needs of codes unavailable in Fedora; i suggest you to continue this review on RPMFusion.
http://rpmfusion.org/Contributors#Becoming_a_RPM_Fusion_contributor
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #7 from Ole Aamot oka@oka.no --- I have fixed the issues with the RPM spec file in girl 0.6.0.
See http://www.ping.uio.no/~oka/src/girl/girl.spec and http://www.ping.uio.no/~oka/src/girl/girl-0.6.0-1.src.rpm
The latest koji build of Girl is available in http://koji.fedoraproject.org/koji/taskinfo?taskID=8315289
Girl depends on Totem as an external audio helper and launches Totem to play audio in Fedora 21.
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #8 from Antonio Trande anto.trande@gmail.com --- (In reply to Ole Aamot from comment #7)
I have fixed the issues with the RPM spec file in girl 0.6.0.
See http://www.ping.uio.no/~oka/src/girl/girl.spec and http://www.ping.uio.no/~oka/src/girl/girl-0.6.0-1.src.rpm
The latest koji build of Girl is available in http://koji.fedoraproject.org/koji/taskinfo?taskID=8315289
Girl depends on Totem as an external audio helper and launches Totem to play audio in Fedora 21.
Girl needs GStreamer-plugins (which are not in Fedora) to decode audio. Is it right?
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #9 from Ole Aamot oka@oka.no --- girl 0.8.0 ("Cinnamon Girl") is now available.
http://girl.software/girl.spec http://girl.software/girl-0.8.0-1.src.rpm http://girl.software/girl-0.8.0-1.x86_64.rpm
Audio playback depends on Totem and audio recording depends on streamripper.
The 36 radio stations supported in girl 0.8.0 are streaming in either MP3, AAC, or OGG. If the codec is supported in Totem, Totem will playback the station. If the codec is not supported in Totem, Totem provide the error message.
I am not going to exclude radio stations in girl/src/stations.xml if that is required to be included in Fedora 21.
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@gmx.net
--- Comment #10 from Michael Schwendt bugs.michael@gmx.net --- A brief look:
Requires: gtk2 >= 2.24.24 Requires: libgnome >= 2.32.1 Requires: libxml2 >= 2.9.1 Requires: gnome-vfs2 >= 2.24.4 Requires: libgnomeui >= 2.24.5 Requires: totem >= 3.10.1 Requires: streamripper >= 1.64.6
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
That section is not specific to library packages.
%install
%make_install make DESTDIR=%{buildroot} install
Double-check this %install section, please. Run "rpm -E %make_install" as a hint.
%lang(cs) %lang(pt_BR)
No-op and hence should be deleted.
%{_datadir}/girl/girl-0.1.dtd
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner... https://fedoraproject.org/wiki/Packaging:UnownedDirectories
%{_datadir}/appdata/girl.appdata.xml
https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files https://fedoraproject.org/wiki/Packaging:AppData
Note the bottom about validating the file.
%{_datadir}/applications/girl.desktop
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usa...
%{_datadir}/icons/hicolor/16x16/apps/girl.png %{_datadir}/icons/hicolor/22x22/apps/girl.png %{_datadir}/icons/hicolor/24x24/apps/girl.png %{_datadir}/icons/hicolor/32x32/apps/girl.png %{_datadir}/icons/hicolor/48x48/apps/girl.png %{_datadir}/icons/hicolor/256x256/apps/girl.png
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
%{_mandir}/man1/girl.1.gz
A growing number of reviewers suggest replacing the '.gz' with '*', because that makes it possible to disable/change/customise the compression that is applied by rpmbuild on-the-fly.
%{_mandir}/man1/girl.1*
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #11 from Ole Aamot oka@oka.no --- girl 1.0.0 ("Fenchurch") is now available.
http://girl.software/girl.spec http://girl.software/girl-1.0.0-1.src.rpm http://girl.software/girl-1.0.0-1.x86_64.rpm
What further steps are required for inclusion of girl in Fedora 21?
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
--- Comment #12 from Antonio Trande anto.trande@gmail.com --- (In reply to Ole Aamot from comment #9)
girl 0.8.0 ("Cinnamon Girl") is now available.
http://girl.software/girl.spec http://girl.software/girl-0.8.0-1.src.rpm http://girl.software/girl-0.8.0-1.x86_64.rpm
Audio playback depends on Totem and audio recording depends on streamripper.
$ yum info streamripper Available Packages Name : streamripper Arch : x86_64 Version : 1.64.6 Release : 5.fc21 Size : 97 k Repo : rpmfusion-free/21/x86_64 <--- Summary : Shoutcast and icecast compatible streams recorder URL : http://streamripper.sourceforge.net/ License : GPLv2
The 36 radio stations supported in girl 0.8.0 are streaming in either MP3, AAC, or OGG. If the codec is supported in Totem, Totem will playback the station. If the codec is not supported in Totem, Totem provide the error message.
I am not going to exclude radio stations in girl/src/stations.xml if that is required to be included in Fedora 21.
Propose 'girl' in the RPMFusion is not a bad idea. I myself can review your package.
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Ole Aamot oka@oka.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2015-01-03 20:44:25
--- Comment #13 from Ole Aamot oka@oka.no --- I have proposed 'girl' in RPMFusion.
See https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Ole Aamot oka@oka.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |NEXTRELEASE
--- Comment #14 from Ole Aamot oka@oka.no --- Obsolete package. See bug #1517451
https://bugzilla.redhat.com/show_bug.cgi?id=1161834
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|bugs.michael@gmx.net | Resolution|NEXTRELEASE |DUPLICATE
--- Comment #15 from Michael Schwendt bugs.michael@gmx.net --- Modifying ancient tickets like that serves no purpose.
Usually, what is done in the case of a new review ticket is to close the old one as duplicate, so that one is linked and locatable easily.
*** This bug has been marked as a duplicate of bug 1517451 ***
package-review@lists.fedoraproject.org