[Bug 225851] New: Merge Review: gob2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225851

Summary: Merge Review: gob2
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: gob2

http://cvs.fedora.redhat.com/viewcvs/devel/gob2/
Initial Owner: [e-mail]

[Bug 225851] Merge Review: gob2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225851

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 225851] Merge Review: gob2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225851

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Miroslav Lichvar   2009-12-02 12:21:56 EDT ---
Review follows:

OK source files match upstream:
cced6d709df6fad3baf8831f027d62d5  gob2-2.0.16.tar.gz
BAD source contains full URL
- source should point to http://ftp.5z.com/pub/gob/gob2-2.0.16.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
- %makeinstall can be replaced with more correct
   make install DESTDIR=$RPM_BUILD>_ROOT
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license (GPLv2+).
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock.
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

[Bug 225851] Merge Review: gob2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225851

--- Comment #2 from Daniel Novotny   2009-12-03 06:53:21 EDT ---
so the only problem is the "Source:" URL.
fixed in rawhide and F-12
-built F12 release candidate gob2-2.0.16-5.fc12, rawhide gob2-2.0.16-4.fc13

[Bug 225851] Merge Review: gob2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225851

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |RAWHIDE
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Miroslav Lichvar   2009-12-03 07:01:51 EDT ---
Approved.