[Bug 714408] New: Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Summary: Review Request: tlomt-league-gothic-fonts - a sans
                    serif gothic typeface
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://www.kerneljack.com/rpms/tlomt-league-gothic-fonts.spec
SRPM URL:
http://www.kerneljack.com/rpms/tlomt-league-gothic-fonts-1.0-1.fc15.src.rpm
Description: League Gothic is a revival of an old classic, Alternate Gothic
No.1.
It was originally designed by Morris Fuller Benton for the American
Type Founders Company (ATF) in 1903. The company went bankrupt in 1993.
And since the original typeface was created before 1923, the typeface
is in the public domain. It is a sans serif gothic typeface

NOTE: This is my first package and I am seeking a sponsor. In addition, some
hosting space, perhaps on fedorapeople.org would be appreciated.

Thanks.

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Khusro Jaleel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Ryan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ryan  2011-06-26 12:48:26 EDT ---
I inspected the spec file, and it seems to match the guidelines listed:
http://fedoraproject.org/wiki/Simple_fonts_spec_template

it also passed rpmlint cleanly.

I would recommend publishing a koji scratch build.

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #2 from Kevin Fenzi  2011-07-02 10:11:29 EDT ---
I'd be happy to review this package and look at sponsoring you. ;)

Look for a full review hopefully later today.

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #3 from Kevin Fenzi  2011-07-02 11:56:39 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (OFL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
72b228695f1ad8ac0e3824a1e7edb313  league-gothic.zip
72b228695f1ad8ac0e3824a1e7edb313  ../SOURCES/league-gothic.zip
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues:

1. Not a blocker, but you might add to the description. Reading just what you
have
makes it sound like this is a public domain font from 1903, but in fact the
second
paragraph upstream says: "We decided to make our own version, and contribute 
it to the Open Source Type Movement. It’s free, not only in price, but in
freedom"
So, perhaps a note that this is a version of that font?

2. Might ask upstream if they could include a copy of the OFL in their zip
file?
(Not a blocker, but nice to have).

3. rpmlint says:

tlomt-league-gothic-fonts.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Which can be ignored.

Fix up the description and I think we are good to go...

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #4 from Khusro Jaleel  2011-07-02 18:44:14 EDT ---
Thanks, Kevin. I have updated the description field now and uploaded a new
.src.rpm with an incremented Release tag of "2". You will find it below:

SRPM: http://kerneljack.com/rpms/tlomt-league-gothic-fonts-1.0-2.fc15.src.rpm
SPEC: http://kerneljack.com/rpms/tlomt-league-gothic-fonts.spec
Koji scratch build against Rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3176288

Please let me know if this is ok, thanks again for the help. I'm going to
package up another font soon!

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Kevin Fenzi  2011-07-03 10:02:44 EDT ---
Looks good. This package is APPROVED.

I will go ahead and sponsor you. Can you confirm your fedora account system
account name for me in email or irc (my nick on irc is 'nirik') ?

Please don't hesitate to ask questions and I will assist you as best I can.
After I sponsor you in the account system you can continue the process from:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source...

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Khusro Jaleel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #6 from Jon Ciesla  2011-07-04 20:07:42 EDT ---
Please complete a SCM request if setting the fedora-cvs flag.

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Khusro Jaleel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Khusro Jaleel  2011-07-05 00:57:25 EDT ---
New Package SCM Request
=======================
Package Name: tlomt-league-gothic-fonts
Short Description: League Gothic is a revival of an old classic, Alternate
Gothic
No.1.
Owners: kjaleel
Branches: f14 f15 el5 el6
InitialCC: fonts-sig

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #8 from Jon Ciesla  2011-07-05 03:32:02 EDT ---
Git done (by process-git-requests).

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Paul Flo Williams  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Paul Flo Williams  2011-11-30 02:42:47 EST ---
Khusro, could you please complete some builds of this and push them as updates
so this review gets closed off?

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #10 from Khusro Jaleel  2011-12-05 05:22:37 EST ---
Hi Paul, apologies for the late reply here, I was hoping to find some time to
re-read the package review guidelines document to find out what I was missing
before asking you, but I haven't had much time to do so.

As far as I was aware, I have already created the package and done a koji
build, etc and the package is now part of F16, so I am not sure what is left
remaining to be done? Could you please let me know?

Thanks.

[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714408

Paul Flo Williams  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |ERRATA
        Last Closed|                            |2011-12-05 13:25:06

--- Comment #11 from Paul Flo Williams  2011-12-05 13:25:06 EST ---
OK, I can see the build for F16, but Bodhi isn't showing any updates. Closing
now.