[Bug 1480961] New: Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Bug ID: 1480961
           Summary: Review Request: golang-github-howeyc-fsnotify - File
                    change notification Go language Binding
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...

Description: File change notification Go language Binding

Fedora Account System Username: mosquito

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1465889
                   |                            |(DeepinDEPackageReview)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1476583

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476583
[Bug 1476583] Review Request: startdde - Starter of deepin desktop
environment

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
rpmlint:
> golang-github-howeyc-fsnotify.src: W: summary-ended-with-dot C File change notification Go language Binding.
> golang-github-howeyc-fsnotify.src: W: invalid-license fsnotify Authors

It actually is "BSD 3-clause": License: BSD.

I'm very green with go packaging, but afaict the guidelines in
https://fedoraproject.org/wiki/PackagingDrafts/Go are all followed.

+ latest version
+ package name is OK
+ license is acceptable
- license is specified incorrectly, please fix when importing
+ builds and installs OK
+ Go guideline draft is followed
+ %check does not pass but is commented out
+ BR/R/P look OK

Wouldn't it be better to change the %gotest line to something like:
{ %gotest %{import_path} } || :
so that the failures show up in the logs and it's known what needs fixing?

Package is APPROVED. Please fix license tag when uploading.

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1476583                     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476583
[Bug 1476583] Review Request: startdde - Starter of deepin desktop
environment

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|                            |golang-github-howeyc-fsnoti
                   |                            |fy

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-07-22 09:31:19

--- Comment #4 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.