Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
Summary: Review Request: perl-Mozilla-LDAP Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rmeggins@redhat.com QAContact: fedora-package-review@redhat.com CC: jwilson@redhat.com
This perl module is a wrapper around the Mozilla LDAP C SDK. This package is necessary for Fedora Directory Server (not for core server functionality, but for management scripts) and other applications that require the use of the Mozilla LDAP C SDK from perl applications. The reason why we must use this module and not the more common Net::LDAP module is because we require the use of Mozilla NSS for crypto, and Net::LDAP uses openssl (via Net::SSLeay).
SPEC: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/perl-Mozilla-LDAP.spec SRPM: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/perl-Mozilla-LDAP-1.5-6.src.rpm Sources: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/perl-mozldap-1.5.tar.gz ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/Makefile.PL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
rmeggins@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perldap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
------- Additional Comments From dennis@ausil.us 2007-01-09 16:34 EST ------- a couple of notes
this builds and works fine on sparc not sure why its ExclusiveArch i386 x86_64
the Requires on nss nspr and mozldap are unneccesary rpm has the smarts to know that
source needs to be a full url in spec file
please add disttag to the release
rpmlint says E: perl-Mozilla-LDAP useless-explicit-provides perl(Mozilla::LDAP::Entry) E: perl-Mozilla-LDAP non-standard-executable-perm /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/API.so 0555 E: perl-Mozilla-LDAP zero-length /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/API.bs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |dennis@ausil.us
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
Bug 219869 depends on bug 196401, which changed state.
Bug 196401 Summary: Review Request: mozldap https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196401
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
------- Additional Comments From rmeggins@redhat.com 2007-01-10 16:00 EST ------- Thanks Dennis. Here are the new files: SPEC URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP.spec SRPM URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP-1.5-7.src.rpm Sources: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-mozldap-1.5.tar.gz ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/Makefile.PL.rpm
I made a separate Makefile.PL.rpm so as not to conflict with the other Makefile.PL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
------- Additional Comments From dennis@ausil.us 2007-01-10 17:31 EST ------- Created an attachment (id=145292) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=145292&action=vie...) updated spec file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
------- Additional Comments From dennis@ausil.us 2007-01-10 17:32 EST ------- Two small issues include MPL-1.1.txt RELEASE in %doc and change the license field to MPL as thats what it seems to be licensed under.
package meets naming and packaging guidelines. specfile is properly named, is cleanly written and uses macros consistently. dist tag is present. build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) license is open source-compatible. MPL License text included in package. source files match upstream: 136f74d7649ada77cdf7657bb01a165f perl-mozldap-1.5.tar.gz 136f74d7649ada77cdf7657bb01a165f ../SOURCES/perl-mozldap-1.5.tar.gz latest version is being packaged. BuildRequires are proper. package builds in mock ( on FC-6 ). rpmlint is silent. final provides and requires are sane: no shared libraries are present. package is not relocatable. owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. file permissions are appropriate. %clean is present.
no scriptlets present. code, not content. documentation is small, so no -docs subpackage is necessary. %docs are not necessary for the proper functioning of the package. no headers. no pkgconfig files. no libtool .la droppings. not a GUI app. not a web app.
APPROVED using the attached spec file which fixes the issues
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
rmeggins@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From rmeggins@redhat.com 2007-01-10 18:57 EST ------- Thanks Dennis. Here are the final versions for inclusion into Fedora: SPEC URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP.spec SRPM URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP-1.5-8.src.rpm Sources: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-mozldap-1.5.tar.gz ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/Makefile.PL.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
johan-fedora@deds.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |163779
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Mozilla-LDAP Alias: perldap
https://bugzilla.redhat.com/show_bug.cgi?id=219869
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name BugsThisDependsOn|163779 | OtherBugsDependingO| |163779 nThis| |
------- Additional Comments From opensource@till.name 2007-09-01 09:37 EST ------- FE-ACCEPT should be blocked, not being depended on.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla