[Bug 2184720] New: Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Bug ID: 2184720
           Summary: Review Request: rust-gdk4-x11-sys - FFI bindings of
                    GDK4 X11
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-gdk4-x11-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-x11-sys-0.6.3-1.fc39.src.rpm
Description: FFI bindings of GDK4 X11.
Fedora Account System Username: kalev

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=99556102

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2184723

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2184723
[Bug 2184723] Review Request: rust-gdk4-x11 - Rust bindings of the GDK4 X11
library

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/gd
                   |                            |k4-x11-sys

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745873
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+
             Status|NEW                         |POST

--- Comment #2 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests for gtk-rs projects are
known to be broken)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I assume that you created a rust2rpm.conf file to add BuildRequires / Requires
to the respective subpackages? Make sure to also import that.

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

--- Comment #3 from Kalev Lember  ---
Thanks for the review! Yes, I created a rust2rpm.conf and have it in local git.

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

--- Comment #4 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-gdk4-x11-sys

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2023-4464813aab has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4464813aab

[Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11

https://bugzilla.redhat.com/show_bug.cgi?id=2184720

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-04-21 20:37:10

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-4464813aab has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.