Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225645
Summary: Merge Review: cleanfeed Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: stransky@redhat.com
Fedora Merge Review: cleanfeed
http://cvs.fedora.redhat.com/viewcvs/devel/cleanfeed/ Initial Owner: stransky@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: cleanfeed
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225645
------- Additional Comments From rafalzaq@gmail.com 2007-02-25 17:51 EST ------- Needs work: * Source 0 is not available (ftp://ftp.exit109.com/users/jeremy/cleanfeed-0.95.7b.tar.gz) * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Spec file: some paths are not replaced with RPM macros * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Each %files section should have a %defattr line (wiki: Packaging/ReviewGuidelines) * Some files (CHANGES & README) should be in %doc
rpmlint output: Source RPM: W: cleanfeed summary-ended-with-dot A spam filter for Usenet news servers. W: cleanfeed invalid-license distributable W: cleanfeed no-url-tag E: cleanfeed hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/news/bin/filter E: cleanfeed hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/news/bin/filter/filter_innd.pl E: cleanfeed hardcoded-library-path in /usr/lib/news/bin/filter E: cleanfeed hardcoded-library-path in /usr/lib/news/bin/filter/filter_innd.pl W: cleanfeed no-%build-section
rpmlint of cleanfeed: W: cleanfeed summary-ended-with-dot A spam filter for Usenet news servers. W: cleanfeed invalid-license distributable W: cleanfeed no-url-tag E: cleanfeed only-non-binary-in-usr-lib W: cleanfeed conffile-without-noreplace-flag /etc/news/cleanfeed.conf E: cleanfeed non-readable /usr/lib/news/bin/filter/filter_innd.pl 0750 E: cleanfeed non-standard-executable-perm /usr/lib/news/bin/filter/filter_innd.pl 0750
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225645
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |odvorace@redhat.com, | |rrakus@redhat.com, | |tomspur@fedoraproject.org
--- Comment #2 from Thomas Spura tomspur@fedoraproject.org 2010-07-18 19:01:55 EDT --- (Adding all current maintainers)
Any progress here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225645
Roman Rakus rrakus@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #3 from Roman Rakus rrakus@redhat.com 2010-07-23 11:00:22 EDT --- cleanfeed-20020501-4_fc14 built. What about this one?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225645
Lukáš Nykrýn lnykryn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lnykryn@redhat.com AssignedTo|nobody@fedoraproject.org |lnykryn@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225645
Lukáš Nykrýn lnykryn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
--- Comment #4 from Lukáš Nykrýn lnykryn@redhat.com 2011-08-17 05:53:22 EDT --- Checked git commit: a79564bb2bc60af43dde6748eafb23d853f80bde
YES source files match upstream YES package meets naming and versioning guidelines. YES specfile is properly named, is cleanly written and uses macros consistently YES dist tag is present YES clean section and buildroot present YES license field matches the actual license YES license is open source-compatible YES License text included in package YES latest version is being packaged N/A BuildRequires are proper N/A compiler flags are appropriate YES package builds in mock (Rawhide/x86_64) N/A debuginfo package looks complete YES rpmlint is silent YES final provides and requires look sane -- dependence on perl is added automatically, but maybe it would by good to define it explicitly N/A %check is present and all tests pass N/A no shared libraries are added to the regular linker search paths YES owns the directories it creates YES doesn't own any directories it shouldn't YES no duplicates in %files N/A scriptlets must be sane YES code, not content N/A large documentation files must go in a -doc subpackage YES %docs are not necessary for the proper functioning of the package YES no headers YES no pkgconfig files YES no libtool .la droppings. YES not a GUI app.
Additional comments: User news is not by default in system, so it use root, I don't know if it is desired behavior.
package-review@lists.fedoraproject.org