https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Bug ID: 1260575 Summary: Review Request: python-ordered-set - A Custom MutableSet that remembers its order Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: msuchy@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://miroslav.suchy.cz/fedora/python-ordered-set.spec SRPM URL: http://miroslav.suchy.cz/fedora/python-ordered-set-1.3.1-1.fc22.src.rpm Description: An OrderedSet is a custom MutableSet that remembers its order, so that every entry has an index that can be looked up.
Fedora Account System Username: msuchy
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1219288
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1219288 [Bug 1219288] Review Request: python-marshmallow - Python library for converting complex datatypes to and from primitive types
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Valentin Gologuzov vgologuz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vgologuz@redhat.com Assignee|nobody@fedoraproject.org |vgologuz@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #1 from Valentin Gologuzov vgologuz@redhat.com --- Issues ====== [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.4/site- packages/__pycache__(python3-pytest, python3-path, python3-decorator, python3-six, python3-libs, python3-pytest-cov, python3-setuptools)
>> See: https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
>> Consider using archive from github as Source0, it contains license file
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/vgologuz/1260575-python-ordered- set/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.4/site- packages/__pycache__(python3-pytest, python3-path, python3-decorator, python3-six, python3-libs, python3-pytest-cov, python3-setuptools) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -ordered-set [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-ordered-set-1.3.1-1.fc22.noarch.rpm python3-ordered-set-1.3.1-1.fc22.noarch.rpm python-ordered-set-1.3.1-1.fc22.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python3-ordered-set (rpmlib, GLIBC filtered): python(abi)
python-ordered-set (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-ordered-set: python3-ordered-set
python-ordered-set: python-ordered-set
Source checksums ---------------- https://pypi.python.org/packages/source/o/ordered-set/ordered-set-1.3.1.tar.... : CHECKSUM(SHA256) this package : bf3ae1ebf12e6fec255cf8bf7e40e3c78bc0fc3d87dcb5a1d71765d504f7918b CHECKSUM(SHA256) upstream package : bf3ae1ebf12e6fec255cf8bf7e40e3c78bc0fc3d87dcb5a1d71765d504f7918b
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1260575 Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #2 from Miroslav Suchý msuchy@redhat.com --- Spec URL: http://miroslav.suchy.cz/fedora/python-ordered-set.spec SRPM URL: http://miroslav.suchy.cz/fedora/python-ordered-set-1.3.1-3.fc22.src.rpm
/usr/lib/python3.4/site-packages/__pycache__ is not owned any more
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
I prefer using PyPi archive. I reported this to upstream. https://github.com/LuminosoInsight/ordered-set/pull/9
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Valentin Gologuzov vgologuz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Valentin Gologuzov vgologuz@redhat.com --- Ok, now it looks fine. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Miroslav Suchý msuchy@redhat.com --- New Package SCM Request ======================= Package Name: python-ordered-set Upstream URL: https://github.com/LuminosoInsight/ordered-set Owners: msuchy Branches: f21 f22 f23 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- WARNING: No description provided.
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Miroslav Suchý msuchy@redhat.com --- New Package SCM Request ======================= Package Name: python-ordered-set Short Description: A Custom MutableSet that remembers its order Upstream URL: https://github.com/LuminosoInsight/ordered-set Owners: msuchy Branches: f21 f22 f23 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15485
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-09-09 12:46:22
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15486
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords| |Reopened
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-ordered-set'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15486
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-ordered-set'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15485
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |1.3.1-3.fc23 Resolution|--- |NEXTRELEASE Last Closed|2015-09-09 12:46:22 |2015-09-18 14:30:38
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #13 from Miroslav Suchý msuchy@redhat.com --- Package Change Request ====================== Package Name: python-ordered-set New Branches: epel7, el6 Owners: msuchy InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.3.1-3.fc23 |1.3.1-3.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #15 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8187
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8188
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |---
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-ordered-set' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8187
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-ordered-set' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8188
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2015-09-18 14:30:38 |2015-10-28 12:26:06
https://bugzilla.redhat.com/show_bug.cgi?id=1260575
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- python-ordered-set-1.3.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org