[Bug 1489494] New: Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Bug ID: 1489494
           Summary: Review Request: mock-core-configs - Mock core config
                    files basic chroots
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://miroslav.suchy.cz/fedora/mock-core-configs.spec
SRPM URL: http://miroslav.suchy.cz/fedora/mock-core-configs-27.1-1.fc26.src.rpm
Description: Config files which allow you to create chroots for:
 * Fedora
 * Epel
 * Mageia
 * Custom chroot

Fedora Account System Username: msuchy

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Sergio Monteiro Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sergio Monteiro Basto  ---
hawkey was retired in F26 ! in my f25 run [1], give me x86_64 , why not use
`uname -m` ?

[1]
python3 -c "import dnf.rpm; import hawkey;
print(dnf.rpm.basearch(hawkey.detect_arch()))"

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #3 from Neal Gompa  ---
(In reply to Sergio Monteiro Basto from comment #1)
> hawkey was retired in F26 ! in my f25 run [1], give me x86_64 , why not use
> `uname -m` ?
>
> [1]
> python3 -c "import dnf.rpm; import hawkey;
> print(dnf.rpm.basearch(hawkey.detect_arch()))"

libdnf provides the Hawkey Python API. The Hawkey C API was removed.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #4 from Miroslav Suchý  ---
Yes. There is python3-hawkey, which in past used hawkey C API, but now it uses
libdnf. DNF team just decided that it is not needed to change the python name.
The functionality stays the same.
> why not use `uname -m`

because I want the get the same string as DNF use internally. And I do not want
to be surprised on some secondary architectures where it may or not return
slightly different results.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #5 from Igor Gnatenko  ---
Please, don't run dnf/rpm/libdnf from scriptlet. It's worst thing ever!

Also don't use hawkey directly, it will be retired soon-ish.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #6 from Miroslav Suchý  ---
> dnf/rpm/libdnf from scriptlet. It's worst thing ever!

I agree with dnf/rpm. Can you elaborate why not libdnf? Especially this 
  import hawkey; print(dnf.rpm.basearch(hawkey.detect_arch())
which does not touch/need transaction?

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #7 from Miroslav Suchý  ---
@Neal ping. Any progress?

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #8 from Neal Gompa  ---
> Source:		%{name}-%{version}.tar.gz

Change this to the URL, and then I will okay this.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #9 from Miroslav Suchý  ---
Sigh. You are cruel. :)

Spec URL: http://miroslav.suchy.cz/fedora/mock-core-configs.spec
SRPM URL: http://miroslav.suchy.cz/fedora/mock-core-configs-27.2-1.fc26.src.rpm

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #10 from Neal Gompa  ---
Now you know my pain. :)

PACKAGE APPROVED.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mock-core-configs. You may commit to the
branch "f27" in about 10 minutes.

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

https://bugzilla.redhat.com/show_bug.cgi?id=1489494

Sergio Monteiro Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2017-10-08 14:28:34

--- Comment #12 from Sergio Monteiro Basto  ---
Fixed , package are in stable of all branches [1] .

Thanks.

[1]
https://bodhi.fedoraproject.org/updates/?packages=mock-core-configs