[Bug 901594] New: Review Request: php-password_compat - PHP password_* function for 5.3 and 5.4 - package-review

List overview All Threads
Download

newer

[Bug 901594] New: Review Request: php-password_compat - PHP password_* function for 5.3 and 5.4

older

[Bug 1011718] New: Review Request:...

[Bug 824218] New: Review Request:...

Red Hat Bugzilla

18 Jan 2013 18 Jan '13

9:34 a.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Bug ID: 901594 Summary: Review Request: php-password_compat - PHP password_* function for 5.3 and 5.4 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: johan@x-tnd.be

Spec URL: http://odysseus.x-tnd.be/fedora/php-password_compat/php-password_compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password_compat/php-password_compat-1.0.... Description: PHP password_* function for 5.3 and 5.4 Fedora Account System Username: trasher

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=60qXD6ERYl&a=cc_unsubscribe

Show replies by thread

Red Hat Bugzilla

18 Jan 18 Jan

10 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Johan Cwiklinski johan@x-tnd.be changed:

--- Comment #1 from Johan Cwiklinski johan@x-tnd.be --- I did not pay attention I mixed "-" and "_" in the package name. Here are new URLs: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0....

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PdDqu1acvt&a=cc_unsubscribe

Red Hat Bugzilla

21 Jan 21 Jan

6:20 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 684250 --> https://bugzilla.redhat.com/attachment.cgi?id=684250&action=edit phpci.log

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TrtUEb79LA&a=cc_unsubscribe

Red Hat Bugzilla

6:21 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Remi Collet fedora@famillecollet.com changed:

--- Comment #3 from Remi Collet fedora@famillecollet.com --- Created attachment 684251 --> https://bugzilla.redhat.com/attachment.cgi?id=684251&action=edit php-password-compat-review.txt

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wt6werQPVA&a=cc_unsubscribe

Red Hat Bugzilla

6:22 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

--- Comment #4 from Remi Collet fedora@famillecollet.com --- [!]: Run phpci static analyze on all php files. phpci reports REQUIRED PHP 5.5.0-dev (MIN) which is, of course a false positive. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the Could be droped as other EL-5 stuff not present [!]: Description "PHP password_* function for 5.3 and 5.4" probably "PHP" missing" [!]: Comment in %check (not version 1.4.4) OK (30 tests, 30 assertions) [!]: test in PHP include_path Please move to /usr/share/tests/%{name} NB: need to own /usr/share/tests or require php-pear

Only the latest seems a blocker (for me, nothing in Guidelines about this)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AVRxFMEbNw&a=cc_unsubscribe

Red Hat Bugzilla

7:42 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #5 from Remi Collet fedora@famillecollet.com --- AS this packages requires php version 5.3.7, you could not target EPEL.

So, it will be cleaner to use, instead of php-common:

Requires: php(language) >= 5.3.7

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ve9e125zXc&a=cc_unsubscribe

Red Hat Bugzilla

28 Jan 28 Jan

12:25 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #6 from Johan Cwiklinski johan@x-tnd.be --- Thank you for the comments :)

Here is a new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0....

I should have fixed all mentioned points.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=30IveM84Yx&a=cc_unsubscribe

Red Hat Bugzilla

12:26 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Johan Cwiklinski johan@x-tnd.be changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6aXiIylsDp&a=cc_unsubscribe

Red Hat Bugzilla

12:35 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #7 from Johan Cwiklinski johan@x-tnd.be --- Gasp, I've missed licence modification... Here the new build:

Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0....

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WuJZoUgkr4&a=cc_unsubscribe

Red Hat Bugzilla

12:43 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #8 from Johan Cwiklinski johan@x-tnd.be --- Ooooooh. Sorry, I've made a mistake with another review I'm working on; this one did not have license issue :-/

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1YTNwGvosr&a=cc_unsubscribe

Red Hat Bugzilla

29 Jan 29 Jan

12:34 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #9 from Remi Collet fedora@famillecollet.com --- You need to own /usr/share/tests (or require php-pear)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GfR6txUSuv&a=cc_unsubscribe

Red Hat Bugzilla

1:15 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #10 from Johan Cwiklinski johan@x-tnd.be --- New version : MIT license is back, test directory is now owned. Here the new version:

Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0....

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BEKAsoXoPP&a=cc_unsubscribe

Red Hat Bugzilla

1:36 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Remi Collet fedora@famillecollet.com changed:

--- Comment #11 from Remi Collet fedora@famillecollet.com --- [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the [x]: Description "PHP password_* function for 5.3 and 5.4" [x]: Comment in %check (not version 1.4.4) [x]: test in PHP include_path [x]: Requires: php(language) >= 5.3.7

All issues fixed No blocker

== APPROVED ===

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KKdlSsiyMU&a=cc_unsubscribe

Red Hat Bugzilla

1:49 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Johan Cwiklinski johan@x-tnd.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #12 from Johan Cwiklinski johan@x-tnd.be --- New Package SCM Request ======================= Package Name: php-password-compat Short Description: PHP password_* function for PHP 5.3 and 5.4 Owners: trasher Branches: f17 f18 el6 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Icon53PFiC&a=cc_unsubscribe

Red Hat Bugzilla

2:01 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #13 from Johan Cwiklinski johan@x-tnd.be --- Hum... PHP in EL-6 is 5.3.3 (5.3.7 is required), so please do not create that branch. The modified SCM request:

New Package SCM Request ======================= Package Name: php-password-compat Short Description: PHP password_* function for PHP 5.3 and 5.4 Owners: trasher Branches: f17 f18 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tTDif7AqtY&a=cc_unsubscribe

Red Hat Bugzilla

6:02 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kbTbA2CBWB&a=cc_unsubscribe

Red Hat Bugzilla

30 Jan 30 Jan

2:17 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ns0S4NFbcj&a=cc_unsubscribe

Red Hat Bugzilla

2:17 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-password-compat-1.0.0-4.git58151cf.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-password-compat-1.0.0-4.git58151...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7i9OMJdOth&a=cc_unsubscribe

Red Hat Bugzilla

2:18 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-password-compat-1.0.0-4.git58151cf.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-password-compat-1.0.0-4.git58151...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7a8waXZmCb&a=cc_unsubscribe

Red Hat Bugzilla

1 Feb 1 Feb

10:42 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v75UCFqP6B&a=cc_unsubscribe

Red Hat Bugzilla

10:42 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-password-compat-1.0.0-4.git58151cf.fc17 has been pushed to the Fedora 17 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5z1EENYqie&a=cc_unsubscribe

Red Hat Bugzilla

11 Feb 11 Feb

11:12 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g7laa6eYPn&a=cc_unsubscribe

Red Hat Bugzilla

11:12 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-password-compat-1.0.0-4.git58151cf.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zil2W84vSp&a=cc_unsubscribe

Red Hat Bugzilla

11:12 p.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-password-compat-1.0.0-4.git58151cf.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ykPyn91Va1&a=cc_unsubscribe

Red Hat Bugzilla

6 Nov 6 Nov

11:46 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

https://bugzilla.redhat.com/show_bug.cgi?id=901594

Johan Cwiklinski johan@x-tnd.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?

--- Comment #20 from Johan Cwiklinski johan@x-tnd.be --- Package Change Request ====================== Package Name: php-password-compat New Branches: el6 Owners: trasher

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:48 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

https://bugzilla.redhat.com/show_bug.cgi?id=901594

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:48 a.m.

New subject: [Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #21 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4276

Age (days ago)

4568

Last active (days ago)

package-review@lists.fedoraproject.org

26 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla