[Bug 912596] New: Review Request: maven-shared-resources - A collection of templates that are specific to the Maven project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Bug ID: 912596 Summary: Review Request: maven-shared-resources - A collection of templates that are specific to the Maven project Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: puntogil@libero.it
Spec URL: http://gil.fedorapeople.org/maven-shared-resources.spec SRPM URL: http://gil.fedorapeople.org/maven-shared-resources-1-1.fc18.src.rpm Description: This is a collection of templates that are specific to the Maven project. They are probably not of interest to projects other than Apache Maven.
Fedora Account System Username: gil
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |912602
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mizdebsk@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING Assignee|nobody@fedoraproject.org |mizdebsk@redhat.com Flags|fedora-review? | Flags| |fedora-review+ Status|RELEASE_PENDING |POST
--- Comment #1 from Mikolaj Izdebski mizdebsk@redhat.com --- Package Review ==============
Key: [x] = Pass [-] = Not applicable
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces.
Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Bundled jar/class files should be removed before build
Maven: [x]: Pom files have correct add_maven_depmap call [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.)
Rpmlint ------- Checking: maven-shared-resources-1-1.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Approved.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |ASSIGNED Flags| |fedora-cvs?
--- Comment #2 from gil cattaneo puntogil@libero.it --- New Package SCM Request ======================= Package Name: maven-shared-resources Short Description: A collection of templates that are specific to the Maven project Owners: gil Branches: f18 f19 InitialCC: java-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- maven-shared-resources-1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/maven-shared-resources-1-1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- maven-shared-resources-1-1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Bug 912596 depends on bug 912602, which changed state.
Bug 912602 Summary: Review Request: maven-shared-components - Maven Shared Components Parent POM https://bugzilla.redhat.com/show_bug.cgi?id=912602
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|912602 |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-03-02 15:10:49
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- maven-shared-resources-1-1.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@redhat.com Blocks|652183 (FE-JAVASIG) |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla