Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gummi - A simple LaTeX editor
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Summary: Review Request: gummi - A simple LaTeX editor Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gummi.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gummi-0.4.2-1.fc11.src.rpm
Project URL: http://gummi.midnightcoding.org
Description: Gummi is a LaTeX editor written in the Python programming language using the PyGTK interface toolkit. It was designed with simplicity and the novice user in mind, but also offers features that speak to the more advanced user.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786646
rpmlint output: [fab@laptop016 SRPMS]$ rpmlint gummi-0.4.2-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@laptop016 noarch]$ rpmlint gummi-0.4.2-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@fedoraproject.org AssignedTo|nobody@fedoraproject.org |tomspur@fedoraproject.org Flag| |fedora-review?
--- Comment #1 from Thomas Spura tomspur@fedoraproject.org 2009-11-03 18:20:47 EDT --- Why do you have: BuildRequires: gtk2-devel BuildRequires: gnome-python2 BuildRequires: gnome-python2-extras BuildRequires: pango BuildRequires: pygtksourceview
It builds without them: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786917
Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: [] devel/i386 [] devel/x86_64 [] F11/i386 [x] F11/x86_64 [x] Rpmlint output: $ rpmlint gummi.spec gummi-0.4.2-1.fc11.src.rpm noarch/gummi-0.4.2-1.fc11.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: MIT
______________________________
[!] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
The license file is in /gummi/docs/LICENSE, but not in %doc
______________________________
[x] Spec file is legible and written in American English. [?] Sources used to build the package matches the upstream source, as provided in the spec URL. Upstream source: e71a4c66ed3eed6e8072033f67decf13 Build source: e71a4c66ed3eed6e8072033f67decf13 [x] Package is not known to require ExcludeArch
_______________________________
[!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
See above. _______________________________
[-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [x] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Package functions as described (no hardware to test with). [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct.
########################
Issues: - License file not in %doc - too much BR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cwickert@fedoraproject.org
--- Comment #2 from Christoph Wickert cwickert@fedoraproject.org 2009-11-03 18:51:25 EDT --- Please add "Publishing" as additional category during desktop-file-install to allow nested menus.
While we are at it: Please finish bug 510376 before requesting new reviews.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #3 from Jussi Lehtola jussi.lehtola@iki.fi 2009-11-04 14:52:39 EDT --- While you're at it, replace Requires: texlive-latex with Requires: tex(latex) which is more general.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
--- Comment #4 from Christoph Wickert cwickert@fedoraproject.org 2009-11-04 15:37:39 EDT --- Last but not least change the RPM group to ether Applications/Editors or Applications/Publishing (I prefer the latter).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
--- Comment #5 from Fabian Affolter fabian@bernewireless.net 2009-12-20 15:52:54 EDT --- Thanks for your comments guys
Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gummi.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gummi-0.4.2-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Thomas Spura tomspur@fedoraproject.org 2009-12-21 19:27:56 EDT --- Status update: - BR reduced \ - License is there > (comment #1) - Requires: tex(latex) (comment #3) - Group changed to App/Publ (comment #4) - Publishing also in desktop-file-install (comment #2) ( bug 510376 also close to finished ;) )
####################
All issues fixed.
####################
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Fabian Affolter fabian@bernewireless.net 2009-12-23 06:23:03 EDT --- New Package CVS Request ======================= Package Name: gummi Short Description: A simple LaTeX editor Owners: fab Branches: F-11 F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Dennis Gilmore dennis@ausil.us 2009-12-23 14:47:59 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-12-24 15:35:11 EDT --- gummi-0.4.2-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gummi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13599
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-12-24 15:38:45 EDT --- gummi-0.4.2-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gummi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13631
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-01-01 22:32:21 EDT --- gummi-0.4.2-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.4.2-2.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-01-01 22:39:25 EDT --- gummi-0.4.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532813
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.2-2.fc12 |0.4.2-2.fc11
package-review@lists.fedoraproject.org