[Bug 226003] New: Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

Summary: Merge Review: libexif
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libexif

http://cvs.fedora.redhat.com/viewcvs/devel/libexif/
Initial Owner: [e-mail]

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-04 13:12 EST -------
Taking for review.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]       |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-04 14:30 EST -------
First issues and suggestions, in random order:

* Several patch files in CVS are not used. Please remove.
* change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* The resolved URL for Source0
(http://umn.dl.sourceforge.net/sourceforge/libexif/lixexif-0.6.13.tar.bz2) gives
me a 404 HTTP error.
* The AUTHORS files shipped in the RPM is empty.
* Change the Requires line of -devel to %{name} = %{version}-%{release}
* Devel package description says that there are also static packages. There are not.
* Don't use %makeinstall. Use make DESTDIR=$RPM_BUILD_ROOT install.
* Documents are installed into two different directories, /usr/share/doc/libexif
(in libexif-devel) and /usr/share/doc/libexif-%{version} (in libexif). Make them
one.
* Make -devel require pkgconfig, as it includes *.pc files.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]          |[e-mail]
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-02-04 22:08 EST -------
Mostly fixed in libexif-0.6.13-3.fc7, except for

* The resolved URL for Source0
(http://umn.dl.sourceforge.net/sourceforge/libexif/lixexif-0.6.13.tar.bz2) gives
me a 404 HTTP error.

Can't give a working source url for sourceforge-hosted projects.

* Documents are installed into two different directories, /usr/share/doc/libexif
(in libexif-devel) and /usr/share/doc/libexif-%{version} (in libexif). Make them
one.

The api docs are now in /usr/share/doc/libexif-devel-0.6.13, which is quite
common for -devel packages.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

------- Additional Comments From [e-mail]  2007-02-04 22:21 EST -------
I also added a fix for multilib conflicts due to generated docs.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]       |[e-mail]
               Flag|fedora-review?              |

------- Additional Comments From [e-mail]  2007-02-05 08:12 EST -------
I believe I can't finish this review, not understanding multilib issues well
enough. Leaving for someone else to take.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

------- Additional Comments From [e-mail]  2007-02-06 18:43 EST -------
> Can't give a working source url for sourceforge-hosted projects.

It used to be easier a few months ago.
The generic URL is

http://dl.sf.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.*
  http://download.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.*

and used to point to a round-robin DNS mirroring system. However,
nowadays the system refuses to work and includes a host which
doesn't respond.

As a work-around, one can still use a prefix for a known mirror, e.g.

http://umn.dl.sf.net/libexif/libexif-0.6.13.tar.bz2
  http://us.dl.sf.net/libexif/libexif-0.6.13.tar.bz2
  http://osdn.dl.sf.net/libexif/libexif-0.6.13.tar.bz2
  http://mesh.dl.sf.net/libexif/libexif-0.6.13.tar.bz2

and so on.

* A different release of this library may need "BuildRequires: gettext"
or else would build without message object files. This version doesn't,
but the configure script searches for gettext.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-02-06 18:46 EST -------
APPROVED

(Cannot verify whether %doc files in multi-lib installations can
cause conflicts actually. In case such conflicts are common, perhaps
the packaging committee should discuss that a bit.)

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

------- Additional Comments From [e-mail]  2007-02-06 19:01 EST -------
(In reply to comment #6)
> http://dl.sf.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.*
>   http://download.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.*
>
> and used to point to a round-robin DNS mirroring system. However,
> nowadays the system refuses to work and includes a host which
> doesn't respond.

Generic SF.net URLs like http://downloads.sourceforge.net/%%7Bname%7D/... (note
"downloads", not "download") have worked well for me lately.

[Bug 226003] Merge Review: libexif

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libexif

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 20:41 EST -------
This review is done.