[Bug 432971] New: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=432971

Summary: Review Request: python-turboflot - A TurboGears widget
                    for Flot, a jQuery plotting library
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://hg.lewk.org/TurboFlot/raw-file/59d7c20ba8f2/python-turboflot.spec
SRPM URL: http://pypi.python.org/packages/2.5/T/TurboFlot/python-turboflot-0.0.5-1.fc8...
Description: 
A TurboGears widget for Flot, which is a pure Javascript plotting library for jQuery. It produces graphical plots of arbitrary datasets on-the-fly client-side.  The focus is on simple usage (all settings are optional), attractive looks and interactive features like zooming.

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-02-16 10:58 EST -------
rpmlint output:
python-turboflot.noarch: W: incoherent-version-in-changelog 0.0.4-1 0.0.5-1.fc8

I think this package requires TurboGears and simplejson, so add:
  Requires: TurboGears >= 1.0.3, python-simplejson >= ...
or something similar.

Source package do not match upstream and source URL is not complete!

May be there is a missing "." at end of description (just summary can't end with
".").

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

------- Additional Comments From [e-mail]  2008-02-16 11:02 EST -------
Package do not build in mock, add for example this:
BuildRequires:  python-setuptools >= 0.6c5

Error output:
+ /usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 2, in <module>
    from setuptools import setup, find_packages
ImportError: No module named setuptools
error: Bad exit status from /var/tmp/rpm-tmp.21399 (%build)

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

------- Additional Comments From [e-mail]  2008-02-17 12:36 EST -------
http://hg.lewk.org/TurboFlot/raw-file/836ad97edcc8/python-turboflot.spec
http://pypi.python.org/packages/2.5/T/TurboFlot/python-turboflot-0.0.5-2.fc8...

* Sat Feb 16 2008 Luke Macken  - 0.0.5-2
- Add TurboGears to BuildRequires and Requires
- Require python-simplejson
- Fix description
- Fix Source0

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

------- Additional Comments From [e-mail]  2008-02-17 13:39 EST -------
Source URL still do not match upstream!

- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this.

- It is nicer to use %{version} in Source URL. It is not required, so you can
leave it as is is you wish.

If you fix source, I can approve this package.

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

------- Additional Comments From [e-mail]  2008-02-17 14:26 EST -------
http://hg.lewk.org/TurboFlot/raw-file/9fb8a0f1bb73/python-turboflot.spec
http://pypi.python.org/packages/any/T/TurboFlot/python-turboflot-0.0.5-2.fc8...

I recreated the rpm with the upstream sources listed in Source0.  I also now use
%{version} in the Source0, and have modified the URL to point to the Python
Package Index, instead of my blog.

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-02-17 15:09 EST -------
Much better. :-)

APPROVED.

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-02-18 00:47 EST -------
Thanks for taking the time out to review, Jan :)

New Package CVS Request
=======================
Package Name: python-turboflot
Short Description: A TurboGears widget for Flot, a jQuery plotting library
Owners: lmacken
Branches: F-8 F-7 EL-5
Cvsextras Commits: Yes

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-02-18 12:37 EST -------
cvs done.

[Bug 432971] Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library

https://bugzilla.redhat.com/show_bug.cgi?id=432971

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-02-18 23:58 EST -------
Updates queued for F7/F8.  Thanks!