[Bug 1716196] New: Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Bug ID: 1716196
           Summary: Review Request: msoffcrypto-tool - Python tool for
                    decrypting MS Office files with passwords or other
                    keys
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: All
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://labs.linuxnetz.de/bugzilla/msoffcrypto-tool.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/msoffcrypto-tool-4.10.0-1.src.rpm
Description: The msoffcrypto-tool (formerly ms-offcrypto-tool) is a Python tool
and library for decrypting encrypted Microsoft Office files with password,
intermediate key, or private key which generated its escrow key.
Fedora Account System Username: robert

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Robert Scheck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1547316

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1547316
[Bug 1547316] python-oletools-0.54.2b is available

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Robert-André Mauchin  ---
 - Simplify Source:

Source:        
https://github.com/nolze/msoffcrypto-tool/archive/v%%7Bversion%7D/%%7Bname%7...

- Not sure it is judicious to split the python lib into a separate subpackage?
If the package is only used as a binary you can safely put everything into the
main package.

Package approved. Please take into account the aforementioned remarks.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 45 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/msoffcrypto-tool/review-msoffcrypto-
     tool/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-msoffcrypto
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: msoffcrypto-tool-4.10.0-1.fc31.noarch.rpm
          python3-msoffcrypto-4.10.0-1.fc31.noarch.rpm
          msoffcrypto-tool-4.10.0-1.fc31.src.rpm
msoffcrypto-tool.noarch: W: spelling-error Summary(en_US) decrypting ->
decryption, encrypting
msoffcrypto-tool.noarch: W: spelling-error %description -l en_US offcrypto ->
offertory
msoffcrypto-tool.noarch: W: spelling-error %description -l en_US decrypting ->
decryption, encrypting
msoffcrypto-tool.noarch: W: no-manual-page-for-binary msoffcrypto-tool
python3-msoffcrypto.noarch: W: spelling-error Summary(en_US) decrypting ->
decryption, encrypting
python3-msoffcrypto.noarch: W: spelling-error %description -l en_US offcrypto
-> offertory
python3-msoffcrypto.noarch: W: spelling-error %description -l en_US decrypting
-> decryption, encrypting
python3-msoffcrypto.noarch: W: no-documentation
python3-msoffcrypto.noarch: E: zero-length
/usr/lib/python3.7/site-packages/msoffcrypto/method/xor_obfuscation.py
msoffcrypto-tool.src: W: spelling-error Summary(en_US) decrypting ->
decryption, encrypting
msoffcrypto-tool.src: W: spelling-error %description -l en_US offcrypto ->
offertory
msoffcrypto-tool.src: W: spelling-error %description -l en_US decrypting ->
decryption, encrypting
3 packages and 0 specfiles checked; 1 errors, 11 warnings.

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #2 from Robert Scheck  ---
First of all, thank you very much for the package review!

(In reply to Robert-André Mauchin from comment #1)
> Simplify Source:

Will fix that, thank you for the pointer.
> Not sure it is judicious to split the python lib into a separate
>
> subpackage? If the package is only used as a binary you can safely put
> everything into the main package.

What do you mean by that exactly? I've packaged msoffcrypto-tool because of the
python library (for python-oletools).

Is your proposal about including the msoffcrypto-tool into the python3
subpackage? Honestly, I've thought about it, but I'm not sure due to the
different package name for users…I've had the hope that the reviewer has a
stronger opinion on it than I ;-)

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #3 from Robert-André Mauchin  ---
(In reply to Robert Scheck from comment #2)
> First of all, thank you very much for the package review!
>
> (In reply to Robert-André Mauchin from comment #1)
> > Simplify Source:
>
> Will fix that, thank you for the pointer.
> > Not sure it is judicious to split the python lib into a separate
> >
> > subpackage? If the package is only used as a binary you can safely put
> > everything into the main package.
>
> What do you mean by that exactly? I've packaged msoffcrypto-tool because of
> the python library (for python-oletools).
>
> Is your proposal about including the msoffcrypto-tool into the python3
> subpackage? Honestly, I've thought about it, but I'm not sure due to the
> different package name for users…I've had the hope that the reviewer has a
> stronger opinion on it than I ;-)

If it is meant to be also used as a library, then keep it separate as you did.

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/msoffcrypto-tool

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2019-f103c26fd0 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f103c26fd0

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #6 from Fedora Update System  ---
FEDORA-2019-626464d044 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-626464d044

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #7 from Fedora Update System  ---
FEDORA-EPEL-2019-9535bd8e1a has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9535bd8e1a

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #8 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.fc30 has been pushed to the Fedora 30 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f103c26fd0

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #9 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.fc29 has been pushed to the Fedora 29 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-626464d044

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #10 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9535bd8e1a

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2019-06-26 04:06:53

--- Comment #11 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.fc30 has been pushed to the Fedora 30 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #12 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.fc29 has been pushed to the Fedora 29 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1716196] Review Request: msoffcrypto-tool - Python tool for decrypting MS Office files with passwords or other keys

https://bugzilla.redhat.com/show_bug.cgi?id=1716196

--- Comment #13 from Fedora Update System  ---
msoffcrypto-tool-4.10.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.