[Bug 1240116] New: Review Request: python-music21 - A toolkit for computational musicology
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Bug ID: 1240116 Summary: Review Request: python-music21 - A toolkit for computational musicology Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zbyszek@in.waw.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.0.5-1.fc23.src.rpm Fedora Account System Username: zbyszek Description: Music21 is a set of tools for helping scholars and other active listeners answer questions about music quickly and simply. It supports input of melodies in shorthand notation, printing of musical scores, etc.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Tests are currently failing and I'm ironing out various wrinkles.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- OK, tests now pass. Ready for review.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- http://koji.fedoraproject.org/koji/taskinfo?taskID=10310837
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Javier Peña jpena@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jpena@redhat.com
--- Comment #4 from Javier Peña jpena@redhat.com --- Please be aware that this is an informal review.
I have some comments about the spec file:
- I think it might be better to fetch the source code directly from GitHub or PyPi. I have been doing some tests using https://pypi.python.org/packages/source/m/%%7Bpypi_name%7D/%%7Bpypi_name%7D-... and it works fine for me (with some details, see below).
- At least on the PyPi source, license is included in a license.txt file together with the sources, so you can use "%license %{python2_sitelib}/music21/license.txt" with it.
- I see the sources include some external libraries in music.ext, and your spec file patches them manually using sed to avoid library bundling. Is there any open request upstream to avoid this?
- rpmlint complains twice about macro-in-comment, and mixed spaces and tabs in line 29.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Javier Peña from comment #4)
- I think it might be better to fetch the source code directly from GitHub
or PyPi. I have been doing some tests using https://pypi.python.org/packages/source/m/%%7Bpypi_name%7D/%%7Bpypi_name%7D- %{version}.tar.gz and it works fine for me (with some details, see below).
Pff, the situation is more complicated than that. I forgot to update the comment to describe how the tarball was generated. I made a pull request (https://github.com/cuthbertLab/music21/pull/100) and update the comments in the spec file.
- At least on the PyPi source, license is included in a license.txt file
together with the sources, so you can use "%license %{python2_sitelib}/music21/license.txt" with it.
- I see the sources include some external libraries in music.ext, and your
spec file patches them manually using sed to avoid library bundling. Is there any open request upstream to avoid this?
I haven't submitted my patches upstream yet. It would be nice if upstream refactored the code to try to import external modules first, before falling back to the bundled ones, so that unbundling could be done transparently... I wanted to wait until the review before I submit stuff upstream, in case other issues are found.
- rpmlint complains twice about macro-in-comment, and mixed spaces and tabs
in line 29.
Fixed!
Please be aware that this is an informal review.
Thanks for the comments.
Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.0.5-2.fc23.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.underwood@gmail.co | |m
--- Comment #6 from Jonathan Underwood jonathan.underwood@gmail.com --- I notice this package isn't following the usual python packaging practice of building the py2 and py2 packages in separate directories (by duplicating the unpacked tarball directory in %prep) - is there a reason for this?
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #7 from Jonathan Underwood jonathan.underwood@gmail.com --- (In reply to Jonathan Underwood from comment #6)
I notice this package isn't following the usual python packaging practice of building the py2 and py2 packages in separate directories (by duplicating
^^^^^^^^^^^^ py2 and py3
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- There's nothing "usual" about that practice. It was introduced only because 2to3 was used to modify sources during build, so the same directory could not be used for both 2.x and 3.x. But this package uses the same code for both versions, so there's no need to do that. Actually, almost no packages use 2to3 anymore and imho the part of the Packaging Guidelines that seems to encourage separate dirs should be mostly removed.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@gmail.com
--- Comment #9 from William Moreno williamjmorenor@gmail.com --- Please update the spec to last Python Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Python
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #10 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Pff, a lot of time passed.
Latest upstream version, with new style python2- and python3- subpackages:
Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.1.2-1.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |williamjmorenor@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #11 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- williamjmorenor's scratch build of python-music21-2.1.2-1.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11353240
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #12 from William Moreno williamjmorenor@gmail.com --- I can not build this app in rawhide, I did not cath the error, maybe it is a missing build requires, please check the build requieres and try a scrath build in koji for rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #13 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- zbyszek's scratch build of python-music21-2.1.2-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11526058
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #14 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
DEBUG util.py:377: error: unpacking of archive failed on file /builddir/build/SOURCES/music21-2.1.2.tar.gz;56143b90: cpio: read DEBUG util.py:377: error: /builddir/build/originals/python-music21-2.1.2-1.fc24.src.rpm cannot be installed
Looks like a problem with the build root or something.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #15 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- williamjmorenor's scratch build of python-music21-2.1.2-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11988928
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #16 from William Moreno williamjmorenor@gmail.com --- Rawhide build pased!
The spec look good I will run a full review of this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #17 from William Moreno williamjmorenor@gmail.com --- s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1993942 ppc: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2935801 arm: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3298023 copr: https://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/buil...
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #18 from William Moreno williamjmorenor@gmail.com --- Looks like builds fails due to packages dependencies issues with the change to python3.4 to python3.5
ppc: Error: nothing provides libpython3.4m.so.1.0()(64bit) needed by python3-matplotlib-1.4.3-6.fc23.ppc64le.
s390: Error: Package: python3-mock-1.0.1-8.fc24.noarch (build) Requires: python(abi) = 3.5 Installed: python3-3.4.3-5.fc24.s390x (@build/$releasever) python(abi) = 3.4 python(abi) = 3.4
The completed rawhide build was in a x86_64 host. Mi locall mock build is failing in a x86_64 f23 up to date.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #19 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Sure, we are in the middle of python3.5 mass rebuild, and some secondary architectures seem behind. But I don't think that this matters, the chances of anyone using this package on s390 or ppc are rather slim.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #20 from William Moreno williamjmorenor@gmail.com --- Package Review ==============
1. The doc and common subpackage both ship the license text, I will recomend to include the license text in the common packages and include a weak dependencie in doc:
Suggest: python-music21-common
Also use weak dependencies in python2 and 3 subpackage to suggest the doc subpackage.
2. The common subpackage include the python2.7 files than are linked to the python3 subpackage. As part of the move of Fedora to python3 by default I will recomend to split the common subpackage to ship the python3.5 files. Currently the common subpackage will requires python2 as the owner of the /usr/lib/python2.7/site-packages/ directory so python3-music21 will require python2 to install python-music21-common.
There are many warning about symlinks in both packages, also please check this issue.
The best aproach to this common content is to place it in /usr/share but this will require some mayor patching to the code and this will require to work with upstream.
3. Include in python2 and 3 %files
%exclude %{python2_sitelib}/music21/LICENSE
The license file is in the common subpackage.
3. Consider to include the test directory in both packages into a devel subpackage (python2-name-devel and python3-name-devel), most user will not run the test locally and this will let then get a smaller package to download.
4. Also both packages have a demos directory than do not look to be necesary in run time and can be packaged as subpackages, you can use weak depencies to suggest the user to install the demos subpackages.
5. Package is not known to require an ExcludeArch tag. Builds fails in secondary arches, but looks like there is a issue with the packaging root.
RPMLint: 1: python2-music21.noarch: E: explicit-lib-dependency python-matplotlib Not need work, it is a rpmlint issue 2: python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach If you change the common to python3 files this warning will be fixed but you will need to check if the link in python2 works fine. 3: python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 Sedout the shebang of this files 4: python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc Request upstream to fix it or propose a patch to update it. 5: python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt See: https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
===== MUST items ===== Generic: Pass: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Pass: License field in the package spec file matches the actual license. Pass: License file installed when any subpackage combination is installed. Pass: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Pass: Package contains no bundled libraries without FPC exception. Pass: Changelog in prescribed format. Pass: Sources contain only permissible code or content. NA: Package contains desktop file if it is a GUI application. NA: Development files must be in a -devel package Pass: Package uses nothing in %doc for runtime. Pass: Package consistently uses macros (instead of hard-coded directory names). Pass: Package is named according to the Package Naming Guidelines. Pass: Package does not generate any conflict. Pass: Package obeys FHS, except libexecdir and /usr/target. Pass: If the package is a rename of another package, proper Obsoletes and Provides are present. Paas: Requires correct, justified where necessary. Paas: Spec file is legible and written in American English. Paas: Package contains systemd file(s) if in need. Paas: Large documentation must go in a -doc subpackage. Large could be size Paas: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Paas: Package installs properly. Pass: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Paas: Package requires other packages for directories it uses. Paas: Package must own all directories that it creates. Paas: Package does not own files or directories owned by other packages. Paas: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Paas: Package uses either %{buildroot} or $RPM_BUILD_ROOT Paas: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Paas: Macros in Summary, %description expandable at SRPM build time. Paas: Dist tag is present. Paas: Package does not contain duplicates in %files. Paas: Permissions on files are set properly. Paas: Package use %makeinstall only when make install DESTDIR=... doesn't work. Paas: Package is named using only allowed ASCII characters. Paas: Package does not use a name that already exists. Paas: Package is not relocatable. Paas: Sources used to build the package match the upstream source, as provided in the spec URL. Paas: Spec file name must match the spec package %{name}, in the format %{name}.spec. Paas: File names are valid UTF-8. Paas: Packages must not store files under /srv, /opt or /usr/local
Python: Paas: Python eggs must not download any dependencies during the build process. Pass: A package which is used by another package via an egg interface should provide egg info. Paas: Package meets the Packaging Guidelines::Python Paas: Package contains BR: python2-devel or python3-devel Paas: Binary eggs must be removed in %prep
===== SHOULD items ===== Generic: NA: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Paas: Final provides and requires are sane (see attachments). NA: Fully versioned dependency in subpackages if applicable. NA: Package functions as described. Paas: Latest version is packaged. Paas: Package does not include license text files separate from upstream. NA: Patches link to upstream bugs/comments/lists or are otherwise justified. NA: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. NA: Package should compile and build into binary rpms on all supported architectures. Paas: %check is present and all tests pass. Paas: Packages should try to preserve timestamps of original installed files. Paas: Packager, Vendor, PreReq, Copyright tags should not be in spec file Paas: Sources can be downloaded from URI in Source: tag Paas: Reviewer should test that the package builds in mock. Paas: Buildroot is not present Paas: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Paas: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Paas: SourceX is a working URL. Paas: Spec use %global instead of %define unless justified.
===== EXTRA items ===== Generic: Paas: Rpmlint is run on all installed packages. Paas: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python2-music21-2.1.2-1.fc23.noarch.rpm python3-music21-2.1.2-1.fc23.noarch.rpm python-music21-common-2.1.2-1.fc23.noarch.rpm python-music21-doc-2.1.2-1.fc23.noarch.rpm python-music21-2.1.2-1.fc23.src.rpm python2-music21.noarch: E: explicit-lib-dependency python-matplotlib python2-music21.noarch: W: no-documentation python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: E: explicit-lib-dependency python3-matplotlib python3-music21.noarch: W: no-documentation python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schoenberg /usr/lib/python2.7/site-packages/music21/corpus/schoenberg python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/theoryExercises /usr/lib/python2.7/site-packages/music21/corpus/theoryExercises python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/luca /usr/lib/python2.7/site-packages/music21/corpus/luca python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/josquin /usr/lib/python2.7/site-packages/music21/corpus/josquin python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/mozart /usr/lib/python2.7/site-packages/music21/corpus/mozart python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ciconia /usr/lib/python2.7/site-packages/music21/corpus/ciconia python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann /usr/lib/python2.7/site-packages/music21/corpus/schumann python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/bach /usr/lib/python2.7/site-packages/music21/corpus/bach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/beethoven /usr/lib/python2.7/site-packages/music21/corpus/beethoven python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/trecento /usr/lib/python2.7/site-packages/music21/corpus/trecento python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/corelli /usr/lib/python2.7/site-packages/music21/corpus/corelli python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/monteverdi /usr/lib/python2.7/site-packages/music21/corpus/monteverdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/essenFolksong /usr/lib/python2.7/site-packages/music21/corpus/essenFolksong python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/airdsAirs /usr/lib/python2.7/site-packages/music21/corpus/airdsAirs python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/verdi /usr/lib/python2.7/site-packages/music21/corpus/verdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ryansMammoth /usr/lib/python2.7/site-packages/music21/corpus/ryansMammoth python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/handel /usr/lib/python2.7/site-packages/music21/corpus/handel python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/miscFolk /usr/lib/python2.7/site-packages/music21/corpus/miscFolk python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/leadSheet /usr/lib/python2.7/site-packages/music21/corpus/leadSheet python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/oneills1850 /usr/lib/python2.7/site-packages/music21/corpus/oneills1850 python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann_clara /usr/lib/python2.7/site-packages/music21/corpus/schumann_clara python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/haydn /usr/lib/python2.7/site-packages/music21/corpus/haydn python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/weber /usr/lib/python2.7/site-packages/music21/corpus/weber python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/scale/scala/scl /usr/lib/python2.7/site-packages/music21/scale/scala/scl python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/palestrina /usr/lib/python2.7/site-packages/music21/corpus/palestrina python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/demos /usr/lib/python2.7/site-packages/music21/corpus/demos python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laDeplorationDeLaMorteDeJohannesOckeghem.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/4vPerIlludAveProlatum.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/milleRegrets.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/fortunaDunGranTempo.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/adieuMesAmours.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/oVenusBant.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/petiteCamusette.abc python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt python-music21.src: W: invalid-url Source0: https://github.com/cuthbertLab/music21/releases/download/v.2.1.2/music21-2.1... HTTP Error 403: Forbidden 5 packages and 0 specfiles checked; 16 errors, 31 warnings.
Rpmlint (installed packages) ---------------------------- python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/petiteCamusette.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/milleRegrets.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/adieuMesAmours.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/fortunaDunGranTempo.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/oVenusBant.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/4vPerIlludAveProlatum.abc python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laDeplorationDeLaMorteDeJohannesOckeghem.abc python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt python2-music21.noarch: E: explicit-lib-dependency python-matplotlib python2-music21.noarch: W: no-documentation python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python2-music21.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: E: explicit-lib-dependency python3-matplotlib python3-music21.noarch: W: no-documentation python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/bach /usr/lib/python2.7/site-packages/music21/corpus/bach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/leadSheet /usr/lib/python2.7/site-packages/music21/corpus/leadSheet python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/demos /usr/lib/python2.7/site-packages/music21/corpus/demos python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/palestrina /usr/lib/python2.7/site-packages/music21/corpus/palestrina python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/luca /usr/lib/python2.7/site-packages/music21/corpus/luca python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/theoryExercises /usr/lib/python2.7/site-packages/music21/corpus/theoryExercises python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/scale/scala/scl /usr/lib/python2.7/site-packages/music21/scale/scala/scl python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/demos/josquin/label_intervals.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schoenberg /usr/lib/python2.7/site-packages/music21/corpus/schoenberg python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/haydn /usr/lib/python2.7/site-packages/music21/corpus/haydn python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/essenFolksong /usr/lib/python2.7/site-packages/music21/corpus/essenFolksong python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ryansMammoth /usr/lib/python2.7/site-packages/music21/corpus/ryansMammoth python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/corelli /usr/lib/python2.7/site-packages/music21/corpus/corelli python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/trecento /usr/lib/python2.7/site-packages/music21/corpus/trecento python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann /usr/lib/python2.7/site-packages/music21/corpus/schumann python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/schumann_clara /usr/lib/python2.7/site-packages/music21/corpus/schumann_clara python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/weber /usr/lib/python2.7/site-packages/music21/corpus/weber python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/oneills1850 /usr/lib/python2.7/site-packages/music21/corpus/oneills1850 python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/airdsAirs /usr/lib/python2.7/site-packages/music21/corpus/airdsAirs python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/josquin /usr/lib/python2.7/site-packages/music21/corpus/josquin python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/monteverdi /usr/lib/python2.7/site-packages/music21/corpus/monteverdi python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/ciconia /usr/lib/python2.7/site-packages/music21/corpus/ciconia python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/mozart /usr/lib/python2.7/site-packages/music21/corpus/mozart python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/beethoven /usr/lib/python2.7/site-packages/music21/corpus/beethoven python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/verdi /usr/lib/python2.7/site-packages/music21/corpus/verdi python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/findTrecentoFragments.py 644 /usr/bin/python python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/miscFolk /usr/lib/python2.7/site-packages/music21/corpus/miscFolk python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/handel /usr/lib/python2.7/site-packages/music21/corpus/handel 4 packages and 0 specfiles checked; 16 errors, 30 warnings.
Requires -------- python-music21-common (rpmlib, GLIBC filtered): python(abi)
python-music21-doc (rpmlib, GLIBC filtered):
python2-music21 (rpmlib, GLIBC filtered): lilypond mscore numpy python(abi) python-chardet python-enum34 python-jsonpickle python-matplotlib python-mock python-music21-common python-pillow python-six python-webcolors python-xlrd scipy
python3-music21 (rpmlib, GLIBC filtered): lilypond mscore python(abi) python-music21-common python3-chardet python3-jsonpickle python3-matplotlib python3-mock python3-numpy python3-pillow python3-scipy python3-six python3-webcolors python3-xlrd
Provides -------- python-music21-common: python-music21-common
python-music21-doc: python-music21-doc
python2-music21: python-music21 python2-music21
python3-music21: python3-music21
Source checksums ---------------- https://github.com/cuthbertLab/music21/releases/download/v.2.1.2/music21-2.1... : CHECKSUM(SHA256) this package : 5a5521649db0ef1698185d842f566c0b515913e89a55c8c894731f37257abb0a CHECKSUM(SHA256) upstream package : 5a5521649db0ef1698185d842f566c0b515913e89a55c8c894731f37257abb0a
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #22 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- zbyszek's scratch build of python-music21-2.1.2-2.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12064308
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #21 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Thanks for taking on the review!
(In reply to William Moreno from comment #20)
Package Review
- The doc and common subpackage both ship the license text, I will recomend
to include the license text in the common packages and include a weak dependencie in doc:
Suggest: python-music21-common
I don't think this is allowed. The license file MUST be installed with any subcombination of packages.
Also use weak dependencies in python2 and 3 subpackage to suggest the doc subpackage.
Good idea, done.
- The common subpackage include the python2.7 files than are linked to the
python3 subpackage. As part of the move of Fedora to python3 by default I will recomend to split the common subpackage to ship the python3.5 files. Currently the common subpackage will requires python2 as the owner of the /usr/lib/python2.7/site-packages/ directory so python3-music21 will require python2 to install python-music21-common.
I moved them.
There are many warning about symlinks in both packages, also please check this issue.
I think that the symlinks are fine. rpmlint does not understand symlinks.
The best aproach to this common content is to place it in /usr/share but this will require some mayor patching to the code and this will require to work with upstream.
I could move the files in common to /usr/share and provide symlinks from both subpackages. I don't know if this would be better.
- Include in python2 and 3 %files
%exclude %{python2_sitelib}/music21/LICENSE The license file is in the common subpackage.
Done.
- Consider to include the test directory in both packages into a devel
subpackage (python2-name-devel and python3-name-devel), most user will not run the test locally and this will let then get a smaller package to download.
- Also both packages have a demos directory than do not look to be necesary
in run time and can be packaged as subpackages, you can use weak depencies to suggest the user to install the demos subpackages.
I don't think splitting it up like this makes sense. It is essentially a user program (using python as its interface), not a library that is installed as a dependency for other things. Demos can be used as documentation and are useful when using the package. They are not too big too.
- Package is not known to require an ExcludeArch tag. Builds fails in
secondary arches, but looks like there is a issue with the packaging root.
Hm, I'll try to rebuild.
RPMLint: 1: python2-music21.noarch: E: explicit-lib-dependency python-matplotlib Not need work, it is a rpmlint issue
I actually submitted a PR for that, but it doesn't seem like it will be merged: https://github.com/rpm-software-management/rpmlint/pull/58
2: python3-music21.noarch: W: dangling-symlink /usr/lib/python3.4/site-packages/music21/corpus/cpebach /usr/lib/python2.7/site-packages/music21/corpus/cpebach If you change the common to python3 files this warning will be fixed but you will need to check if the link in python2 works fine.
3: python3-music21.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 Sedout the shebang of this files
Done.
4: python-music21-common.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc Request upstream to fix it or propose a patch to update it.
https://github.com/cuthbertLab/music21/pull/122
5: python-music21-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt See: https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
Done.
I need to update to 2.2.1.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #23 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.2.1-1.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #24 from William Moreno williamjmorenor@gmail.com --- Package Aproved ===============
Just note than there are some missing BR in f22 but the package build fine in f23 and rawhide
http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build...
Also note than the cvs request have been deprecated and you must request the new package from the pkgdb:
https://admin.fedoraproject.org/pkgdb/request/package/
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #25 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Thank you for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #26 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-music21
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- python-music21-2.2.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-249b77dcae
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- python-music21-2.2.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-music21' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-249b77dcae
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- python-music21-2.2.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1240116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-01-09 16:58:05
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla