[Bug 461912] New: Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: puzzles -  A collection of one-player puzzle games

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Summary: Review Request: puzzles -  A collection of one-player
                    puzzle games
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://bogado.net/rpm/puzzles.spec
SRPM URL: http://bogado.net/rpm/puzzles-8149-1.bog9.src.rpm
Description: this is a collection of small desktop toys, little games that you
can pop up in a window and play for two or three minutes while you take a 
break from whatever else you were doing.

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #1 from Victor Bogado   2008-09-11 08:06:31 EDT ---
Details about this package the upstream developer don't use normal version
numbers he simply uses the subversion release number as an identifier for each
version, this is why the version look funny. I considered several options to
treat this:

- use the version as if it was a pre-release, but I decided against because as
far as I know this stay as a pre-release forever.

- use an artificial version "0.#release" but this could conflict with a future
change of mind of the upstream developer.

- Use the version as the developer have made, using simply the release number.

I have chosen the later, as it is the most "pristine" way of selecting a
version number, that will hopefully be compatible and comparable with version
number on other distributions.

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Orcan Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Orcan Ogetbil   2008-10-06 04:08:55 EDT ---
I would suggest you to have a look at:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages

Did you try to contact the author to ask about this version issue?

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Sergio Pascual  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #3 from Sergio Pascual   2008-10-12 15:25:18 EDT ---
Package fails to build in mock. You need to add 
BuildRequires: desktop-file-utils

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Sergio Pascual  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #4 from Sergio Pascual   2008-10-18 13:42:24 EDT ---
I have added the dependence in desktop-file-utils to build the package.

* In Source0 you can use the %{name} macro instead of puzzles if you want
   * BuildRequires: sed is in the exception list, so it can be safely removed.
Perl it isn't but is pulled anyway. You can remove it also or leave it to be in
the safe side. You have to add desktop-file-utils too.
   * Source doesn't match upstream source (there is a new version upstream)
   * In description there's a typo: this is a collection -> This is a colection
   * In %setup, you can run sed in place with 
     sed -e "s/CFLAGS = .*-g/CFLAGS = %{optflags}/" -i Makefile
   * The naming of the binaries seems problematic. For example, there is a
blackbox package that provides /usr/bin/blackbox already in Fedora. Other
puzzles have very generic names: cube, guess, map, mines... I suggest you to
rename all the puzzles, something like puzzle_name or puzzle-name
   * You are putting the desktop files in a directory inside
/usr/share/applications. I think is clearer to put them all in the main
directory and use a prefix if necessary (the different openoffice applications
follow this approach)
   * The license text must be included in %doc

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #5 from Victor Bogado   2008-10-20 17:58:09 EDT ---
There, I still have some questions:

- the author said it will keep using the subversion revision number as a
version numbering, but he also said that he don´t mind to have the pre-release
scheme of versioning. I believe that following the upstream version, even if it
get weirdly big version numbers is the way to go, but what is your opinion.

- About the desktop files I don't like the fact that all the puzzles get
cluttered on the menu, but I don't know how to fix this. The ideal solution
would be for a submenu for the puzzle collection inside the game menu. Is this
feasable?

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #6 from Victor Bogado   2008-10-20 18:00:23 EDT ---
Wait I just found a bug on the above submitted files. I will fix it and upload
a new pair in a few minutes, sorry...

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #7 from Victor Bogado   2008-10-20 18:10:38 EDT ---
I just realized that I didn't have posted the URLs before :P

The problem was fixed and the files uploaded here :

http://bogado.net/rpm/puzzles-8200-2.bog9.src.rpm
http://bogado.net/rpm/puzzles.spec

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #8 from Sergio Pascual   2008-10-26 06:00:03 EDT ---
* You still need to add BuildRequires: desktop-file-utils
* I think the iconv line belongs to %prep
* The version in the two first lines in %changelog is wrong, it should be 8200
* The sentence in %description still begins with a lower case letter.

About the version, I would follow upstream convention. There are other packages
with high version numbers (e.g. xterm is 236)

About the menus, I don't think is possible/convenient to modify the menu
layout. Users can change it using applications (for example, alacarte). Anyway,
I will ask in the packagers list

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #9 from Sergio Pascual   2008-10-27 10:42:05 EDT ---
There is a package called game-menus, that create submenus based in
subcategories. The puzzles go into 'Logic & Puzzles'

By the way, the name of the puzzles should start with a capital letter,
following the convention of the rest of the menu entries.

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #10 from Victor Bogado   2008-10-27 18:08:25 EDT ---
Damn I am distracted, I was sure that I had done everything, and ended up
forgetting the most important point. :P

I made the changes, and putted on the same bat-site.

http://bogado.net/rpm/puzzles-8200-3.bog9.src.rpm
http://bogado.net/rpm/puzzles.spec

I installed the games-menus and it is good. I was thinking if the package could
be divided into several sub packages, one for each game and a master-package
that could install all the mini-games, the only problem is that I don't know
how to create the sub-packages based on what binaries the compilation produces.

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #11 from Victor Bogado   2008-12-11 14:10:46 EDT ---
ping?

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #12 from Victor Bogado   2008-12-11 16:36:49 EDT ---
There is a new upstream version, I made a new srpm and spec file to reflect
that.

http://bogado.net/rpm/puzzles-8365-1.bog10.src.rpm
http://bogado.net/rpm/puzzles.spec

Otherwise those have the updates asked in comment #9

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Sergio Pascual  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Sergio Pascual   2008-12-13 11:46:51 EDT ---
Sorry for the delay, somehow I missed your updates.

This package is APPROVED

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Victor Bogado  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

--- Comment #14 from Victor Bogado   2008-12-14 14:39:52 EDT ---
New Package CVS Request
=======================
Package Name: puzzles
Short Description:  A collection of one-player puzzle games
Owners: bogado
Branches: F-9 F-10
InitialCC:

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #15 from Dennis Gilmore   2008-12-15 15:46:23 EDT ---
CVS Done

[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=461912

Victor Bogado  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE