https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Bug ID: 1822561 Summary: Review Request: wget2 Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: akhaitov@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-raw...
SRPM: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-raw...
Description: GNU Wget2 is the successor of GNU Wget, a file and recursive website downloader. Designed and written from scratch it wraps around libwget, that provides the basic functions needed by a web client. Wget2 works multi-threaded and uses many features to allow fast operation. In many cases Wget2 downloads much faster than Wget1.x due to HTTP2, HTTP compression, parallel connections and use of If-Modified-Since HTTP header.
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Anna Khaitovich akhaitov@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: wget2 |Review Request: wget2 - the | |successor of GNU Wget, a | |file and recursive website | |downloader
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov@gmail.com
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com --- Provides: libtool Provides: wget2-debugsource = 1.99.2-1 Provides: wget2-debuginfo = 1.99.2-1 # Versioned libraries Provides: libwget.so.0 Provides: libwget_alloc.so.0 Provides: libwget_common.so.0 Provides: libwget_css.so.0 Provides: libwget_dns.so.0 Provides: libwget_dnscache.so.0 Provides: libwget_encoding.so.0 Provides: libwget_hashfile.so.0 Provides: libwget_hpkp_db.so.0 Provides: libwget_ip.so.0 Provides: libwget_iri.so.0 Provides: libwget_logger.so.0 Provides: libwget_metalink.so.0
^^^ This looks wrong. Please remove it.
%{_libdir}/libwget*.a %{_libdir}/libwget*.la
^^^ These files shouldn't be packaged.
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- Also you likely mean devel sub-packages of these packages, not the packages itself:
BuildRequires: glibc BuildRequires: zlib >= 1.2.3 BuildRequires: gnutls BuildRequires: libidn2 >= 0.14 BuildRequires: flex >= 2.5.35 BuildRequires: libpsl >= 0.5.0
# Optional # HTTP/2 support BuildRequires: libnghttp2 >= 1.3.0 # run the test suite BuildRequires: libmicrohttpd >= 0.9.51 # build distribution tarballs BuildRequires: lzip # coverage reports BuildRequires: lcov # automatic signature verification) BuildRequires: gpgme >= 0.4.2 # filtering by PCRE regex BuildRequires: pcre # HTTP zstd decompression) BuildRequires: libzstd >= 1.3.0
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
--- Comment #4 from Anna Khaitovich akhaitov@redhat.com --- New spec: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-raw... New srpm: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-raw...
Regarding wget2-static - will discuss with upstream if those extra static libraries are indeed needed
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Anna, we don't generally ship libtool archives, so those should be deleted. The end result would be that we wouldn't have a -static subpackage.
Please delete libtool archives and remove the -static subpackage.
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-...
Product: Fedora Version: rawhide Component: Package Review
Neal Gompa ngompa13@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Neal Gompa ngompa13@gmail.com's needinfo: Bug 1822561: Review Request: wget2 - the successor of GNU Wget, a file and recursive website downloader https://bugzilla.redhat.com/show_bug.cgi?id=1822561
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Anna, we don't generally ship libtool archives, so those should be deleted. The end result would be that we wouldn't have a -static subpackage.
Please delete libtool archives and remove the -static subpackage.
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-... raries
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE Last Closed| |2021-09-26 15:00:53
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- As Anna no longer works at Red Hat and cannot be contacted, this review is effectively dead and superseded by a new one.
*** This bug has been marked as a duplicate of bug 2007965 ***
https://bugzilla.redhat.com/show_bug.cgi?id=1822561
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com