[Bug 431161] New: Review Request: mathmap - A gimp plugin and commandline tool - package-review

List overview All Threads
Download

newer

[Bug 431161] New: Review Request: mathmap - A gimp plugin and commandline tool

older

[Bug 448745] New: Review Request:...

[Bug 249929] New: Review Request:...

Red Hat Bugzilla

31 Jan 2008 31 Jan '08

9:25 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=431161

Summary: Review Request: mathmap - A gimp plugin and commandline tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rnorwood@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://people.redhat.com/rnorwood/rpms/mathmap.spec SRPM URL: http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-1.fc9.src.rpm Description: MathMap is a GIMP plug-in which allows distortion of images specified by mathematical formulae. For each pixel in the generated image, an expression is evaluated which should return a pixel value. The expression can either refer to a pixel in the source image or can generate pixels completely independent of the source.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by thread

Red Hat Bugzilla

31 Jan 31 Jan

9:27 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From rnorwood@redhat.com 2008-01-31 22:27 EST ------- There are unfortunately a few rpmlint warnings:

mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/new_template.c mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/blender_opmacros.h mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/pools.h mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/opmacros.h mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/blender_template.c

These seem to be required for the plugin to work at runtime, despite being source files.

mathmap.i386: W: symlink-should-be-relative /usr/lib/gimp/2.0/plug-ins/mathmap /usr/bin/mathmap

Not sure if this matters.

mathmap.i386: E: only-non-binary-in-usr-lib

I don't think I can fix this, because the gimp plugin path isn't picked by me

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6 Feb 6 Feb

7:17 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-06 08:17 EST ------- First of all, rebuild doesn't succeed. http://koji.fedoraproject.org/koji/taskinfo?taskID=398683 You can check this by koji scratch build.

...

From just glancing at your spec file:

- Source must be given with full URL - Fedora specific compilation flags don't seem to be honored correctly. - Would you try to use relative symlink instead of absolute one? - When using "install" or "cp" commands, add "-p" option to keep timestamps on installed files. - It seems "Requires: gimp" is needed because `gimptool --gimpdatadir` is owned by gimp but not by gimp-libs.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Feb 7 Feb

1:14 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From rnorwood@redhat.com 2008-02-07 14:14 EST ------- - Source must be given with full URL

Fixed.

- Fedora specific compilation flags don't seem to be honored correctly.

Maybe I'm being dense, but I'm not sure what you mean.

- Would you try to use relative symlink instead of absolute one?

Fixed.

- When using "install" or "cp" commands, add "-p" option to keep timestamps on installed files.

Fixed.

- It seems "Requires: gimp" is needed because `gimptool --gimpdatadir` is owned by gimp but not by gimp-libs.

Fixed.

New spec and srpm at: http://people.redhat.com/rnorwood/rpms/mathmap.spec http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-2.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 Feb 8 Feb

3:48 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:06 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-08 10:06 EST ------- * compiler falgs - Well, what "Fedora specific compilation flags are not honored" means is related to "Compiler flags" of http://fedoraproject.org/wiki/Packaging/Guidelines When using gcc or g++, we must ensure that the compiler option specified as %optflags are correctly used. On rawhide i386 system, currently they are: ----------------------------------------------------------------------------- [tasaka1@localhost ~]$ rpm --eval %optflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables ------------------------------------------------------------------------------ However the build log (from: http://koji.fedoraproject.org/koji/taskinfo?taskID=402716 ) shows: ------------------------------------------------------------------------------- gcc -I. -D_GNU_SOURCE -DCGEN_CC=""gcc -O2 -c -fPIC -o"" -DCGEN_LD=""gcc -shared -o"" -O2 -Wall `gimptool-2.0 --cflags` `pkg-config --cflags gmodule-2.0 gthread-2.0 gtksourceview-1.0` -DLOCALEDIR="/usr/local/share/locale" -DTEMPLATE_DIR="`gimptool-2.0 --gimpdatadir`/mathmap" -DPIXMAP_DIR="`gimptool-2.0 --gimpdatadir`/mathmap" -DENABLE_NLS -DMATHMAP_CMDLINE -DGIMPDATADIR="`gimptool-2.0 --gimpdatadir`" -DMATHMAP_VERSION="1.2.4" -DRWIMG_JPEG -DRWIMG_PNG -DRWIMG_GIF -o mathmap_common.o -c mathmap_common.c ------------------------------------------------------------------------------- , where %optflags are not correctly honored.

* LOCALEDIR - And as far as I checked build.log, perhaps LOCALEDIR is wrong.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 Feb 22 Feb

11:32 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-22 12:32 EST ------- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:52 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

rnorwood@redhat.com changed:

------- Additional Comments From rnorwood@redhat.com 2008-02-22 12:52 EST ------- I need to take the time to convince it to honor the %optflags, but I haven't had a chance yet.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

31 Mar 31 Mar

8:30 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-31 09:30 EST ------- ping again?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

29 Apr 29 Apr

10:58 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-04-29 11:58 EST ------- ping again?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 May 8 May

9:38 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-08 10:38 EST ------- I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 May 12 May

12:50 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

rnorwood@redhat.com changed:

------- Additional Comments From rnorwood@redhat.com 2008-05-12 13:50 EST ------- Sorry about the delay, I've been knee deep in other stuff for awhile. I'll take another look at this today.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:11 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From rnorwood@redhat.com 2008-05-12 15:11 EST ------- Ok, I think this new spec and SRPM fix both the optflags problem and the locale directory problem:

http://people.redhat.com/rnorwood/rpms/mathmap.spec http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-3.fc9.src.rpm

Koji build against dist-f10:

http://koji.fedoraproject.org/koji/taskinfo?taskID=605186

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 May 13 May

12:03 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-13 13:03 EST ------- Well, for 1.2.4-3:

* This package should have explicit "Requires: gimp" as - currently only gimp-libs is installed together by yum from library dependency - on the other hand $(gimptool --gimpdatadir) is owned by gimp, not by gimp-libs

Other things are okay. ----------------------------------------------------------------------- This package (mathmap) is APPROVED by me -----------------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

21 May 21 May

11:03 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-21 12:03 EST ------- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:26 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

rnorwood@redhat.com changed:

------- Additional Comments From rnorwood@redhat.com 2008-05-21 14:26 EST ------- Added the 'Requires: gimp':

http://people.redhat.com/rnorwood/rpms/mathmap.spec http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-4.fc9.src.rpm

Since you've approved it with this change, here's the cvs request:

New Package CVS Request ======================= Package Name: mathmap Short Description: A gimp plugin and commandline tool Owners: rnorwood Branches: F-9 InitialCC: Cvsextras Commits: Yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 May 22 May

1:31 p.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-05-22 14:31 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

25 May 25 May

7:05 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-25 08:05 EST ------- Please submit a F-9 updates request on bodhi. closing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

27 May 27 May

10:50 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From updates@fedoraproject.org 2008-05-27 11:50 EST ------- mathmap-1.2.4-4.fc9 has been submitted as an update for Fedora 9

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3 Jun 3 Jun

2:29 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

------- Additional Comments From updates@fedoraproject.org 2008-06-03 03:29 EST ------- mathmap-1.2.4-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:29 a.m.

New subject: [Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool

https://bugzilla.redhat.com/show_bug.cgi?id=431161

updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6258

Age (days ago)

6381

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla