https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Bug ID: 1140403 Summary: Review Request: dreamchess - open source chess game Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: projects.rg@smart.ms QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-1.fc20.s... Description: DreamChess is an open source chess game. Our primary target platforms are Windows, Mac OS X and Linux. DreamChess features 3D OpenGL graphics and provides various chess board sets, ranging from classic wooden to flat figurines. Fedora Account System Username: raphgro
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #1 from Raphael Groner projects.rg@smart.ms --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7565869
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Christian Dersch chrisdersch@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chrisdersch@gmail.com Assignee|nobody@fedoraproject.org |chrisdersch@gmail.com Flags| |fedora-review?
--- Comment #2 from Christian Dersch chrisdersch@gmail.com --- Taken :)
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #3 from Raphael Groner projects.rg@smart.ms ---
From the homepage:
A moderately strong chess engine is included: Dreamer. However, should this engine be too weak for you, then you can use any other XBoard-compatible chess engine, including the popular Crafty and GNU Chess.
Cause of that I am thinking about moving dreamer binary and manpage into separate subpackage(s). An user could use dreamchess with GNU chess only.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #4 from Christian Dersch chrisdersch@gmail.com --- First review done. There are some things to fix, have a look at the review below ;)
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
==> You can remove "rm -rf $RPM_BUILD_ROOT" for current Fedora releases (but required for EPEL5)
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/review/1140403-dreamchess/licensecheck.txt
==> Please check this, licensecheck.txt is below, but BSD license is also mentioned in COPYRIGHT file
[x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/dreamchess [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dreamchess
==> Please check this
[x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [!]: Package complies to the Packaging Guidelines
==> You are packaging RC1, not the final version! Please add this information in release tag https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
[x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- data ==> Please fix this, Requires: %{name}-%{version} instead of %{name}
[x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _suffix -RC1, %define _engine dreamer ==> Please adjust this when fixing spec
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dreamchess-0.2.1-1.fc22.x86_64.rpm dreamchess-data-0.2.1-1.fc22.noarch.rpm dreamchess-0.2.1-1.fc22.src.rpm dreamchess.x86_64: W: spelling-error %description -l en_US xboard -> board, aboard, x board dreamchess-data.noarch: W: no-documentation dreamchess.src: W: spelling-error %description -l en_US xboard -> board, aboard, x board 3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint dreamchess dreamchess-data dreamchess.x86_64: W: spelling-error %description -l en_US xboard -> board, aboard, x board dreamchess-data.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'
Requires -------- dreamchess (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_mixer-1.2.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH)
dreamchess-data (rpmlib, GLIBC filtered): dreamchess
Provides -------- dreamchess: application() application(dreamchess.desktop) dreamchess dreamchess(x86-64)
dreamchess-data: dreamchess-data
Source checksums ---------------- http://sf.net/projects/dreamchess/files/dreamchess/Git/dreamchess-0.2.1-RC1.... : CHECKSUM(SHA256) this package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 CHECKSUM(SHA256) upstream package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 https://raw.githubusercontent.com/Arch-Games/arch-games/master/packages/drea... : CHECKSUM(SHA256) this package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd CHECKSUM(SHA256) upstream package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1140403 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
================================== licensecheck.txt
BSD (3 clause) -------------- dreamchess-0.2.1-RC1/src/include/gamegui/queue.h
GPL (v2 or later) ----------------- dreamchess-0.2.1-RC1/src/dreamer/pgn_parser.c dreamchess-0.2.1-RC1/src/dreamer/pgn_parser.h dreamchess-0.2.1-RC1/src/libs/san_parse.c dreamchess-0.2.1-RC1/src/pgn_parser.c dreamchess-0.2.1-RC1/src/pgn_parser.h
GPL (v3 or later) ----------------- dreamchess-0.2.1-RC1/src/audio/playlist.c dreamchess-0.2.1-RC1/src/audio/playlist.h dreamchess-0.2.1-RC1/src/audio/sdlmixer.c dreamchess-0.2.1-RC1/src/board.c dreamchess-0.2.1-RC1/src/board.h dreamchess-0.2.1-RC1/src/comm.c dreamchess-0.2.1-RC1/src/comm.h dreamchess-0.2.1-RC1/src/comm_unix.c dreamchess-0.2.1-RC1/src/comm_win32.c dreamchess-0.2.1-RC1/src/credits.c dreamchess-0.2.1-RC1/src/credits.h dreamchess-0.2.1-RC1/src/debug.c dreamchess-0.2.1-RC1/src/debug.h dreamchess-0.2.1-RC1/src/dir.c dreamchess-0.2.1-RC1/src/dir.h dreamchess-0.2.1-RC1/src/dreamchess.c dreamchess-0.2.1-RC1/src/dreamchess.h dreamchess-0.2.1-RC1/src/dreamer/board.c dreamchess-0.2.1-RC1/src/dreamer/board.h dreamchess-0.2.1-RC1/src/dreamer/commands.c dreamchess-0.2.1-RC1/src/dreamer/commands.h dreamchess-0.2.1-RC1/src/dreamer/dreamer.c dreamchess-0.2.1-RC1/src/dreamer/dreamer.h dreamchess-0.2.1-RC1/src/dreamer/e_comm.c dreamchess-0.2.1-RC1/src/dreamer/e_comm.h dreamchess-0.2.1-RC1/src/dreamer/e_comm_unix.c dreamchess-0.2.1-RC1/src/dreamer/e_comm_win32.c dreamchess-0.2.1-RC1/src/dreamer/eval.c dreamchess-0.2.1-RC1/src/dreamer/eval.h dreamchess-0.2.1-RC1/src/dreamer/gen_chess_moves.c dreamchess-0.2.1-RC1/src/dreamer/hashing.c dreamchess-0.2.1-RC1/src/dreamer/hashing.h dreamchess-0.2.1-RC1/src/dreamer/history.c dreamchess-0.2.1-RC1/src/dreamer/history.h dreamchess-0.2.1-RC1/src/dreamer/main.c dreamchess-0.2.1-RC1/src/dreamer/makebook.c dreamchess-0.2.1-RC1/src/dreamer/makebook.h dreamchess-0.2.1-RC1/src/dreamer/move.c dreamchess-0.2.1-RC1/src/dreamer/move.h dreamchess-0.2.1-RC1/src/dreamer/move_data.h dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.h dreamchess-0.2.1-RC1/src/dreamer/repetition.c dreamchess-0.2.1-RC1/src/dreamer/repetition.h dreamchess-0.2.1-RC1/src/dreamer/search.c dreamchess-0.2.1-RC1/src/dreamer/search.h dreamchess-0.2.1-RC1/src/dreamer/timer.c dreamchess-0.2.1-RC1/src/dreamer/timer.h dreamchess-0.2.1-RC1/src/dreamer/transposition.c dreamchess-0.2.1-RC1/src/dreamer/transposition.h dreamchess-0.2.1-RC1/src/fen.c dreamchess-0.2.1-RC1/src/fen.h dreamchess-0.2.1-RC1/src/gamegui_dialogs/configuration.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/ingame_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/message_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/quit_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/resolution.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/styles.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/system_dialog.c dreamchess-0.2.1-RC1/src/gamegui_dialogs/time.c dreamchess-0.2.1-RC1/src/history.c dreamchess-0.2.1-RC1/src/history.h dreamchess-0.2.1-RC1/src/include/audio.h dreamchess-0.2.1-RC1/src/include/engine.h dreamchess-0.2.1-RC1/src/include/gamegui.h dreamchess-0.2.1-RC1/src/include/gamegui/action.h dreamchess-0.2.1-RC1/src/include/gamegui/align.h dreamchess-0.2.1-RC1/src/include/gamegui/bin.h dreamchess-0.2.1-RC1/src/include/gamegui/box.h dreamchess-0.2.1-RC1/src/include/gamegui/clipping.h dreamchess-0.2.1-RC1/src/include/gamegui/container.h dreamchess-0.2.1-RC1/src/include/gamegui/dialog.h dreamchess-0.2.1-RC1/src/include/gamegui/edit.h dreamchess-0.2.1-RC1/src/include/gamegui/entry.h dreamchess-0.2.1-RC1/src/include/gamegui/frame.h dreamchess-0.2.1-RC1/src/include/gamegui/hbox.h dreamchess-0.2.1-RC1/src/include/gamegui/image.h dreamchess-0.2.1-RC1/src/include/gamegui/label.h dreamchess-0.2.1-RC1/src/include/gamegui/option.h dreamchess-0.2.1-RC1/src/include/gamegui/scrollbarv.h dreamchess-0.2.1-RC1/src/include/gamegui/select.h dreamchess-0.2.1-RC1/src/include/gamegui/seperatorh.h dreamchess-0.2.1-RC1/src/include/gamegui/seperatorv.h dreamchess-0.2.1-RC1/src/include/gamegui/signal.h dreamchess-0.2.1-RC1/src/include/gamegui/system.h dreamchess-0.2.1-RC1/src/include/gamegui/vbox.h dreamchess-0.2.1-RC1/src/include/gamegui/viewport.h dreamchess-0.2.1-RC1/src/include/gamegui/widget.h dreamchess-0.2.1-RC1/src/include/gamegui_dialogs.h dreamchess-0.2.1-RC1/src/include/main_sdlthd.h dreamchess-0.2.1-RC1/src/include/options.h dreamchess-0.2.1-RC1/src/include/pipe_mem.h dreamchess-0.2.1-RC1/src/include/pipe_unix.h dreamchess-0.2.1-RC1/src/include/pipe_win32.h dreamchess-0.2.1-RC1/src/include/san.h dreamchess-0.2.1-RC1/src/include/system_config.h dreamchess-0.2.1-RC1/src/include/theme.h dreamchess-0.2.1-RC1/src/libs/gamegui/action.c dreamchess-0.2.1-RC1/src/libs/gamegui/align.c dreamchess-0.2.1-RC1/src/libs/gamegui/bin.c dreamchess-0.2.1-RC1/src/libs/gamegui/box.c dreamchess-0.2.1-RC1/src/libs/gamegui/clipping.c dreamchess-0.2.1-RC1/src/libs/gamegui/container.c dreamchess-0.2.1-RC1/src/libs/gamegui/dialog.c dreamchess-0.2.1-RC1/src/libs/gamegui/edit.c dreamchess-0.2.1-RC1/src/libs/gamegui/entry.c dreamchess-0.2.1-RC1/src/libs/gamegui/frame.c dreamchess-0.2.1-RC1/src/libs/gamegui/hbox.c dreamchess-0.2.1-RC1/src/libs/gamegui/image.c dreamchess-0.2.1-RC1/src/libs/gamegui/label.c dreamchess-0.2.1-RC1/src/libs/gamegui/option.c dreamchess-0.2.1-RC1/src/libs/gamegui/scrollbarv.c dreamchess-0.2.1-RC1/src/libs/gamegui/select.c dreamchess-0.2.1-RC1/src/libs/gamegui/seperatorh.c dreamchess-0.2.1-RC1/src/libs/gamegui/seperatorv.c dreamchess-0.2.1-RC1/src/libs/gamegui/signal.c dreamchess-0.2.1-RC1/src/libs/gamegui/system.c dreamchess-0.2.1-RC1/src/libs/gamegui/vbox.c dreamchess-0.2.1-RC1/src/libs/gamegui/viewport.c dreamchess-0.2.1-RC1/src/libs/gamegui/widget.c dreamchess-0.2.1-RC1/src/libs/msgbuf.c dreamchess-0.2.1-RC1/src/libs/msgbuf.h dreamchess-0.2.1-RC1/src/libs/pipe_beos.c dreamchess-0.2.1-RC1/src/libs/pipe_unix.c dreamchess-0.2.1-RC1/src/libs/pipe_win32.c dreamchess-0.2.1-RC1/src/main.c dreamchess-0.2.1-RC1/src/options.c dreamchess-0.2.1-RC1/src/pgn_scanner.h dreamchess-0.2.1-RC1/src/system_config.c dreamchess-0.2.1-RC1/src/theme.c dreamchess-0.2.1-RC1/src/ui.c dreamchess-0.2.1-RC1/src/ui.h dreamchess-0.2.1-RC1/src/ui_sdlgl/colours.c dreamchess-0.2.1-RC1/src/ui_sdlgl/credits.c dreamchess-0.2.1-RC1/src/ui_sdlgl/draw_scene.c dreamchess-0.2.1-RC1/src/ui_sdlgl/draw_shape.c dreamchess-0.2.1-RC1/src/ui_sdlgl/gamegui_driver.c dreamchess-0.2.1-RC1/src/ui_sdlgl/get_move.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ingame_ui.c dreamchess-0.2.1-RC1/src/ui_sdlgl/load_data.c dreamchess-0.2.1-RC1/src/ui_sdlgl/promote_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/saveload_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/system.c dreamchess-0.2.1-RC1/src/ui_sdlgl/text.c dreamchess-0.2.1-RC1/src/ui_sdlgl/texture.c dreamchess-0.2.1-RC1/src/ui_sdlgl/theme.c dreamchess-0.2.1-RC1/src/ui_sdlgl/title_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/transitions.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl.h dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl_3d.c dreamchess-0.2.1-RC1/src/ui_sdlgl/ui_sdlgl_3d.h dreamchess-0.2.1-RC1/src/ui_sdlgl/victory_dialog.c dreamchess-0.2.1-RC1/src/ui_sdlgl/vkeyboard.c dreamchess-0.2.1-RC1/src/ui_sdlgl/xmlsavefile.c
Unknown or generated -------------------- dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.c dreamchess-0.2.1-RC1/src/include/git_rev.h dreamchess-0.2.1-RC1/src/macosx/makeapp.pl dreamchess-0.2.1-RC1/src/pgn_scanner.c
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- Christan, thanks for your review. All found issues are fixed.
Spec URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-2.RC1.fc...
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7575357
(In reply to Christian Dersch from comment #4)
Issues:
- Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
==> You can remove "rm -rf $RPM_BUILD_ROOT" for current Fedora releases (but required for EPEL5)
done.
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/review/1140403-dreamchess/licensecheck.txt
==> Please check this, licensecheck.txt is below, but BSD license is also mentioned in COPYRIGHT file
done.
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/dreamchess [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dreamchess
==> Please check this
done.
[!]: Package complies to the Packaging Guidelines
==> You are packaging RC1, not the final version! Please add this information in release tag https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
done.
[!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- data ==> Please fix this, Requires: %{name}-%{version} instead of %{name}
done.
[!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _suffix -RC1, %define _engine dreamer ==> Please adjust this when fixing spec
done.
licensecheck.txt … Unknown or generated
dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.c
Cause the corresponding header is licensed properly, assume this file admits it.
dreamchess-0.2.1-RC1/src/include/git_rev.h
Could be ignored for licensing cause it gives only a checkout revision.
dreamchess-0.2.1-RC1/src/macosx/makeapp.pl
MacOS? Perl? Not needed build script. Ignored.
dreamchess-0.2.1-RC1/src/pgn_scanner.c
Cause the corresponding header is licensed properly, assume this file admits it.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1141506
--- Comment #6 from Raphael Groner projects.rg@smart.ms --- fedora-review fails, due to a mock bug #1141506.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1141506 [Bug 1141506] [abrt] mock: subprocess.py:1327:_execute_child:OSError: [Errno 2] No such file or directory
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #7 from Christian Dersch chrisdersch@gmail.com --- Maybe I explained dependency with specific version in anambiguous way,
[!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- data ==> Please fix this, Requires: %{name}-%{version} instead of %{name}
should be Requires: %{name} = %{version}-%{release}
Sorry for any inconvenience!
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #8 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-3.RC1.fc...
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7576019
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #9 from Christian Dersch chrisdersch@gmail.com --- Thanks for the fixes :) There is one last thing missing: You have to add some information about the different licensed files in your spec.
Christian
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/review/1140403-dreamchess/licensecheck.txt
==> Checked and analyzed with Raphael, is ok
[x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec.
==> Please document this in spec (you can use COPYRIGHT file das a base)
[x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- engine , dreamchess-data
==> Is ok as data contains only noarch and the engine part is independent
[x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6461440 bytes in /usr/share ==> Ok
[x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dreamchess-0.2.1-3.RC1.fc22.x86_64.rpm dreamchess-engine-0.2.1-3.RC1.fc22.x86_64.rpm dreamchess-data-0.2.1-3.RC1.fc22.noarch.rpm dreamchess-0.2.1-3.RC1.fc22.src.rpm dreamchess-data.noarch: W: no-documentation dreamchess.src:18: W: macro-in-comment %{name} dreamchess.src:18: W: macro-in-comment %{version} dreamchess.src:18: W: macro-in-comment %{release} dreamchess.src:40: W: unversioned-explicit-provides chessprogram 4 packages and 0 specfiles checked; 0 errors, 5 warnings.
==> Ok
Rpmlint (installed packages) ---------------------------- # rpmlint dreamchess-data dreamchess dreamchess-engine dreamchess-data.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:'
==> Ok, documentation is installed with dreamchess package which is a requirement
Requires -------- dreamchess-data (rpmlib, GLIBC filtered): dreamchess
dreamchess (rpmlib, GLIBC filtered): chessprogram dreamchess-data libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_mixer-1.2.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH)
dreamchess-engine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH)
Provides -------- dreamchess-data: dreamchess-data
dreamchess: application() application(dreamchess.desktop) dreamchess dreamchess(x86-64)
dreamchess-engine: chessprogram dreamchess-engine dreamchess-engine(x86-64)
Source checksums ---------------- http://sf.net/projects/dreamchess/files/dreamchess/Git/dreamchess-0.2.1-RC1.... : CHECKSUM(SHA256) this package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 CHECKSUM(SHA256) upstream package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 https://raw.githubusercontent.com/Arch-Games/arch-games/master/packages/drea... : CHECKSUM(SHA256) this package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd CHECKSUM(SHA256) upstream package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1140403 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #10 from Christian Dersch chrisdersch@gmail.com --- Wait, there is another big issue. I found that files contained in data-package in /usr/share are also part of the main package => conflict!
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #11 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-4.RC1.fc...
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7576363
(In reply to Christian Dersch from comment #9)
[!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec.
==> Please document this in spec (you can use COPYRIGHT file das a base)
done.
(In reply to Christian Dersch from comment #10)
Wait, there is another big issue. I found that files contained in data-package in /usr/share are also part of the main package => conflict!
done. Hint: use %dir
Still in doubt about a correct licence model. Did you notice the folder src/doc/ with various licence texts inside? Though, I can not detect where those texts should exactly belong to.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #12 from Raphael Groner projects.rg@smart.ms --- Small additional rework done to folders ownership without touching release tag.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Christian Dersch chrisdersch@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #13 from Christian Dersch chrisdersch@gmail.com --- Approved! License stuff seem to be fine now and the package looks and works fine :) I already played a game and lost against the engine...
Christian
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/review/1140403-dreamchess/licensecheck.txt
==> We checked this, see reviews before
[x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dreamchess- engine , dreamchess-data [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dreamchess-0.2.1-4.RC1.fc22.x86_64.rpm dreamchess-engine-0.2.1-4.RC1.fc22.x86_64.rpm dreamchess-data-0.2.1-4.RC1.fc22.noarch.rpm dreamchess-0.2.1-4.RC1.fc22.src.rpm dreamchess-data.noarch: W: no-documentation dreamchess.src:19: W: macro-in-comment %{name} dreamchess.src:19: W: macro-in-comment %{version} dreamchess.src:19: W: macro-in-comment %{release} dreamchess.src:41: W: unversioned-explicit-provides chessprogram 4 packages and 0 specfiles checked; 0 errors, 5 warnings.
==> Everything ok
Rpmlint (installed packages) ---------------------------- # rpmlint dreamchess-data dreamchess dreamchess-engine dreamchess-data.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:'
Requires -------- dreamchess-data (rpmlib, GLIBC filtered): dreamchess
dreamchess (rpmlib, GLIBC filtered): chessprogram dreamchess-data libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_mixer-1.2.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH)
dreamchess-engine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH)
Provides -------- dreamchess-data: dreamchess-data
dreamchess: application() application(dreamchess.desktop) dreamchess dreamchess(x86-64)
dreamchess-engine: chessprogram dreamchess-engine dreamchess-engine(x86-64)
Source checksums ---------------- http://sf.net/projects/dreamchess/files/dreamchess/Git/dreamchess-0.2.1-RC1.... : CHECKSUM(SHA256) this package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 CHECKSUM(SHA256) upstream package : 4956e986d4d0077f275f9f4015e39958d2a135324c9e11f8f0943a8a0d140fc9 https://raw.githubusercontent.com/Arch-Games/arch-games/master/packages/drea... : CHECKSUM(SHA256) this package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd CHECKSUM(SHA256) upstream package : caaa0ea9ff7f3a5795a2b2628d1a33cb093c07f5f1f17b0418c27a78dd4efddd
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1140403 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #14 from Raphael Groner projects.rg@smart.ms --- New Package SCM Request ======================= Package Name: dreamchess Short Description: Portable, open-source and 3D chess game Upstream URL: http://www.dreamchess.org/ Owners: raphgro Branches: f20 f21 InitialCC: lupinix
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #15 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-09-17 15:21:40
--- Comment #16 from Raphael Groner projects.rg@smart.ms --- Pushed to rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- dreamchess-0.2.1-4.RC1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/dreamchess-0.2.1-4.RC1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- dreamchess-0.2.1-4.RC1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dreamchess-0.2.1-4.RC1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |dreamchess-0.2.1-4.RC1.fc20 Resolution|NEXTRELEASE |ERRATA
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- dreamchess-0.2.1-4.RC1.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|dreamchess-0.2.1-4.RC1.fc20 |dreamchess-0.2.1-4.RC1.fc21
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- dreamchess-0.2.1-4.RC1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1141506 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1141506 [Bug 1141506] [abrt] mock: subprocess.py:1327:_execute_child:OSError: [Errno 2] No such file or directory
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1305390
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1305390 [Bug 1305390] Review Request: dreamchess-tools - DreamChess Tools
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla