[Bug 2188675] New: Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

Bug ID: 2188675
           Summary: Review Request: golang-github-moby-pubsub - None
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://sergiomb.fedorapeople.org/golang-github-moby-pubsub/golang-github-mo...
SRPM URL:
https://sergiomb.fedorapeople.org/golang-github-moby-pubsub/golang-github-mo...

Description:
golang-github-moby-pubsub

Fedora Account System Username: sergiomb

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

--- Comment #1 from Sergio Basto  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=100216997

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Maxwell G  ---
Please change `%gometa -f` to `%gometa` and replace `%global
common_description` and Summary with more useful text.

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

--- Comment #3 from Sergio Basto  ---
(In reply to Maxwell G from comment #2)
> Please change `%gometa -f` to `%gometa` and replace `%global
> common_description` and Summary with more useful text.

done in the same locations

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?
                   |                            |needinfo?([e-mail]
                   |                            |)
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Robert-André Mauchin 🐧  ---
 - Add a Summary and a valid Description.

Like:

%global common_description %{expand:
Concurrent Go library for broadcasting messages to subscribers with optional
topic filtering and send timeouts}

Summary:        Concurrent Go library for broadcasting messages to subscribers

- Use autorelease/autochangelog please

- Add a new line between these:

%global golicenses      NOTICE LICENSE
Name:           %{goname}

- Read the notice:
> This product contains software (https://github.com/creack/pty) developed
> by Keith Rarick, licensed under the MIT License.

And this add MIT to the License field and a comment explaining why:

# Apache 2.0: main codegithub.com/creack/pty
# This product contains software (https://github.com/creack/pty) developed
# by Keith Rarick, licensed under the MIT License.
License:        Apache-2.0 AND MIT
URL:            %{gourl}
Source:         %{gosource}

Please update your SPEC accordingly and needinfo me.

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

Sergio Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|NOTABUG                     |---
           Keywords|                            |Reopened

[Bug 2188675] Review Request: golang-github-moby-pubsub - None

https://bugzilla.redhat.com/show_bug.cgi?id=2188675

Sergio Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|2023-09-14 00:45:22         |2025-02-27 19:54:46