Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libbase - JFree Base Services
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Summary: Review Request: libbase - JFree Base Services Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: caolanm@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://people.redhat.com/caolanm/rpms/libbase.spec SRPM URL: http://people.redhat.com/caolanm/rpms/libbase-1.0.0-1.fc10.src.rpm Description: libbase - JFree Base Services
libbase is a new dependency of the jfreereport family of packages, e.g. jcommon, jcommon-serializer etc which themselves are a dependency of openoffice.org's openoffice.org-report-designer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Caolan McNamara caolanm@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |446452(F11Blocker)
--- Comment #1 from Caolan McNamara caolanm@redhat.com 2009-03-05 04:11:06 EDT --- Filed three months ago in anticipation, but today is when it becomes a requirement for 3.1 :-(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2009-03-05 17:12:22 EDT --- Sorry nobody has looked at this for so long; I've been mostly taking a break from reviewing packages.
This package looks fine; the only question I have is whether build-jar-repository should be called in %prep or in %build. The guidelines don't say one way or the other. I don't think this is worth holding things up over, although personally I like to be able to prep a package without installing its dependencies.
* source files match upstream. sha256sum: 6c4d907e912fbbda8228707540f5dab2954aa0e6f2ce1bd1ed9b4f43a7b6972a libbase-1.0.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: libbase.jar.so()(64bit) libbase = 1.0.0-1.fc11 libbase(x86-64) = 1.0.0-1.fc11 = /bin/sh jakarta-commons-logging java java-gcj-compat >= 1.0.31 jpackage-utils libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) libz.so.1()(64bit)
* no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (gcj database rebuilding). * code, not content. * %docs are not necessary for the proper functioning of the package.
* no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. * ant called properly. * no wrapper script necessary. * gcj called properly.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Caolan McNamara caolanm@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Caolan McNamara caolanm@redhat.com 2009-03-06 04:25:45 EDT --- New Package CVS Request ======================= Package Name: libbase Short Description: JFree Base Services Owners: caolanm Branches: devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2009-03-07 12:28:40 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474391
Caolan McNamara caolanm@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #5 from Caolan McNamara caolanm@redhat.com 2009-03-09 06:11:10 EDT --- thanks guys
package-review@lists.fedoraproject.org