https://bugzilla.redhat.com/show_bug.cgi?id=824218
Bug ID: 824218 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: polly - twitter client Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: aalves@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-1.fc16.src.rpm Description: Polly is a Linux Twitter client designed for managing multiple columns of multiple accounts, purposefully keeping them separated instead of merged. Fedora Account System Username: alvesadrian
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rosser.bjr@gmail.com
--- Comment #1 from Ben Rosser rosser.bjr@gmail.com --- Did an initial (informal) review of this. Rpmlint output is below:
polly.src:43: W: macro-in-comment %{buildroot} polly.src:43: W: macro-in-comment %{_datadir} polly.src:43: W: macro-in-comment %{name} polly.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3) polly.src: W: invalid-url Source0: https://launchpad.net/polly/1.0/pre-alpha-2/+download/Polly-0.93.4 (pre-alpha 3.4).tar.gz HTTP Error 404: Not Found polly.noarch: E: explicit-lib-dependency python-httplib2 polly.noarch: W: no-documentation polly.noarch: W: no-manual-page-for-binary polly polly.noarch: E: invalid-desktopfile /usr/share/applications/polly.desktop value "GTK;Network" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
The macro-in-comment stuff can be ignored, I think. However, the line that's commented was a desktop-file-validate command, and that command would otherwise cause the build process to fail because the desktop file is invalid. Because of that.. well, refer to https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Desktop files MUST be formatted properly, and desktop-file-validate (or -install) must be ran on them. So I think you either need to patch this yourself or submit a patch upstream.
The lack of documentation and manual page is also a problem, but.. if there isn't any upstream, there's not much to do about it, unless you feel like writing some yourself.
Looking at the spec file, you are also not taking ownership of a directory (specifically, the one in %python_sitelib):
%files %{_bindir}/polly %{_datadir}/polly/ %python_sitelib/polly/* %python_sitelib/%{upsname}-%{version}.* %{_datadir}/applications/%{name}.desktop %{_datadir}/gconf/schemas/%{name}.schemas %{_datadir}/icons/*
Something maybe to be concerned about is that the build process is throwing a *lot* of warnings when installing schemas. I'm not sure if anything can be done about that, or indeed if it's actually a problem, but I thought I'd point it out. Here's my rpmbuild output: http://fpaste.org/D8Ho/
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #2 from Adrian Alves aalves@gmail.com --- (In reply to comment #1)
Did an initial (informal) review of this. Rpmlint output is below:
polly.src:43: W: macro-in-comment %{buildroot} polly.src:43: W: macro-in-comment %{_datadir} polly.src:43: W: macro-in-comment %{name} polly.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3) polly.src: W: invalid-url Source0: https://launchpad.net/polly/1.0/pre-alpha-2/+download/Polly-0.93.4 (pre-alpha 3.4).tar.gz HTTP Error 404: Not Found polly.noarch: E: explicit-lib-dependency python-httplib2 polly.noarch: W: no-documentation polly.noarch: W: no-manual-page-for-binary polly polly.noarch: E: invalid-desktopfile /usr/share/applications/polly.desktop value "GTK;Network" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
The macro-in-comment stuff can be ignored, I think. However, the line that's commented was a desktop-file-validate command, and that command would otherwise cause the build process to fail because the desktop file is invalid. Because of that.. well, refer to https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Desktop files MUST be formatted properly, and desktop-file-validate (or -install) must be ran on them. So I think you either need to patch this yourself or submit a patch upstream.
The lack of documentation and manual page is also a problem, but.. if there isn't any upstream, there's not much to do about it, unless you feel like writing some yourself.
Looking at the spec file, you are also not taking ownership of a directory (specifically, the one in %python_sitelib):
%files %{_bindir}/polly %{_datadir}/polly/ %python_sitelib/polly/* %python_sitelib/%{upsname}-%{version}.* %{_datadir}/applications/%{name}.desktop %{_datadir}/gconf/schemas/%{name}.schemas %{_datadir}/icons/*
Something maybe to be concerned about is that the build process is throwing a *lot* of warnings when installing schemas. I'm not sure if anything can be done about that, or indeed if it's actually a problem, but I thought I'd point it out. Here's my rpmbuild output: http://fpaste.org/D8Ho/
Added %%files fixes Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-2.fc16.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build for f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4488148
Build fails, this is from build.log:
RPM build errors: /var/tmp/rpm-tmp.KcwIBZ: line 39: gconftool-2: command not found
You have to add GConf2 to BuildRequires.
For a better readability, you might shrink the %files list, as follows:
%files %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop %{_datadir}/gconf/schemas/%{name}.schemas %{_datadir}/icons/hicolor/*/*/* %{_datadir}/%{name}/iconsets %{python_sitelib}/*.egg-info %{python_sitelib}/%{name}
This covers all needed directory ownerships and avoid undesired owning of directories from other packages. For the icons you would need hicolor-icon-theme, but this is a requirement of gtk2 anyway. For updating the icon cache, a scriptlet is mandatory: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #4 from Adrian Alves aalves@gmail.com --- Added %%files fixes and gconf2 dependencie Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-2.fc16.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #5 from Mario Blättermann mario.blaettermann@gmail.com --- (In reply to comment #3)
For updating the icon cache, a scriptlet is mandatory: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #6 from Adrian Alves aalves@gmail.com --- Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-4.fc16.src.rpm
done
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #7 from Mario Blättermann mario.blaettermann@gmail.com --- New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4499545
It fails again. From build.log:
+ export GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults + GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults + gconftool-2 --makefile-install-rule share/gconf/schemas/polly.schemas Attached schema `/schemas/apps/polly/account/id' to key `/apps/polly/account/id' WARNING: failed to install schema `/schemas/apps/polly/account/id', locale `C': Unable to store a value at key '/schemas/apps/polly/account/id', as the configuration server has no writable databases. There are some common causes of this problem: 1) your configuration path file /etc/gconf/2/path doesn't contain any databases or wasn't found 2) somehow we mistakenly created two gconfd processes 3) your operating system is misconfigured so NFS file locking doesn't work in your home directory or 4) your NFS client machine crashed and didn't properly notify the server on reboot that file locks should be dropped. If you have two gconfd processes (or had two at the time the second was launched), logging out, killing all copies of gconfd, and logging back in may help. If you have stale locks, remove ~/.gconf*/*lock. Perhaps the problem is that you attempted to use GConf from two machines at once, and ORBit still has its default configuration that prevents remote CORBA connections - put "ORBIIOPIPv4=1" in /etc/orbitrc. As always, check the user.* syslog for details on problems gconfd encountered. There can only be one gconfd per home directory, and it must own a lockfile in ~/.gconfd and also lockfiles in individual storage locations such as ~/.gconf Attached schema `/schemas/apps/polly/account/interval' to key `/apps/polly/account/interval' WARNING: failed to install schema `/schemas/apps/polly/account/interval', locale `C': Unable to store a value at key '/schemas/apps/polly/account/interval', as the configuration server has no writable databases. There are some common causes of this problem: 1) your configuration path file /etc/gconf/2/path doesn't contain any databases or wasn't found 2) somehow we mistakenly created two gconfd processes 3) your operating system is misconfigured so NFS file locking doesn't work in your home directory or 4) your NFS client machine crashed and didn't properly notify the server on reboot that file locks should be dropped. If you have two gconfd processes (or had two at the time the second was launched), logging out, killing all copies of gconfd, and logging back in may help. If you have stale locks, remove ~/.gconf*/*lock. Perhaps the problem is that you attempted to use GConf from two machines at once, and ORBit still has its default configuration that prevents remote CORBA connections - put "ORBIIOPIPv4=1" in /etc/orbitrc. As always, check the user.* syslog for details on problems gconfd encountered. There can only be one gconfd per home directory, and it must own a lockfile in ~/.gconfd and also lockfiles in individual storage locations such as ~/.gconf Attached schema `/schemas/apps/polly/entry/check' to key `/apps/polly/entry/check' WARNING: failed to install schema `/schemas/apps/polly/entry/check', locale `C': Unable to store a value at key '/schemas/apps/polly/entry/check', as the configuration server has no writable databases. There are some common causes of this problem: 1) your configuration path file /etc/gconf/2/path doesn't contain any databases or wasn't found 2) somehow we mistakenly created two gconfd processes 3) your operating system is misconfigured so NFS file locking doesn't work in your home directory or 4) your NFS client machine crashed and didn't properly notify the server on reboot that file locks should be dropped. If you have two gconfd processes (or had two at the time the second was launched), logging out, killing all copies of gconfd, and logging back in may help. If you have stale locks, remove ~/.gconf*/*lock. Perhaps the problem is that you attempted to use GConf from two machines at once, and ORBit still has its default configuration that prevents remote CORBA connections - put "ORBIIOPIPv4=1" in /etc/orbitrc. As always, check the user.* syslog for details on problems gconfd encountered. There can only be one gconfd per home directory, and it must own a lockfile in ~/.gconfd and also lockfiles in individual storage locations such as ~/.gconf Attached schema `/schemas/apps/polly/entry/override' to key `/apps/polly/entry/override'
Seems to be gconftool is unable to install schema files. My experience in gconf stuff is poor, I cannot say what fails in particular. Maybe you should read the appropriate part of the packaging guidelines: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #8 from Mario Blättermann mario.blaettermann@gmail.com --- Any news...?
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #9 from Adrian Alves aalves@gmail.com --- Any ideas about how we can fix this? still the issue with koji?
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #10 from Matthias Runge mrunge@redhat.com --- Something completely different:
rpm -qf /usr/share/icons/hicolor hicolor-icon-theme-0.12-4.fc17.noarch fedora-logos-17.0.3-1.fc17.noarch -> you must require (I suggest hicolor-icon-theme) for using /usr/share/icons/hicolor
just a guess on that gconf-error: you're trying to modify the gconf database of the koji server, there must be an option to specify that. And also you can't be the only person hitting that issue.
Another issue: python-gconf is not available (at in rawhide and f17) You might want to fix that issue first...
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #11 from Mario Blättermann mario.blaettermann@gmail.com --- Requires: python-gtk2
This doesn't exist for Fedora, and we don't have a package which provides it virtually. We have pygtk2 only.
(In reply to comment #10)
-> you must require (I suggest hicolor-icon-theme) for using /usr/share/icons/hicolor
Not needed at all. Pygtk2 depends on gtk2, and gtk2 depends on hicolor-icon-theme anyway.
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aalves@gmail.com Flags| |needinfo?(aalves@gmail.com)
--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu --- There hasn't been a buildable package in this ticket for at least eight months; I guess this should just be closed out unless a reviewable package is posted soon.
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Conscious User conscioususer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |conscioususer@gmail.com Flags| |needinfo?
--- Comment #13 from Conscious User conscioususer@gmail.com --- Hi, Polly developer here! I have zero experience with RPM packaging, but would like to know what I can do to help. What are the current blockers?
https://bugzilla.redhat.com/show_bug.cgi?id=824218
--- Comment #14 from Matthias Runge mrunge@redhat.com --- Conscious User: Thank you for popping up. Currently, it looks like the submitter was not able to submit a buildable package. Best thing would be to wait for Adrian to explain, how he'd like to proceed here. This was requested two months ago.
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Adrian Alves aalves@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(aalves@gmail.com) | |needinfo? |
--- Comment #15 from Adrian Alves aalves@gmail.com --- Sorry I been busy with my job didnt get the chance to finish with this package if someone wants to continue is ok from me if not I will build a package for this in 3 or 4 weeks when my job allow me
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Summary|Review Request: polly - |Review Request: polly - |twitter client |Linux Twitter client | |designed for multiple | |columns of multiple | |accounts
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(aalves@gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Michele Baldessari michele@acksyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC| |michele@acksyn.org
https://bugzilla.redhat.com/show_bug.cgi?id=824218
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|INSUFFICIENT_DATA |DUPLICATE
--- Comment #22 from Christopher Meng cickumqt@gmail.com ---
*** This bug has been marked as a duplicate of bug 1026042 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla