https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Bug ID: 2335293 Summary: Review Request: rust-notify-types - Types used by the notify crate Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 2321807 Target Milestone: --- Classification: Fedora
Created attachment 2064531 --> https://bugzilla.redhat.com/attachment.cgi?id=2064531&action=edit Configuration file for rust2rpm
Spec URL: https://music.fedorapeople.org/rust-notify-types.spec SRPM URL: https://music.fedorapeople.org/rust-notify-types-1.0.1-1.fc41.src.rpm Description: Types used by the notify crate. Fedora Account System Username: music
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2321807 [Bug 2321807] rust-notify-7.0.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Ben Beasley code@musicinmybrain.net --- https://release-monitoring.org/project/376196/
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/no | |tify-types
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8464223 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8464224 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- It looks like one included file still has the old license header: src/event.rs
This references the old CC0-1.0 / Artistic-ish license of notify < 6, so it's probably a mistake, but it would be good to get confirmation.
Other than that, the package LGTM.
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- (In reply to Fabio Valentini from comment #4)
It looks like one included file still has the old license header: src/event.rs
This references the old CC0-1.0 / Artistic-ish license of notify < 6, so it's probably a mistake, but it would be good to get confirmation.
Other than that, the package LGTM.
Hmm, according to https://github.com/notify-rs/notify/commit/08e74dae8e96fbd25704cdaa530ffc02f... this file was just moved over from the notify crate, so the header is probably correct. (The actual notify crate wasn’t relicensed for 7.0.0; it’s still CC0-1.0.)
I guess I’ll open an upstream PR to adjust the crate license from MIT OR Apache-2.0 to (MIT OR Apache-2.0) AND (CC0-1.0 OR Artistic-2.0).
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
--- Comment #6 from Ben Beasley code@musicinmybrain.net --- New Spec URL: https://music.fedorapeople.org/20250102/rust-notify-types.spec New SRPM URL: https://music.fedorapeople.org/20250102/rust-notify-types-1.0.1-1.fc41.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #2064531 is| | obsolete| |
--- Comment #7 from Ben Beasley code@musicinmybrain.net --- Created attachment 2064543 --> https://bugzilla.redhat.com/attachment.cgi?id=2064543&action=edit Updated configuration file for rust2rpm
The spec file is no longer the unmodified output of rust2rpm; some comments are added manually, and so is the LICENSE-CC0 file in the %files list.
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2064544 --> https://bugzilla.redhat.com/attachment.cgi?id=2064544&action=edit The .spec file difference from Copr build 8464224 to 8464549
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8464549 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #10 from Fabio Valentini decathorpe@gmail.com --- Thank you, this looks good to me. If the upstream project removes the differing license header from src/events.rs in the next release, as they suggest in the upstream ticket, the additional CC0-1.0 license can be dropped again. I agree that this use of CC0-1.0 for code in a new package falls under the rule that CC0-1.0 licensed code that was in Fedora before it was dropped as a "good" license, since the file in question has just been moved from the "notify" into the "notify-types" project as of version 7.0.0 of the "notify" crate.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged 🫤 license matches upstream specification and is acceptable for Fedora (with justified clarifications) ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #11 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-notify-types
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-3a3f9ff8bd (rust-notify-types-1.0.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a3f9ff8bd
https://bugzilla.redhat.com/show_bug.cgi?id=2335293
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-01-03 13:40:55
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-3a3f9ff8bd (rust-notify-types-1.0.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com