[Bug 547916] New: Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Summary: Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://rdieter.fedorapeople.org/rpms/fedora-kde-icon-theme/fedora-kde-icon-t... SRPM URL: http://rdieter.fedorapeople.org/rpms/fedora-kde-icon-theme/fedora-kde-icon-t... Description: Default icon theme for KDE Desktops on fedora
Currently, this content is included in kde-settings, and is not much more than a skeleton.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |547701
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2009-12-15 19:54:35 EDT --- Once reviewed, this move will also require changes in fedora-logos (and generic-logos) to reflect it's new location. I can take care of that...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org AssignedTo|nobody@fedoraproject.org |kevin@tigcc.ticalc.org Flag| |fedora-review?
--- Comment #2 from Kevin Kofler kevin@tigcc.ticalc.org 2009-12-16 11:13:34 EDT --- I'm going to review this, looks fairly straightforward at a first glance.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2009-12-30 12:33:35 EDT --- ping ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org 2009-12-30 14:05:21 EDT --- Uh, sorry, my Internet connection at home broke down, so I have only limited connectivity at the moment. :-( I'll see what I can do.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
--- Comment #5 from Kevin Kofler kevin@tigcc.ticalc.org 2009-12-30 14:10:45 EDT --- First observation: rpmlint has no complaints, that's nice. :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Kevin Kofler kevin@tigcc.ticalc.org 2009-12-30 14:58:44 EDT --- MUST Items: + rpmlint output is blank ("0 errors, 0 warnings") + named and versioned according to the naming guidelines + Name matches spec name + package meets Packaging Guidelines + License: GPLv2+ and CC-BY-SA valid, matches actual license + COPYING.* included as %doc + spec file in American English and legible + source matches upstream: MD5: 81ef91585e5d0356f127559cc4477f6e SHA1: ebe1295cd05cce7fe53a4c8a83ff1db183d3ff28 SHA256: c539f2150ee8fc0bce40291d0ab1169790128e82c5473d252e21bba08e4e1324 + builds successfully (Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1896041 ) + no ExcludeArch needed + no missing BRs + no translations, shared libraries, bundled system libraries + not relocatable + all created directories (not already owned by filesystem) owned + all files listed only once + permissions are sane, %defattr used properly + %clean section present and valid + macros used consistently + the packaged content is permissible under CodeVsContent (icon theme) + no large documentation files => no -doc subpackage needed + %doc files not required at runtime + no header files, static libraries, .pc files, .so files, -devel subpackage, .la files or GUI applications + does not own files or directories already owned by another package + rm -rf %{buildroot} run at the beginning of %install + all filenames are valid UTF-8
SHOULD Items: + license texts already included in the tarball + no translated summary and description available, so none needs to be provided + builds in mock (Koji scratch build) * arch-independent, so expected to build on all architectures, skipping all arch test * skipping functionality test + scriptlets are sane, match standard snippets + no subpackages => no versioned deps on the base package needed + no .pc files + no file dependencies
Nitpick: Please add README as %doc as it contains part of the licensing information. But this is trivial and can be addressed after the import.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2009-12-30 20:59:37 EDT --- New Package CVS Request ======================= Package Name: fedora-kde-icon-theme Short Description: Default Icon theme for KDE Desktops on fedora Owners: rdieter Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-01-02 15:11:19 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547916
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #9 from Rex Dieter rdieter@math.unl.edu 2010-01-05 16:35:38 EDT --- imported, thanks!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla